Commit Graph
59 Commits
Author SHA1 Message Date
jpmschweitzerandClaude Opus 4.6 b41b6dab18 fix(events): replace negative add_gold with remove_short_term_gold
CK3 does not support negative values for add_gold. Replaced all 14
instances across 6 event files with remove_short_term_gold, which
is the correct CK3 effect for deducting gold.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 22:09:57 +01:00
jpmschweitzerandClaude Opus 4.6 e614bacbca feat(game-rules): add narrative/sandbox game mode toggle
Created mistborn_game_mode game rule with narrative_mode (default)
and sandbox_mode options. Appears on the game setup screen.
Narrative mode enables curated story events; sandbox mode enables
the Discover Your Metallic Arts decision and suppresses story arcs.
Matching triggers added in prior commit.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 22:09:50 +01:00
jpmschweitzerandClaude Opus 4.6 eeb18da1c1 feat(decisions): suppress 34 vanilla decision files
Created empty replacement files for all vanilla CK3 decision files
to prevent non-Mistborn decisions from appearing in the decision
menu. Covers major decisions, activities, religious, lifestyle,
DLC, regional, and culture-specific decisions.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 22:09:39 +01:00
jpmschweitzerandClaude Opus 4.6 b291d65900 fix(bookmarks): add portraits, bookmark group, and fix suppression
- Created bookmark_portraits/ with placeholder portrait definitions
  for all 4 bookmark characters (regenerate in-game with
  dump_bookmark_portraits for proper visuals)
- Added bm_group_1020 bookmark group and localization
- Added start_date to vanilla bookmark suppression entries (required
  field per ck3-tiger)
- Removed invalid background field from bookmark definition
- Added replace_path directives for bookmarks to mod descriptors
- Adjusted character positions on the bookmark screen

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 22:09:27 +01:00
jpmschweitzerandClaude Opus 4.6 368ad742ef fix(culture): add missing color property to language pillars
Added color to language_scadrial and language_terris pillars to
match the vanilla CK3 pattern. Without this, the culture UI may
not display language indicators correctly.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 22:09:17 +01:00
jpmschweitzerandClaude Opus 4.6 bfd4431869 fix(decisions): unify Lord Ruler attention on variable-based system
Removed the generic lord_ruler_attention_modifier and unified both
decision checks onto the variable system (var:lord_ruler_attention).
The on_action yearly pulse now applies/removes tiered modifiers
(lord_ruler_attention_1/2/3) based on variable thresholds, giving
players visible feedback that matches the underlying variable state.

Fixes WARNING-05 from the mod review.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 22:09:11 +01:00
jpmschweitzerandClaude Opus 4.6 d125178f67 fix(triggers): separate active/dormant allomancy and feruchemy triggers
Split over-inclusive triggers into distinct variants:
- is_feruchemist_trigger now matches only active trait_feruchemist
- has_allomantic_potential_trigger now excludes already-snapped chars
- Added has_any_feruchemy_trigger and has_any_allomantic_ability_trigger
  for broad matching when needed
- Added is_narrative_mode_trigger and is_sandbox_mode_trigger for the
  new game mode system

Fixes WARNING-06 and WARNING-07 from the mod review.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 22:09:04 +01:00
jpmschweitzerandClaude Opus 4.6 a164f1b189 data(history): remap province IDs to vanilla map coordinates
Replaced sequential IDs (1-105) with actual vanilla province IDs
from landed_titles (2030-3107 range). Without this fix, no province
had valid culture, religion, or holding data at game start because
CK3 matches province history by vanilla map IDs.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 22:08:57 +01:00
jpmschweitzerandClaude Opus 4.6 8656095605 chore(meta): update changelog
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 20:53:33 +01:00
jpmschweitzerandClaude Opus 4.6 a259b6c0e8 feat(gfx): add 5 loading screen illustrations
Add custom loading screens replacing vanilla illustrations:
- ls_vin_mists (show_first priority)
- ls_luthadel_skyline
- ls_kredik_shaw
- ls_ashmounts
- ls_kelsier_overlooking

Includes loadscreen_settings.txt with priority 2 for all screens.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 20:53:11 +01:00
jpmschweitzerandClaude Opus 4.6 3d2315f3ea feat(bookmarks): add bookmark background art and suppress vanilla bookmarks
Add background DDS art for the "End of an Empire" bookmark and
reference it in the bookmark definition. Add vanilla bookmark
suppression file to hide all base-game bookmarks since this is a
total conversion.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 20:53:01 +01:00
jpmschweitzerandClaude Opus 4.6 e685d5a72e chore(meta): update changelog
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 20:27:26 +01:00
jpmschweitzerandClaude Opus 4.6 36953309d1 docs(meta): fix trait icon filenames in asset requirements
Corrected allomantic strength trait filenames from
trait_allomantic_strength_* to trait_allomantic_* to match
actual trait definitions in code.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 20:27:03 +01:00
jpmschweitzerandClaude Opus 4.6 ede70edced feat(traits): add 26 trait icons for metallic arts system
All trait icons generated via Nano Banana and converted to
uncompressed ARGB DDS at 120x120. Covers the full metallic arts
system: 12 Misting types, Mistborn, 3 Allomantic strength tiers,
2 Allomantic potential tiers, Feruchemist + potential, and 6
Hemalurgy variants. Dark fantasy painterly style with consistent
visual identity across trait families.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 20:26:56 +01:00
jpmschweitzerandClaude Opus 4.6 b088e0471d chore(meta): add asset-gen skill for visual asset generation
Skill for generating CK3-native art assets using the Nano Banana
(Gemini 2.5 Flash Image) MCP tool. Includes style guide, category
prompt templates, and DDS conversion reference. Encodes learnings
from first batch: no circular frames, no vector art, no text,
dark backgrounds edge-to-edge, consistent orientation within trait
families, max 3 parallel generation calls.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 20:26:46 +01:00
jpmschweitzerandClaude Opus 4.6 541b474c36 chore(meta): update changelog
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 18:47:26 +01:00
jpmschweitzerandClaude Opus 4.6 5f633768e6 docs(meta): add comprehensive visual asset requirements document
Catalogues all ~200+ visual assets needed across milestones M1-M8,
with verified specs from CK3 v1.18 game files. Covers trait icons,
modifier icons, decision illustrations, map files, loading screens,
bookmark art, CoA emblems, religion icons, lifestyle assets, activity
assets, event backgrounds, portraits, and workshop thumbnail. Includes
DDS production guide, priority ordering, art style guide, and complete
gfx/ directory structure.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 18:47:09 +01:00
jpmschweitzerandClaude Opus 4.6 f6afda26ba chore(meta): update changelog
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 18:21:59 +01:00
jpmschweitzerandClaude Opus 4.6 7b7620c13c docs(meta): sync documentation with current codebase state
CLAUDE.md: add bookmarks/bookmarks/, opinion_modifiers/, and
religion_families/ to project structure tree.
MASTERPLAN.md: remove resolved trait_knows_hemalurgy item from M1.
REVIEW_NOTES.txt: update WARNING-05 to reflect that tiered attention
modifiers are now defined.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 18:21:47 +01:00
jpmschweitzerandClaude Opus 4.6 8848645b22 chore(meta): update changelog
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 17:59:30 +01:00
jpmschweitzerandClaude Opus 4.6 b7d168aba8 chore(meta): add teammateMode setting
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 17:59:07 +01:00
jpmschweitzerandClaude Opus 4.6 cdca1db756 fix(titles): remove no-op ai_primary_priority and fix bookmark path
- Remove empty ai_primary_priority block from e_final_empire (the
  if block had no effect, causing a lint error)
- Move bookmarks to common/bookmarks/bookmarks/ subdirectory to
  match CK3 1.18 expected path

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 17:59:03 +01:00
jpmschweitzerandClaude Opus 4.6 fb7a517f7b fix(events): use has_character_modifier and add_character_modifier
CK3 1.18 requires the full has_character_modifier and
add_character_modifier forms. The shorthand has_modifier and
add_modifier are not valid in character scope.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 17:58:56 +01:00
jpmschweitzerandClaude Opus 4.6 fd0e1181d7 fix(culture): rename deprecated modifier fields in traditions
- dynasty_prestige_mult → monthly_dynasty_prestige_mult
- scheme_power_mult → owned_personal_scheme_success_chance_add
- Remove hostile_scheme_resistance_mult (removed in CK3 1.18)
- Move cultural_acceptance_gain_mult from character_modifier to
  culture_modifier block where CK3 expects it

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 17:58:49 +01:00
jpmschweitzerandClaude Opus 4.6 69af34cf59 fix(religion): fix doctrine keys, tenets, holy sites, and add family
Doctrine renames to match vanilla CK3 1.18:
- Split adultery doctrine by gender (men/women shunned/accepted)
- doctrine_marriage_monogamous → doctrine_monogamy/concubines
- doctrine_theocracy_spiritual → doctrine_theocracy_lay_clergy
- doctrine_pluralism_hostile → doctrine_pluralism_fundamentalist
- doctrine_kinslaying_criminal → doctrine_kinslaying_close_kin_crime
- Remove doctrine_concubines_allowed/none (redundant with marriage)

Tenet renames:
- tenet_divine_right → tenet_legalism
- tenet_religious_law → tenet_religious_legal_pronouncements
- tenet_liberation_theology → tenet_unrelenting_faith

Also: remove reformed_icon from all faiths (only valid for
unreformed pagan faiths), create rf_scadrial religion family
definition, fix is_active from block to value in holy sites.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 17:58:44 +01:00
jpmschweitzerandClaude Opus 4.6 d61ad6f72a fix(modifiers): rename deprecated fields and relocate opinion modifier
- dynasty_prestige_mult → monthly_dynasty_prestige_mult
- Remove hostile_scheme_power_mult (removed in CK3 1.18)
- county_opinion → county_opinion_add
- Move disapproves_skaa_mercy to common/opinion_modifiers/ where
  CK3 expects opinion modifier definitions

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 17:58:31 +01:00
jpmschweitzerandClaude Opus 4.6 cfb9cde999 fix(decisions): fix CK3 1.18 syntax errors in decisions
- Convert picture fields from string to block format
- Use vanilla trait names (ambitious, sadistic, greedy, callous,
  compassionate) instead of trait_ prefixed versions
- Move stress from cost block to add_stress in effect block
- Fix add_opinion: add required target field, remove redundant
  opinion value

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 17:58:25 +01:00
jpmschweitzerandClaude Opus 4.6 1c2699aa53 chore(meta): update changelog
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 17:42:00 +01:00
jpmschweitzerandClaude Opus 4.6 52e0e5b092 fix(history): remove redundant male = yes and fix trait/picture syntax
CK3 defaults to male when no gender is specified, so explicit
male = yes is unnecessary. Fixed decision picture to use reference
block syntax. Changed deprecated beautiful trait to beauty_good_3.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 17:41:42 +01:00
jpmschweitzerandClaude Opus 4.6 6abe8a8496 fix(traits): remove invalid index fields and fix opposite keyword
CK3 1.18 does not use explicit trait index assignments — they are
auto-assigned by load order. Also fixed `opposite` → `opposites`
(correct CK3 keyword) on allomantic strength traits.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 17:41:37 +01:00
jpmschweitzerandClaude Opus 4.6 6075c8eb73 docs(milestones): add gender doctrine and clean up IDEAS.md
Add Gender Doctrine group to M3 task 3.8 with three options:
male_preference (Steel Ministry), equal (Survivorism, Terris),
irrelevant (Cult of Ruin). Women can hold titles, serve in
council, and wield Allomancy in all faiths — only inheritance
order is affected. Add gender preference to M4 government types.
Remove integrated ideas from IDEAS.md (unlanded crew → M5,
debug decisions → TESTING.md).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 17:41:30 +01:00
jpmschweitzerandClaude Opus 4.6 fccca3f6c3 chore(meta): update changelog
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 17:34:51 +01:00
jpmschweitzerandClaude Opus 4.6 84255ab819 docs(meta): add testing protocol and link from all milestones
Create docs/TESTING.md with debug game rule, debug decisions per
milestone, log analysis commands, pre-launch validation script,
post-run analysis script, and Claude Code testing capabilities.
Add cross-reference to TESTING.md in each milestone's Testing
Checkpoints section (M1-M8).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 17:34:33 +01:00
jpmschweitzerandClaude Opus 4.6 fb327194e2 docs(milestones): add education, legacies, governments, factions, and more
Expand M3 with custom education system (5 tracks × 4 tiers), dynasty
legacies (5 universal + 10 house-specific), custom death reasons (12),
and character nicknames (~15). Expand M4 with custom government types
(3), factions (5), vassal contracts (6 terms), secret types (8), hooks
(3), court types (3), and portrait modifier system (10 triggers).
Update MASTERPLAN scope to reflect all new systems.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 17:34:23 +01:00
jpmschweitzerandClaude Opus 4.6 28aea2de49 chore(meta): update changelog
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 17:18:50 +01:00
jpmschweitzerandClaude Opus 4.6 5b1a022f0a docs(meta): capture debug decisions testing idea
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 17:18:39 +01:00
jpmschweitzerandClaude Opus 4.6 c3512a8aa9 chore(meta): add ck3-tiger linting via Makefile
Adds static analysis for CK3 mod files using ck3-tiger. The Makefile
downloads the platform-specific binary and persists the CK3 game
directory path for validation runs.

Targets: make setup, make lint, make clean
Config: lords_of_ash/ck3-tiger.conf (English only, hide vanilla)
Commit skill updated with pre-commit lint step.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 17:18:36 +01:00
jpmschweitzerandClaude Opus 4.6 cef75b4695 chore(meta): update changelog
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 17:01:03 +01:00
jpmschweitzerandClaude Opus 4.6 2b8120034f docs(masterplan): add council, religion, caste, and innovation scope
Update MASTERPLAN.md to reflect new systems added to milestones:
- M3: custom tenets/doctrines, expanded holy sites, Inquisitor
  holy order, Keeper Network secret society
- M4: council retheme + court positions, caste laws, innovation
  eras, legend suppression
- M5: band council with crew roles
- M7: advanced council interactions, post-endgame throne choice

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 17:00:40 +01:00
jpmschweitzerandClaude Opus 4.6 51bc5fa57d docs(milestones): add council, religion, caste, and innovation systems
Expand milestone docs with several major new systems:

M3: Religion overhaul — 12 custom tenets (3 per faith), 2 custom
doctrine groups (Allomantic Stance, Caste Doctrine), expanded holy
sites (~10, differentiated by faith, with conditional sites),
tradition condition fixes, dead parameter cleanup. New task 3.11:
Steel Inquisitor holy order + individual Inquisitor request mechanic,
Keeper Network secret society with progression and discovery risk.

M4: Council retheme (5 positions with 10 custom tasks), 7 court
positions (Royal Court), legend system suppression, caste law system
(3 tiers: Strict/Relaxed/Abolished with cross-caste consequence
events), innovation system (Age of the Lord Ruler pre-unlocked +
Age of Liberation locked behind lord_ruler_fallen flag).

M5: Band council with 7 crew roles, vacancy penalties, ~14 role
events, and 5 band tasks. Each crew member's Allomantic ability
enhances their assigned role.

M7: Advanced council interactions (~25 events) — kandra courtier
replacement, Court Smoker vs Seeker duels, Obligator Witness
betrayal, Terris Steward Keeper reveal. Post-endgame choice: seize
the throne or release the kingdoms. Variable standardized to
lord_ruler_fallen across all docs.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 17:00:34 +01:00
jpmschweitzerandClaude Opus 4.6 07a1491936 chore(meta): update changelog
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 16:30:19 +01:00
jpmschweitzerandClaude Opus 4.6 90654db3f9 docs(masterplan): expand scope with metal supply, artifacts, lifestyles, and activities
Add new systems across milestones: metal supply and scarcity (M2),
Royal Court artifact system with 9 core types (M3), 5 custom
Mistborn lifestyles replacing vanilla (~75 perks/events each), and
rethemed activities including multi-phase Noble Ball (M5). Also adds
stretch-goal artifacts (~20 types) and 8 Mistborn-specific activities
to M7.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 16:30:03 +01:00
jpmschweitzerandClaude Opus 4.6 a2edd9025e docs(milestones): add detailed milestone implementation documents
Break the MASTERPLAN into 8 milestone documents (M1-M8) with a
standard template. Each milestone includes prerequisites, current
state assessment, numbered implementation tasks with file references,
testing checkpoints, acceptance criteria, and risk analysis.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 16:29:56 +01:00
jpmschweitzerandClaude Opus 4.6 300761c15f chore(meta): update changelog
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 15:33:27 +01:00
jpmschweitzerandClaude Opus 4.6 7c4bdec83a chore(meta): add orient skill and project README
Added /orient skill for lightweight context bootstrapping — reads
README.md, skill frontmatters, and mod structure without flooding
context. Added a lean README.md as the entry point for orientation.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 15:33:09 +01:00
jpmschweitzerandClaude Opus 4.6 e918879f78 chore(meta): add commit skill instructions and update version in CLAUDE.md
Added a Committing section directing Claude to always use the /commit
skill. Updated the CK3 version reference from 1.12 to 1.18.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 15:33:02 +01:00
jpmschweitzerandClaude Opus 4.6 145824dadf chore(meta): bump supported version to 1.18 and add Roads to Power dependency
The mod was targeting CK3 1.12 which is several versions behind the
current 1.18 (Crane). Added Roads to Power DLC as a dependency in
both descriptor files.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 15:32:57 +01:00
jpmschweitzerandClaude Opus 4.6 c4a33288b6 chore(meta): update changelog
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 15:13:19 +01:00
jpmschweitzerandClaude Opus 4.6 3940e62c57 refactor(meta): rename mod directory and descriptor to lords-of-ash
Renamed mistborn_final_empire/ to lords_of_ash/ and
mistborn_final_empire.mod to lords-of-ash.mod using git mv.
Updated all references in CLAUDE.md, ck3-game-install skill,
and commit skill.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 15:12:46 +01:00
jpmschweitzerandClaude Opus 4.6 c93fb8c983 chore(meta): update changelog
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-02-07 15:00:50 +01:00