jpmschweitzerandClaude d36d458b74 fix(client): Global drew at half size — request and fit disagreed about the legend ...

Jeroen: 'that does not fit the viewport'. Correct — Global rendered a real map
into roughly a quarter of the available area.

_letterbox_scale_for() reserves LEGEND_COLUMN_PX before computing the Global
fit, but _request_extent() sized the request against the FULL Control width.
Because that fit is an INTEGER pixels-per-gridunit ratio, the disagreement
does not degrade gracefully: at a 1920-wide window we asked for 960 gridunits
but could only fit floor(1628/960) = 1 px each, so the canvas drew at HALF the
intended scale with room to spare on every side.

The request is now sized to the drawable area, so both sides agree: 814
gridunits at 2 px = 1628 px, plus the 292 px legend column = exactly 1920.
Verified through the capture harness — canvas_scale went 0.5 -> 1.0.

Only Global reserves the column, so only Global adjusts; the fixed rungs are
untouched.

Also corrects the regression test I wrote yesterday, which computed its
expectation from the full viewport and so encoded the bug.

Client suite 1830 / 1804 passed / 0 failed / 26 skipped.

Co-Authored-By: Claude <noreply@anthropic.com>

2026-07-27 21:13:04 +02:00

..

fixtures

feat(ui): AtlasAgentInterface — observe/act named-intent control channel (D-226, T-971)

2026-07-25 18:51:45 +02:00

golden/visual

fix(ui): PR #217 review fixes — derived legend offset, 960x540 goldens, non-overlap tests

2026-07-26 15:13:11 +02:00

unit

feat(client): purchased UAL tiers wired — lib/Clip addressing, stance enter/exits, turn-in-place (T-1088)

2026-07-06 21:53:35 +02:00

util

feat(config): parse sweep — verify every project script parses, not just the startup path

2026-07-27 00:32:42 +02:00

atlas_agent_driver.gd

fix(ui): agent driver honors SR_PORT — the eyeball's own finding (T-971)

2026-07-25 19:30:29 +02:00

gen_client_fixtures.gd

fix(client): resolve all gdlint warnings — zero warnings policy

2026-04-05 09:59:56 +02:00

gen_client_fixtures.gd.uid

chore(client): add missing .uid and .import files from Godot 4.6

2026-02-18 11:51:41 +01:00

run_gdunit4.gd

feat(client): gdUnit4 CI runner script (#205)

2026-02-25 11:45:34 +01:00

run_gdunit4.gd.uid

docs(docs): add Sprint 22 briefings and track Godot auto-generated files

2026-02-28 12:20:02 +01:00

test_ai_dialogue_sprint26.gd

fix(client): clear the test debt — 2 production bugs, suite fully green (T-973 et al.)

2026-06-12 16:22:01 +02:00

test_anti_tedium.gd

fix(client): sprint 37 test-pass fixes — parse error + test hygiene

2026-04-22 09:06:51 +02:00

test_anti_tedium.gd.uid

chore(client): add missing .uid and .import files from Godot 4.6

2026-02-18 11:51:41 +01:00

test_atlas_agent_driver.gd

fix(ui): PR #209 review round — current-screen guards, pending-aware settle, one body guard (T-971)

2026-07-25 19:14:02 +02:00

test_atlas_agent_interface.gd

fix(ui): PR #209 review round — current-screen guards, pending-aware settle, one body guard (T-971)

2026-07-25 19:14:02 +02:00

test_atlas_data_delivery.gd

feat(simulation): feature-name pipeline wired + legacy window_granularity u32 retired (T-1169, T-1159)

2026-07-25 16:10:27 +02:00

test_atlas_standalone.gd

fix(client): cold-start round 2 — DERIVING TERRAIN state, legend re-fit, release server for make atlas

2026-07-22 19:51:12 +02:00

test_atlas_window_cache.gd

feat(simulation): feature-name pipeline wired + legacy window_granularity u32 retired (T-1169, T-1159)

2026-07-25 16:10:27 +02:00

test_atlas_window_colors.gd

fix(ui): PR #203 review round — total retirement + bin decode + wired reset

2026-07-25 09:32:52 +02:00

test_audio_bus_routing.gd

fix(client): resolve all gdlint warnings — zero warnings policy

2026-04-05 09:59:56 +02:00

test_audio_bus_routing.gd.uid

chore(client): track Godot-generated uid and import files

2026-02-21 13:43:43 +01:00

test_audio_sprint13.gd

fix(client): clear the test debt — 2 production bugs, suite fully green (T-973 et al.)

2026-06-12 16:22:01 +02:00

test_audio_sprint13.gd.uid

chore(client): track Godot-generated uid and import files

2026-02-21 13:43:43 +01:00

test_browser_adapter.gd

feat(ui): T-1133 data browser — implant/browser app, six index+detail screens (D-254 SS4)

2026-07-17 10:24:39 +02:00

test_bug_report_ring_buffer.gd

fix(protocol): drop PROTOCOL_VERSION lockstep — D-192 (#875)

2026-04-21 17:29:49 +02:00

test_bug_report_ring_buffer.gd.uid

chore(client): track Godot-generated uid and import files

2026-02-21 13:43:43 +01:00

test_camera_anchor.gd

fix(client): resolve all gdlint warnings — zero warnings policy

2026-04-05 09:59:56 +02:00

test_camera_anchor.gd.uid

chore(client): add missing .uid and .import files from Godot 4.6

2026-02-18 11:51:41 +01:00

test_character_creation_sprint28.gd

fix(tests): PR #134 review round 3 — seed start-state + PID log path

2026-04-21 14:30:38 +02:00

test_character_visual_descriptor_sprint28.gd

feat(client): CharacterVisualDescriptor and compositor (#703, #704)

2026-03-20 07:48:47 +01:00

test_character_visual_sprint28.gd

test(client): skip the 3D character compositor suite while 3D is not in play

2026-07-27 00:57:15 +02:00

test_checklist.gd

fix(client): resolve all gdlint warnings — zero warnings policy

2026-04-05 09:59:56 +02:00

test_checklist.gd.uid

chore(client): track Godot-generated uid and import files

2026-02-21 13:43:43 +01:00

test_client_p1.gd

feat(client): sprint 38 — free camera viewer, archetype strip, test fixes

2026-05-02 10:19:11 +02:00

test_client_p1.gd.uid

chore(client): add missing .uid and .import files from Godot 4.6

2026-02-18 11:51:41 +01:00

test_client_p2.gd

fix(client): clear the test debt — 2 production bugs, suite fully green (T-973 et al.)

2026-06-12 16:22:01 +02:00

test_client_p2.gd.uid

chore(client): add missing .uid and .import files from Godot 4.6

2026-02-18 11:51:41 +01:00

test_client_p3.gd

refactor(ui): migrate 6 meta screens to MetaScreen pattern (Workstream 2)

2026-04-19 21:58:24 +02:00

test_client_p3.gd.uid

chore(client): add missing .uid and .import files from Godot 4.6

2026-02-18 11:51:41 +01:00

test_color_shift.gd

feat(client): integrate D-019 angle sprites into entity renderer (#540)

2026-02-23 21:01:30 +01:00

test_color_shift.gd.uid

chore(client): track Godot-generated uid and import files

2026-02-21 13:43:43 +01:00

test_cursor_states.gd

feat(client): resolve OQ-07 — insert-off suppresses verb labels (#522)

2026-02-19 12:05:36 +01:00

test_cursor_states.gd.uid

chore(client): add missing .uid and .import files from Godot 4.6

2026-02-18 11:51:41 +01:00

test_dialogue_speaker_colors.gd

fix(ui): clear color registry on conversation end, add speaker color tests (#573)

2026-03-04 09:50:02 +01:00

test_dialogue_sprint18.gd

fix(client): clear the test debt — 2 production bugs, suite fully green (T-973 et al.)

2026-06-12 16:22:01 +02:00

test_dialogue_sprint18.gd.uid

docs(docs): add Sprint 22 briefings and track Godot auto-generated files

2026-02-28 12:20:02 +01:00

test_dialogue_sprint20.gd

fix(client): clear the test debt — 2 production bugs, suite fully green (T-973 et al.)

2026-06-12 16:22:01 +02:00

test_dialogue_sprint20.gd.uid

docs(docs): add Sprint 22 briefings and track Godot auto-generated files

2026-02-28 12:20:02 +01:00

test_e2e_connection.gd

fix(client): clear the test debt — 2 production bugs, suite fully green (T-973 et al.)

2026-06-12 16:22:01 +02:00

test_e2e_connection.gd.uid

feat(client): add interaction prompt system (#405)

2026-02-12 23:43:37 +01:00

test_etalk_overlay_sprint17.gd

fix(client): clear the test debt — 2 production bugs, suite fully green (T-973 et al.)

2026-06-12 16:22:01 +02:00

test_etalk_overlay_sprint17.gd.uid

docs(docs): add Sprint 22 briefings and track Godot auto-generated files

2026-02-28 12:20:02 +01:00

test_examine_display_sprint18.gd

fix(client): address PR #141 review — parse-order, tween guard, test fixes

2026-05-02 22:50:17 +02:00

test_examine_display_sprint18.gd.uid

docs(docs): add Sprint 22 briefings and track Godot auto-generated files

2026-02-28 12:20:02 +01:00

test_fog_shader.gd

fix(client): fog perf test measures min-of-7, not median-of-5 (T-1210 done)

2026-07-26 15:17:51 +02:00

test_fog_shader.gd.uid

chore(client): add missing .uid and .import files from Godot 4.6

2026-02-18 11:51:41 +01:00

test_fog_sprint22.gd

fix(client): address PR #141 review — parse-order, tween guard, test fixes

2026-05-02 22:50:17 +02:00

test_free_camera.gd

fix(client): free camera review fixes — action toggle, zoom reset, discrete guard, tests (#898)

2026-05-02 18:03:06 +02:00

test_game_state_sprint20.gd

fix(client): address PR #141 review — parse-order, tween guard, test fixes

2026-05-02 22:50:17 +02:00

test_game_state_sprint20.gd.uid

docs(docs): add Sprint 22 briefings and track Godot auto-generated files

2026-02-28 12:20:02 +01:00

test_game_state.gd

refactor(client): decompose main.gd and game_state.gd god objects

2026-04-05 09:59:34 +02:00

test_game_state.gd.uid

docs(docs): add Sprint 22 briefings and track Godot auto-generated files

2026-02-28 12:20:02 +01:00

test_garment_engine_t1089.gd

feat(assets): wardrobe wave 1 — per-body shells, 8 garments, try-on UI (T-1089)

2026-07-07 00:35:20 +02:00

test_hub_teleport.gd

fix(protocol): drop PROTOCOL_VERSION lockstep — D-192 (#875)

2026-04-21 17:29:49 +02:00

test_hub_teleport.gd.uid

chore(client): track Godot-generated uid and import files

2026-02-21 13:43:43 +01:00

test_hud_groups_auto_pause.gd

feat(simulation): auto-pause sim on implant-fullscreen — inspection substrate (T-970)

2026-07-14 15:44:56 +02:00

test_implant_app_lifecycle.gd

test(ui): PR #131 review — implant primitive tests (item 5)

2026-04-19 15:36:04 +02:00

test_implant_nav_stack.gd

test(ui): PR #131 review — implant primitive tests (item 5)

2026-04-19 15:36:04 +02:00

test_implant_registry.gd

test(ui): PR #131 review — implant primitive tests (item 5)

2026-04-19 15:36:04 +02:00

test_input_gate_live.gd

fix(client): T-1146 review round — gate the T-1088 seams, kill the settle fallback tautology, neutralize AutoPause leak

2026-07-21 20:00:18 +02:00

test_input_mapper_facing.gd

fix(client): address PR #36 re-review — 7 items from Hoshe + Tyre

2026-02-18 18:28:37 +01:00

test_input_mapper_facing.gd.uid

chore(client): track Godot-generated uid and import files

2026-02-21 13:43:43 +01:00

test_input_mapper_occlusion_gate.gd

fix(client): T-1146 review round — gate the T-1088 seams, kill the settle fallback tautology, neutralize AutoPause leak

2026-07-21 20:00:18 +02:00

test_input_roundtrip.gd

test(client): pace input-roundtrip moves past the D-053 stance cooldown (T-1068 fix ported)

2026-07-16 21:30:52 +02:00

test_input_roundtrip.gd.uid

chore(client): track Godot .uid resource identifier files

2026-02-14 09:49:41 +01:00

test_insert_off_behavior.gd

fix(client): resolve all gdlint warnings — zero warnings policy

2026-04-05 09:59:56 +02:00

test_insert_off_behavior.gd.uid

chore(client): track Godot-generated uid and import files

2026-02-21 13:43:43 +01:00

test_interaction_list.gd

fix(protocol): drop PROTOCOL_VERSION lockstep — D-192 (#875)

2026-04-21 17:29:49 +02:00

test_interaction_list.gd.uid

chore(client): add missing .uid and .import files from Godot 4.6

2026-02-18 11:51:41 +01:00

test_interaction_prompt.gd

fix(protocol): drop PROTOCOL_VERSION lockstep — D-192 (#875)

2026-04-21 17:29:49 +02:00

test_interaction_prompt.gd.uid

feat(client): add interaction prompt system (#405)

2026-02-12 23:43:37 +01:00

test_ipc_fixtures.gd

fix(protocol): drop PROTOCOL_VERSION lockstep — D-192 (#875)

2026-04-21 17:29:49 +02:00

test_ipc_fixtures.gd.uid

docs(docs): add Sprint 22 briefings and track Godot auto-generated files

2026-02-28 12:20:02 +01:00

test_local_bridge.gd

fix(protocol): drop PROTOCOL_VERSION lockstep — D-192 (#875)

2026-04-21 17:29:49 +02:00

test_local_bridge.gd.uid

feat(client): add LocalBridge framing tests and diagonal fixtures

2026-02-11 20:59:46 +01:00

test_main_scene.gd

refactor(client): decompose main.gd and game_state.gd god objects

2026-04-05 09:59:34 +02:00

test_main_scene.gd.uid

feat(client): initialize Godot 4 project boilerplate (epic #277)

2026-02-11 16:52:27 +01:00

test_merge_path_flows_sprint37.gd

fix(client): PR #135 review — T1/T3/H4-H7 blocking + nits

2026-04-22 10:06:39 +02:00

test_monologue_display.gd

fix(client): clear the test debt — 2 production bugs, suite fully green (T-973 et al.)

2026-06-12 16:22:01 +02:00

test_monologue_display.gd.uid

chore(client): track Godot-generated uid and import files

2026-02-21 13:43:43 +01:00

test_msgpack_boundaries.gd

fix(client): fix MessagePack int_64 encoder dead code branch (#516)

2026-02-18 02:14:29 +01:00

test_msgpack_boundaries.gd.uid

chore(client): add missing .uid and .import files from Godot 4.6

2026-02-18 11:51:41 +01:00

test_p0_regressions.gd

fix(client): PR #135 review — T1/T3/H4-H7 blocking + nits

2026-04-22 10:06:39 +02:00

test_p0_regressions.gd.uid

chore(client): add missing .uid and .import files from Godot 4.6

2026-02-18 11:51:41 +01:00

test_protocol_bridge.gd

fix(client): PR #135 review — T1/T3/H4-H7 blocking + nits

2026-04-22 10:06:39 +02:00

test_protocol_bridge.gd.uid

chore(client): add missing .uid and .import files from Godot 4.6

2026-02-18 11:51:41 +01:00

test_protocol_v7.gd

fix(protocol): drop PROTOCOL_VERSION lockstep — D-192 (#875)

2026-04-21 17:29:49 +02:00

test_protocol_v7.gd.uid

chore(client): add missing .uid and .import files from Godot 4.6

2026-02-18 11:51:41 +01:00

test_protocol.gd

feat(simulation): feature-name pipeline wired + legacy window_granularity u32 retired (T-1169, T-1159)

2026-07-25 16:10:27 +02:00

test_protocol.gd.uid

feat(client): add Protocol codec with cross-language tests (#77)

2026-02-11 19:16:56 +01:00

test_rendering.gd

feat(client): sprint 38 — free camera viewer, archetype strip, test fixes

2026-05-02 10:19:11 +02:00

test_rendering.gd.uid

feat(client): add interaction prompt system (#405)

2026-02-12 23:43:37 +01:00

test_save_load_flow_sprint21.gd

fix(client): address PR #73 review — race conditions and defensive guards (#257)

2026-02-27 18:06:16 +01:00

test_save_load_flow_sprint21.gd.uid

docs(docs): add Sprint 22 briefings and track Godot auto-generated files

2026-02-28 12:20:02 +01:00

test_signal_sprint24.gd

feat(client): sprint 38 — free camera viewer, archetype strip, test fixes

2026-05-02 10:19:11 +02:00

test_signal_sprint24.gd.uid

test(client): Sprint 24 signal tests

2026-03-05 11:44:12 +01:00

test_smooth_camera_sprint15.gd

fix(client): resolve all gdlint warnings — zero warnings policy

2026-04-05 09:59:56 +02:00

test_smooth_camera_sprint15.gd.uid

test(client): sprint 15 validation tests — camera, UI framework, entities

2026-02-21 14:10:06 +01:00

test_snapshot_event_router.gd

refactor(client): extract SnapshotEventRouter from main.gd (#559)

2026-02-25 21:59:56 +01:00

test_snapshot_event_router.gd.uid

docs(docs): add Sprint 22 briefings and track Godot auto-generated files

2026-02-28 12:20:02 +01:00

test_snapshot_parsing.gd

fix(client): align tests with kind-based player detection

2026-02-13 02:07:43 +01:00

test_snapshot_parsing.gd.uid

feat(client): add Protocol codec with cross-language tests (#77)

2026-02-11 19:16:56 +01:00

test_snapshot_zone_id.gd

refactor(client): optimize zone_id extraction from O(N) to O(1) lookup (#543)

2026-02-23 21:01:22 +01:00

test_snapshot_zone_id.gd.uid

docs(docs): add Sprint 22 briefings and track Godot auto-generated files

2026-02-28 12:20:02 +01:00

test_sound_indicators.gd

fix(client): correct 5 bugs found in pre-PR review

2026-02-19 14:59:50 +01:00

test_sound_indicators.gd.uid

chore(client): track Godot-generated uid and import files

2026-02-21 13:43:43 +01:00

test_sprint2_proof.gd

test(client): corner-reveal proof updated to D-252 semantics + deterministic cone wait

2026-07-06 21:15:32 +02:00

test_sprint2_proof.gd.uid

feat(client): add interaction prompt system (#405)

2026-02-12 23:43:37 +01:00

test_step_canvas_annotation_layer.gd

fix(config): run-godot reported a suite that never ran as a pass

2026-07-27 00:12:26 +02:00

test_step_canvas_cache.gd

test(client): the Atlas Global goldens have been measuring nothing

2026-07-27 20:52:54 +02:00

test_step_canvas_colorize.gd

feat(ui): step-canvas map component — RTT terrain + stepped zoom (D-255, T-1182)

2026-07-25 08:53:48 +02:00

test_step_canvas_disk_cache.gd

test(client): the Atlas Global goldens have been measuring nothing

2026-07-27 20:52:54 +02:00

test_step_canvas_legend.gd

fix(ui): PR #217 review fixes — derived legend offset, 960x540 goldens, non-overlap tests

2026-07-26 15:13:11 +02:00

test_step_canvas_protocol.gd

fix(ui): PR #203 review round — total retirement + bin decode + wired reset

2026-07-25 09:32:52 +02:00

test_step_canvas_request.gd

feat(ui): client disk cache — FileAccess tiers beneath the LRU (D-255, T-1183)

2026-07-25 11:08:48 +02:00

test_step_canvas_transport.gd

feat(client): size the Global rung to the viewport, not the region grid

2026-07-26 22:45:40 +02:00

test_step_canvas_viewer.gd

fix(client): Global drew at half size — request and fit disagreed about the legend

2026-07-27 21:13:04 +02:00

test_system_index.gd

fix(simulation): PR #176 review round — all 12 findings + 2 recommendations addressed

2026-07-14 17:31:15 +02:00

test_time_display_sprint17.gd

feat(client): sprint 38 — free camera viewer, archetype strip, test fixes

2026-05-02 10:19:11 +02:00

test_time_display_sprint17.gd.uid

docs(docs): add Sprint 22 briefings and track Godot auto-generated files

2026-02-28 12:20:02 +01:00

test_ui_framework_sprint15.gd

refactor(ui): migrate 6 meta screens to MetaScreen pattern (Workstream 2)

2026-04-19 21:58:24 +02:00

test_ui_framework_sprint15.gd.uid

test(client): sprint 15 validation tests — camera, UI framework, entities

2026-02-21 14:10:06 +01:00

test_ui_strings.gd

fix(ui): adapt client to new ui-strings.yaml structure

2026-02-13 18:07:15 +01:00

test_ui_strings.gd.uid

chore(client): track Godot .uid resource identifier files

2026-02-14 09:49:41 +01:00

test_yaml_parser.gd

fix(client): resolve all gdlint warnings — zero warnings policy

2026-04-05 09:59:56 +02:00

test_yaml_parser.gd.uid

docs(docs): add Sprint 22 briefings and track Godot auto-generated files

2026-02-28 12:20:02 +01:00

visual_capture.gd

test(client): the Atlas Global goldens have been measuring nothing

2026-07-27 20:52:54 +02:00

visual_capture.gd.uid

feat(engine): live server visual tests and gauntlet snapshot replay

2026-03-05 08:41:09 +01:00

visual_scenarios.gd

test(client): the Atlas Global goldens have been measuring nothing

2026-07-27 20:52:54 +02:00

visual_scenarios.gd.uid

feat(engine): live server visual tests and gauntlet snapshot replay

2026-03-05 08:41:09 +01:00