jpmschweitzer/settled-reach
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(simulation): add Rust/bevy_ecs server boilerplate #2

Closed
jpmschweitzer wants to merge 0 commits from server into main
pull from: server
merge into: :main
Conversation 2 Commits - Files Changed -
jpmschweitzer commented 2026-02-11 17:23:40 +01:00
Owner
Copy Link
Copy Source

Summary

  • Rust/bevy_ecs simulation server foundation (epic 276, stories 278-286)
  • Core ECS types: SimulationTime (D-031), SimRng, InputQueue, SimulationTier (D-026), CauseChain (D-030), NPC 10-axis model (D-024)
  • IPC boundary types: ObserverSnapshot + PlayerInput with MessagePack serialization (D-020)
  • SimBridge trait, plugin scaffolding (SimulationPlugin, BridgePlugin, PerceptionPlugin, StorytellerPlugin)
  • 15 tests green (11 inline unit + 4 integration), make ci-server passing

Test plan

  • cargo test — 15 tests passing (11 inline + 4 integration)
  • make ci-server — clippy, fmt, build, test all green

Generated with Claude Code

## Summary - Rust/bevy_ecs simulation server foundation (epic 276, stories 278-286) - Core ECS types: SimulationTime (D-031), SimRng, InputQueue, SimulationTier (D-026), CauseChain (D-030), NPC 10-axis model (D-024) - IPC boundary types: ObserverSnapshot + PlayerInput with MessagePack serialization (D-020) - SimBridge trait, plugin scaffolding (SimulationPlugin, BridgePlugin, PerceptionPlugin, StorytellerPlugin) - 15 tests green (11 inline unit + 4 integration), make ci-server passing ## Test plan - [x] cargo test — 15 tests passing (11 inline + 4 integration) - [x] make ci-server — clippy, fmt, build, test all green Generated with [Claude Code](https://claude.com/claude-code)
jpmschweitzer added 4 commits 2026-02-11 17:23:41 +01:00
chore(config): add Rust build artifacts to gitignore 84925b334a 
server/target/ excluded from version control.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
feat(server): initialize Rust/bevy_ecs simulation server f67caf1986 
Server boilerplate epic (276) complete. Establishes the Rust simulation
server foundation per D-020 (subprocess/IPC architecture).

Structure:
- bevy_ecs 0.18 + bevy_app 0.18, MessagePack serialization (rmp-serde)
- SimulationPlugin with deterministic resources: SimulationTime (D-031),
  SimRng (D-030), InputQueue (D-010)
- Core IPC types: ObserverSnapshot, PlayerInput, SimBridge trait (D-020)
- CauseChain production component for provenance tracking (D-030)
- SimulationTier types with LRU eviction support (D-026)
- NPC 10-axis model components (D-024)
- 15 tests: inline unit tests + integration smoke/serialization tests
- make ci-server passes (clippy, fmt, build, test)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
chore(db): mark server boilerplate epic and stories as done 651995590d 
Tickets 276 (epic) and 278-286 (stories/tasks) updated to done
status after make ci-server passed green.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
chore(meta): update changelog 938df000ac 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jpmschweitzer added 1 commit 2026-02-11 17:37:01 +01:00
docs(meta): add tea PR workflow to CLAUDE.md 9de1eb4aa3 
Document Gitea tea CLI usage for pull requests with all required
flags for non-interactive execution. Adds Gitea to local services.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jpmschweitzer commented 2026-02-11 17:42:16 +01:00
Author
Owner
Copy Link
Copy Source

Dual-Agent Review: origin/server -> main

Hoshe (Code Quality): REQUEST_CHANGES

Summary: Architecturally sound, correctly implements D-020 patterns. Found critical issues that need fixing.

# File Severity Issue
1 Cargo.toml:4 critical edition = "2024" is invalid — Rust editions are 2015, 2018, 2021. Will fail to build.
2 Cargo.toml critical Missing cargo-nextest dev-dependency — D-030 requires it as test runner
3 src/simulation/time.rs:36-42 warning Day phase boundary at minute 360 — clarify if Morning is 0-359 or 0-360
4 src/simulation/input.rs:17 warning InputQueue::push() doesn't enforce tick ordering — risks non-determinism if inputs arrive out-of-order
5 src/npc/mod.rs warning No validation for NPC axis data constraints from D-024
6 tests/serialization.rs warning D-030 Layer 1 incomplete — only tests MoveNorth/Npc variants, not all enum variants
7 Multiple files suggestion Missing edge case tests: day wraparound at midnight, out-of-order input, day() calculation
8 src/main.rs:28 suggestion Single app.update() call needs clarifying comment (intentional boilerplate vs bug)

Tyre (Architecture): APPROVE

Summary: Clean, well-structured boilerplate mapping faithfully to architectural decisions. All 15 tests pass, injectable resources correctly satisfy D-030.

# File Severity Issue
1 src/bridge/types.rs warning ObserverSnapshot is skeleton — add TODO noting planned fields (fog, sound, monologue, HUD)
2 src/bridge/types.rs suggestion entity_id: u64 vs bevy Entity — document this is wire-format ID, not ECS entity
3 src/npc/mod.rs warning Relationship.target_name: String won't scale to 10K+ NPCs — needs entity ID
4 src/npc/mod.rs suggestion Missing modifications: Vec<Modification> future flag stub per briefing
5 src/simulation/time.rs suggestion 6hr equal phase split is a design choice — add comment noting it's adjustable
6 src/simulation/time.rs suggestion DayPhase missing Serialize/Deserialize (inconsistent with other enums)
7 src/main.rs suggestion Add comment: "Single tick for smoke verification; real loop in phase 2"

Required before merge:

  1. Fix Cargo.toml edition to "2021"
  2. Add cargo-nextest dev-dependency or document installation requirement
  3. Add serialization roundtrip tests for all PlayerAction and EntityKind variants
  4. Document or enforce InputQueue tick ordering assumption
## Dual-Agent Review: origin/server -> main ### Hoshe (Code Quality): REQUEST_CHANGES **Summary:** Architecturally sound, correctly implements D-020 patterns. Found critical issues that need fixing. | # | File | Severity | Issue | |---|------|----------|-------| | 1 | Cargo.toml:4 | critical | `edition = "2024"` is invalid — Rust editions are 2015, 2018, 2021. Will fail to build. | | 2 | Cargo.toml | critical | Missing `cargo-nextest` dev-dependency — D-030 requires it as test runner | | 3 | src/simulation/time.rs:36-42 | warning | Day phase boundary at minute 360 — clarify if Morning is 0-359 or 0-360 | | 4 | src/simulation/input.rs:17 | warning | `InputQueue::push()` doesn't enforce tick ordering — risks non-determinism if inputs arrive out-of-order | | 5 | src/npc/mod.rs | warning | No validation for NPC axis data constraints from D-024 | | 6 | tests/serialization.rs | warning | D-030 Layer 1 incomplete — only tests MoveNorth/Npc variants, not all enum variants | | 7 | Multiple files | suggestion | Missing edge case tests: day wraparound at midnight, out-of-order input, `day()` calculation | | 8 | src/main.rs:28 | suggestion | Single `app.update()` call needs clarifying comment (intentional boilerplate vs bug) | ### Tyre (Architecture): APPROVE **Summary:** Clean, well-structured boilerplate mapping faithfully to architectural decisions. All 15 tests pass, injectable resources correctly satisfy D-030. | # | File | Severity | Issue | |---|------|----------|-------| | 1 | src/bridge/types.rs | warning | `ObserverSnapshot` is skeleton — add TODO noting planned fields (fog, sound, monologue, HUD) | | 2 | src/bridge/types.rs | suggestion | `entity_id: u64` vs bevy `Entity` — document this is wire-format ID, not ECS entity | | 3 | src/npc/mod.rs | warning | `Relationship.target_name: String` won't scale to 10K+ NPCs — needs entity ID | | 4 | src/npc/mod.rs | suggestion | Missing `modifications: Vec<Modification>` future flag stub per briefing | | 5 | src/simulation/time.rs | suggestion | 6hr equal phase split is a design choice — add comment noting it's adjustable | | 6 | src/simulation/time.rs | suggestion | `DayPhase` missing Serialize/Deserialize (inconsistent with other enums) | | 7 | src/main.rs | suggestion | Add comment: "Single tick for smoke verification; real loop in phase 2" | ### Required before merge: 1. Fix Cargo.toml edition to "2021" 2. Add cargo-nextest dev-dependency or document installation requirement 3. Add serialization roundtrip tests for all PlayerAction and EntityKind variants 4. Document or enforce InputQueue tick ordering assumption
jpmschweitzer added 3 commits 2026-02-11 17:54:07 +01:00
fix(simulation): address PR #2 review findings 6bda4a7620 
- Fix Cargo.toml edition 2024 → 2021 (Hoshe #1)
- Switch test runner to cargo-nextest in Makefile (Hoshe #2, D-030)
- Add debug_assert tick ordering enforcement in InputQueue::push (Hoshe #4)
- Add DayPhase Serialize/Deserialize derives (Tyre #6)
- Add day phase boundary comments clarifying half-open ranges (Hoshe #3)
- Add phase duration adjustability comment (Tyre #5)
- Document ObserverSnapshot planned fields as TODO (Tyre #1)
- Document entity_id as wire-format ID, not ECS Entity (Tyre #2)
- Change Relationship.target_name to target_id: u64 (Tyre #3)
- Clarify single app.update() is intentional boilerplate (Hoshe #8, Tyre #7)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
test(simulation): expand test coverage per PR #2 review 112910df9b 
- Add roundtrip tests for all PlayerAction variants (Hoshe #6)
- Add roundtrip tests for all EntityKind variants (Hoshe #6)
- Add day wraparound at midnight edge case test (Hoshe #7)
- Add day() calculation test (Hoshe #7)
- Add out-of-order input rejection test (Hoshe #7)
- Total: 15 → 20 tests

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
chore(meta): update changelog 4afda9a6b8 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jpmschweitzer commented 2026-02-11 18:20:12 +01:00
Author
Owner
Copy Link
Copy Source

Dual-Agent Review (Round 2): origin/server -> main

Hoshe (Code Quality): APPROVE

All previous review issues addressed. 20 tests pass. Exhaustive MessagePack round-trip tests cover all enum variants. Code is clean with no blocking issues.

# File Severity Issue
1 simulation/input.rs:34 suggestion Single guarded unwrap() is safe by construction -- could extract to variable for clarity

Tyre (Architecture): APPROVE

Strict adherence to all referenced decisions (D-010, D-020, D-024, D-026, D-030, D-031). All 8 previous findings addressed. Architecture respects non-negotiable baselines. SimBridge trait enables multiplayer as config change. CauseChain as production component is elegant. Foundation is sound for vertical slice work.

Verdict: APPROVED

Both reviewers approve. Ready to merge.

## Dual-Agent Review (Round 2): origin/server -> main ### Hoshe (Code Quality): APPROVE All previous review issues addressed. 20 tests pass. Exhaustive MessagePack round-trip tests cover all enum variants. Code is clean with no blocking issues. | # | File | Severity | Issue | |---|------|----------|-------| | 1 | simulation/input.rs:34 | suggestion | Single guarded unwrap() is safe by construction -- could extract to variable for clarity | ### Tyre (Architecture): APPROVE Strict adherence to all referenced decisions (D-010, D-020, D-024, D-026, D-030, D-031). All 8 previous findings addressed. Architecture respects non-negotiable baselines. SimBridge trait enables multiplayer as config change. CauseChain as production component is elegant. Foundation is sound for vertical slice work. ### Verdict: APPROVED Both reviewers approve. Ready to merge.
jpmschweitzer closed this pull request 2026-02-11 18:21:13 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jpmschweitzer (Jeroen Schweitzer)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: jpmschweitzer/settled-reach#2