jpmschweitzer/settled-reach
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(copy): Sprint 33 economics content — zones, corps, commodities #121

Closed
jpmschweitzer wants to merge 0 commits from sprint-33/copy into main
pull from: sprint-33/copy
merge into: :main
Conversation 2 Commits - Files Changed -
jpmschweitzer commented 2026-04-07 10:29:48 +02:00
Owner
Copy Link
Copy Source

Summary

Sprint 33 copy team deliverables — all 4 tickets complete:

  • #820 — wiki/economics/currency_zones.toml: 32 MARK_PRIMARY + 14 MIXED Compact zone assignments (D-172)
  • #803 — wiki/economics/shadow_economy.toml: per-system intensity ranges, 6 modifiers, 10 overrides (D-174)
  • #799 — wiki/economics/corporations/tier2/: 141 Tier-2 corporations across 6 corridors, all 36 commodity types covered
  • #812 — 36 commodity wiki pages fleshed out with flavor text and production chain descriptions (D-185)
  • Bugfix — Corrected Freiholt system ID (GJ 624 → GJ 453) in wiki/factions/compact-of-westphalia.md

Server team unblocks

  • #805 (corp pipeline): can now read currency zone assignments
  • #808 (currency zones): can now read shadow economy intensity data
  • #809 (corporate agents): can now read Tier-2 behavioral archetypes

Test plan

  • Verify currency_zones.toml parses as valid TOML
  • Verify shadow_economy.toml parses as valid TOML
  • Verify all 6 Tier-2 corridor files parse as valid TOML
  • Spot-check commodity pages for D-185 compliance (no brand stub pages)
  • Verify Freiholt cross-references now point to GJ-453
  • Confirm coverage: every commodity type has ≥1 Tier-2 producer
## Summary Sprint 33 copy team deliverables — all 4 tickets complete: - **#820** — `wiki/economics/currency_zones.toml`: 32 MARK_PRIMARY + 14 MIXED Compact zone assignments (D-172) - **#803** — `wiki/economics/shadow_economy.toml`: per-system intensity ranges, 6 modifiers, 10 overrides (D-174) - **#799** — `wiki/economics/corporations/tier2/`: 141 Tier-2 corporations across 6 corridors, all 36 commodity types covered - **#812** — 36 commodity wiki pages fleshed out with flavor text and production chain descriptions (D-185) - **Bugfix** — Corrected Freiholt system ID (GJ 624 → GJ 453) in `wiki/factions/compact-of-westphalia.md` ## Server team unblocks - #805 (corp pipeline): can now read currency zone assignments - #808 (currency zones): can now read shadow economy intensity data - #809 (corporate agents): can now read Tier-2 behavioral archetypes ## Test plan - [ ] Verify `currency_zones.toml` parses as valid TOML - [ ] Verify `shadow_economy.toml` parses as valid TOML - [ ] Verify all 6 Tier-2 corridor files parse as valid TOML - [ ] Spot-check commodity pages for D-185 compliance (no brand stub pages) - [ ] Verify Freiholt cross-references now point to GJ-453 - [ ] Confirm coverage: every commodity type has ≥1 Tier-2 producer
jpmschweitzer added 5 commits 2026-04-07 10:29:48 +02:00
feat(copy): author MARK_PRIMARY currency zone assignments (#820) 9c32dc14c4 
32 MARK_PRIMARY systems (Compact members, west_reach hops 7-17),
14 MIXED systems (Compact-sympathetic, hops 5-6), with rationale
comments per D-172 political affiliation rules. Feeds server #805.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
feat(copy): define shadow economy intensity ranges (#803) ca04658da2 
Per-system-type intensity bands (core 0.0-0.2 through frontier 0.6-0.9),
6 seeding modifiers, 10 named system overrides. Compact framing as
principled economic resistance per D-174. Feeds server #808.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
feat(copy): generate 141 Tier-2 regional corporations (#799) 3cdf266b5c 
6 corridor files with 141 corporations: core (22), north_reach (21),
south_reach (20), west_reach (29), east_reach (26), deep_frontier (23).
All 36 commodity types covered. Each has name, lore/behavioral archetype,
backstory, branded products. East reach gap from D-175 filled. Feeds #809.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
feat(copy): wiki commodity copy pass — 36 pages with flavor text (#812) 68867894e9 
All 36 commodity stubs fleshed out with lore context, production chain
descriptions, and economic intelligence briefing voice. Key treatments:
fusion_fuel (D-187 8:1 ratio), services (location-bound mechanics),
brands distinguished from commodities per D-185.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
fix(copy): correct Freiholt system ID in Compact faction page 39cd98f84d 
GJ 624 is Halvøy (aquaculture world), not Freiholt. Freiholt is GJ 453.
Fixed both cross-reference occurrences in compact-of-westphalia.md.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jpmschweitzer commented 2026-04-07 10:45:52 +02:00
Author
Owner
Copy Link
Copy Source

Review: sprint-33/copy → main (type: copy, PR #121)

Reviewers: Hoshe (QA), Paula (Narrative — retracted), Miri (World Consistency)

Hoshe (QA): REQUEST_CHANGES

4 issues. TOML schema and file structure are otherwise excellent — 141 corps, 36 commodity pages, currency zones, shadow economy all structurally sound.

# File Issue
1 corporations/tier2/core.toml GJ 280B (sova_independent_freight) doesn't exist in DB. Only GJ 280A exists. Fix headquarters_system.
2 corporations/tier2/west_reach.toml Rødvik Geothermal Works uses gas_giant_skimming archetype — corp is geothermal, not gas giant.
3 corporations/tier2/north_reach.toml holmgren_fermentation key/name uses "Holmgren" but settlement is "Holgersen's Landing" — mixed spelling within one entry.
4 shadow_economy.toml:~78 Unclosed parenthesis in CAPACITY GAP comment.

Paula (Narrative): RETRACTED — reviewer error

Paula claimed all 36 commodity pages lacked flavor text. This is incorrect — pages have 2-4 paragraphs of substantive economic prose below the field table (e.g., medical_goods.md has 3 paragraphs covering Compact contestation and shadow markets). Paula flagged sparse checkout access limitations herself; the finding was based on incomplete file reads.

Miri (World Consistency): REQUEST_CHANGES

4 issues. Currency zone structure (32 MARK + 14 MIXED), D-172 affiliation-based compliance, D-174 Compact framing, and 90+ system IDs all confirmed correct.

# File Issue
1 shadow_economy.toml Altmark override references outer_reach band — system is hop 6 (mid_reach). Intensity 0.48 needs re-justification. Also fix "hop 7" → "hop 6" for Altmark in compact-of-westphalia.md.
2 corporations/tier2/west_reach.toml Ross 154 Water Cooperative at GJ 729 contradicts system profile — Ross 154 imports fuel, has no ice mining. Relocate corp.
3 corporations/tier2/west_reach.toml Same Rødvik archetype issue as Hoshe #2.
4 currency_zones.toml Hansestadt gate count says 5, system page says 6.

Verdict: CHANGES REQUESTED

Deduplicated issues (7):

# Sev Issue
1 High GJ 280B doesn't exist — fix sova_independent_freight headquarters
2 High Ross 154 Water Cooperative contradicts system profile — relocate
3 Med Rødvik Geothermal Works uses wrong archetype (gas_giant_skimming)
4 Med Altmark shadow economy references wrong hop band + compact article says hop 7
5 Low Holmgren/Holgersen naming inconsistency
6 Low Hansestadt gate count 5 → 6
7 Low Unclosed parenthesis in shadow_economy.toml comment
## Review: sprint-33/copy → main (type: copy, PR #121) **Reviewers:** Hoshe (QA), Paula (Narrative — retracted), Miri (World Consistency) --- ### Hoshe (QA): REQUEST_CHANGES 4 issues. TOML schema and file structure are otherwise excellent — 141 corps, 36 commodity pages, currency zones, shadow economy all structurally sound. | # | File | Issue | |---|------|-------| | 1 | `corporations/tier2/core.toml` | `GJ 280B` (sova_independent_freight) doesn't exist in DB. Only `GJ 280A` exists. Fix headquarters_system. | | 2 | `corporations/tier2/west_reach.toml` | Rødvik Geothermal Works uses `gas_giant_skimming` archetype — corp is geothermal, not gas giant. | | 3 | `corporations/tier2/north_reach.toml` | `holmgren_fermentation` key/name uses "Holmgren" but settlement is "Holgersen's Landing" — mixed spelling within one entry. | | 4 | `shadow_economy.toml:~78` | Unclosed parenthesis in CAPACITY GAP comment. | ### Paula (Narrative): RETRACTED — reviewer error Paula claimed all 36 commodity pages lacked flavor text. This is incorrect — pages have 2-4 paragraphs of substantive economic prose below the field table (e.g., medical_goods.md has 3 paragraphs covering Compact contestation and shadow markets). Paula flagged sparse checkout access limitations herself; the finding was based on incomplete file reads. ### Miri (World Consistency): REQUEST_CHANGES 4 issues. Currency zone structure (32 MARK + 14 MIXED), D-172 affiliation-based compliance, D-174 Compact framing, and 90+ system IDs all confirmed correct. | # | File | Issue | |---|------|-------| | 1 | `shadow_economy.toml` | Altmark override references `outer_reach` band — system is hop 6 (`mid_reach`). Intensity 0.48 needs re-justification. Also fix "hop 7" → "hop 6" for Altmark in `compact-of-westphalia.md`. | | 2 | `corporations/tier2/west_reach.toml` | Ross 154 Water Cooperative at GJ 729 contradicts system profile — Ross 154 imports fuel, has no ice mining. Relocate corp. | | 3 | `corporations/tier2/west_reach.toml` | Same Rødvik archetype issue as Hoshe #2. | | 4 | `currency_zones.toml` | Hansestadt gate count says 5, system page says 6. | --- ### Verdict: CHANGES REQUESTED **Deduplicated issues (7):** | # | Sev | Issue | |---|-----|-------| | 1 | High | `GJ 280B` doesn't exist — fix sova_independent_freight headquarters | | 2 | High | Ross 154 Water Cooperative contradicts system profile — relocate | | 3 | Med | Rødvik Geothermal Works uses wrong archetype (`gas_giant_skimming`) | | 4 | Med | Altmark shadow economy references wrong hop band + compact article says hop 7 | | 5 | Low | Holmgren/Holgersen naming inconsistency | | 6 | Low | Hansestadt gate count 5 → 6 | | 7 | Low | Unclosed parenthesis in shadow_economy.toml comment |
jpmschweitzer added 1 commit 2026-04-07 10:59:15 +02:00
fix(copy): address PR #121 review comments (7 issues) 75e003846b 
- Fix sova headquarters GJ 280B → GJ 280A (core.toml + tier1.toml)
- Relocate Ross 154 Water Cooperative to Kapteyn's Star (GJ 191)
- Fix Rødvik archetype gas_giant_skimming → frontier_ice_mining
- Fix Altmark shadow economy hop band (outer_reach → mid_reach, hop 6)
- Fix Holgersen naming (was Holmgren) in north_reach.toml
- Fix Hansestadt gate count 5 → 6 in currency_zones.toml
- Fix unclosed parenthesis in shadow_economy.toml CAPACITY GAP comment

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jpmschweitzer closed this pull request 2026-04-07 12:03:49 +02:00
jpmschweitzer commented 2026-04-12 09:40:46 +02:00
Author
Owner
Copy Link
Copy Source

Review Round 2: sprint-33/copy → main (PR #121)

Fix commit: 75e00384 — all 7 round-1 issues addressed.

Hoshe (QA): APPROVE

  • GJ 280B → GJ 280A: confirmed fixed in both tier1.toml and core.toml
  • Rødvik archetype: gas_giant_skimming → frontier_ice_mining
  • Holgersen naming: consistent throughout (separate "Holmgren's Passage" at GJ 877 is a different settlement)
  • Parenthesis closed in shadow_economy.toml

Miri (World Consistency): APPROVE

  • Ross 154 Water Cooperative relocated to Kapteyn's Star (GJ 191) — system confirmed in DB, backstory updated with lore justification
  • Altmark rationale rewritten for mid_reach band (hop 6), intensity 0.48 properly justified
  • Hansestadt gate count corrected to 6

Verdict: APPROVED

All 7 issues from round 1 resolved. Clean to merge.

## Review Round 2: sprint-33/copy → main (PR #121) **Fix commit:** `75e00384` — all 7 round-1 issues addressed. ### Hoshe (QA): APPROVE - GJ 280B → GJ 280A: confirmed fixed in both tier1.toml and core.toml - Rødvik archetype: gas_giant_skimming → frontier_ice_mining - Holgersen naming: consistent throughout (separate "Holmgren's Passage" at GJ 877 is a different settlement) - Parenthesis closed in shadow_economy.toml ### Miri (World Consistency): APPROVE - Ross 154 Water Cooperative relocated to Kapteyn's Star (GJ 191) — system confirmed in DB, backstory updated with lore justification - Altmark rationale rewritten for mid_reach band (hop 6), intensity 0.48 properly justified - Hansestadt gate count corrected to 6 ### Verdict: APPROVED All 7 issues from round 1 resolved. Clean to merge.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jpmschweitzer (Jeroen Schweitzer)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: jpmschweitzer/settled-reach#121