Jeroen Schweitzer jpmschweitzer
0 Followers · 0 Following
  • Joined on 2025-11-14
Repositories
13
 Projects Packages Public Activity Starred Repositories
jpmschweitzer closed pull request jpmschweitzer/settled-reach#19 2026-02-13 18:10:33 +01:00
feat(ci): pre-commit FactId validation hook (#393)
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-02-13 18:10:29 +01:00
07d7bf635d Merge remote-tracking branch 'origin/ci'
163de8bf25 fix(ci): address PR review — filter comments, trim whitespace, warn on missing scripts
fa3c473273 chore(meta): update changelog
fe204aa5f4 feat(ci): add pre-commit FactId validation hook (#393)
Compare 4 commits »
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#19 2026-02-13 18:10:02 +01:00
feat(ci): pre-commit FactId validation hook (#393)

Re-review: ci -> main (PR #19)

Hoshe (Code Quality): APPROVE

All three original issues fixed correctly in 163de8b. Both pipelines have symmetric comment filtering and whitespace trimming.…

jpmschweitzer pushed to client at jpmschweitzer/settled-reach 2026-02-13 18:07:40 +01:00
0f9ecac74a chore(meta): update changelog
470ec59b63 fix(ui): adapt client to new ui-strings.yaml structure
Compare 2 commits »
jpmschweitzer pushed to client at jpmschweitzer/settled-reach 2026-02-13 17:58:33 +01:00
15ea6f1375 Merge remote-tracking branch 'origin/copy'
218673f0ea chore(meta): update changelog
fe3232377d refactor(content): move ui-strings.yaml to client/data/
15a4bcadd2 chore(meta): update changelog
124573e1c5 fix(content): normalize fact_ids, entity refs, tags across FRIEND content
Compare 9 commits »
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-02-13 17:57:12 +01:00
15ea6f1375 Merge remote-tracking branch 'origin/copy'
218673f0ea chore(meta): update changelog
fe3232377d refactor(content): move ui-strings.yaml to client/data/
15a4bcadd2 chore(meta): update changelog
124573e1c5 fix(content): normalize fact_ids, entity refs, tags across FRIEND content
Compare 9 commits »
jpmschweitzer pushed to copy at jpmschweitzer/settled-reach 2026-02-13 17:55:16 +01:00
218673f0ea chore(meta): update changelog
fe3232377d refactor(content): move ui-strings.yaml to client/data/
Compare 2 commits »
jpmschweitzer pushed to copy at jpmschweitzer/settled-reach 2026-02-13 17:52:29 +01:00
15a4bcadd2 chore(meta): update changelog
124573e1c5 fix(content): normalize fact_ids, entity refs, tags across FRIEND content
99550ed0f5 feat(content): add FRIEND packs and PC-as-NPC content (#297, #298, #401)
adaaebbe71 feat(content): add UI microcopy strings (#409)
d51d9d9e46 feat(content): add NPC authoring style guide (#379)
Compare 33 commits »
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#19 2026-02-13 17:42:41 +01:00
feat(ci): pre-commit FactId validation hook (#393)

All review items addressed in 163de8b:

  1. Comment line filtering (critical) — added grep -v '^\s*#' to both canonical and reference extraction pipelines
  2. Trailing whitespace trimming…
jpmschweitzer pushed to ci at jpmschweitzer/settled-reach 2026-02-13 17:42:32 +01:00
163de8bf25 fix(ci): address PR review — filter comments, trim whitespace, warn on missing scripts
jpmschweitzer closed pull request jpmschweitzer/settled-reach#20 2026-02-13 17:39:46 +01:00
feat(ui): YAML UI string system + interaction prompt (#409)
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-02-13 17:39:37 +01:00
e90fe8b146 chore(meta): update changelog
5a04656781 feat(ui): add YAML-based UI string loading system (#409)
Compare 2 commits »
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#19 2026-02-13 17:39:31 +01:00
feat(ci): pre-commit FactId validation hook (#393)

Review: ci -> main (PR #19)

Hoshe (Code Quality): REQUEST_CHANGES

Grep-based validation and modular hook infrastructure are well-designed. Two-mode (advisory/enforcing) is pragmatic.…

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#20 2026-02-13 17:39:29 +01:00
feat(ui): YAML UI string system + interaction prompt (#409)

Review: client -> main (PR #20)

Hoshe (Code Quality): APPROVE

Well-tested (15 tests, 114% test-to-code ratio), clean integration into HUD and interaction prompt. Fallback-to-key prevents…

jpmschweitzer created pull request jpmschweitzer/settled-reach#20 2026-02-13 17:18:43 +01:00
feat(ui): YAML UI string system + interaction prompt (#409)
jpmschweitzer pushed to client at jpmschweitzer/settled-reach 2026-02-13 17:18:25 +01:00
e90fe8b146 chore(meta): update changelog
5a04656781 feat(ui): add YAML-based UI string loading system (#409)
3b757f5adc chore(meta): update changelog
524aca52eb chore(db): update database backup after client merge
03914c6442 docs(briefings): update Hoshe with integration test coverage priorities
Compare 8 commits »
jpmschweitzer created pull request jpmschweitzer/settled-reach#19 2026-02-13 17:18:11 +01:00
feat(ci): pre-commit FactId validation hook (#393)
jpmschweitzer pushed to ci at jpmschweitzer/settled-reach 2026-02-13 17:17:56 +01:00
fa3c473273 chore(meta): update changelog
fe204aa5f4 feat(ci): add pre-commit FactId validation hook (#393)
3b757f5adc chore(meta): update changelog
524aca52eb chore(db): update database backup after client merge
03914c6442 docs(briefings): update Hoshe with integration test coverage priorities
Compare 104 commits »
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-02-13 02:14:13 +01:00
3b757f5adc chore(meta): update changelog
524aca52eb chore(db): update database backup after client merge
03914c6442 docs(briefings): update Hoshe with integration test coverage priorities
963f89b8ba Merge remote-tracking branch 'origin/client'
dd40f92600 chore(meta): update changelog
Compare 14 commits »
jpmschweitzer pushed to client at jpmschweitzer/settled-reach 2026-02-13 02:08:20 +01:00
dd40f92600 chore(meta): update changelog
c68585e5f2 chore(simulation): add debug logging for received inputs
e6d6802c8d fix(client): align tests with kind-based player detection
e810abdcaf fix(client): use server tick for movement input processing
ea9cf554c6 fix(client): decode tile_kind and fix entity alignment (#412)
Compare 10 commits »