jpmschweitzer/settled-reach
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

chore(ci): move db/connectors/ to tooling/db/ (#274) #74

Closed
jpmschweitzer wants to merge 0 commits from ci into main
pull from: ci
merge into: :main
Conversation 6 Commits - Files Changed -
+135 -105
jpmschweitzer commented 2026-02-27 11:10:08 +01:00
Owner
Copy Link
Copy Source

Summary

  • Move all connector scripts (ticket, sprint, sqlite, qdrant, audio, decision CLIs) from db/connectors/ to tooling/db/
  • Symlink at db/connectors → ../tooling/db for backwards compatibility (remove after Sprint 22)
  • Update all references: CLAUDE.md, Makefile, DEVOPS.md, 10 skill files, 1 agent file, 2 rules, schema, README, Sprint 21 briefings, tooling scripts
  • Fix SCHEMA_PATH in Python scripts to resolve via WORKTREE_ROOT/db/schema.sql

Verification

  • tooling/db/ticket list ✓
  • db/connectors/ticket list (via symlink) ✓
  • make decisions-sync ✓
  • Pre-commit hooks pass (fact-ids, decision-ids)

Test plan

  • make decisions-sync passes at new path
  • tooling/db/ticket show 274 returns ticket data
  • db/connectors/ticket show 274 works via symlink
  • make ci passes (note: pre-existing clippy warnings in server code unrelated to this PR)
  • Other worktree agents can still use db/connectors/ paths via symlink
## Summary - Move all connector scripts (ticket, sprint, sqlite, qdrant, audio, decision CLIs) from `db/connectors/` to `tooling/db/` - Symlink at `db/connectors → ../tooling/db` for backwards compatibility (remove after Sprint 22) - Update all references: CLAUDE.md, Makefile, DEVOPS.md, 10 skill files, 1 agent file, 2 rules, schema, README, Sprint 21 briefings, tooling scripts - Fix `SCHEMA_PATH` in Python scripts to resolve via `WORKTREE_ROOT/db/schema.sql` ## Verification - `tooling/db/ticket list` ✓ - `db/connectors/ticket list` (via symlink) ✓ - `make decisions-sync` ✓ - Pre-commit hooks pass (fact-ids, decision-ids) ## Test plan - [ ] `make decisions-sync` passes at new path - [ ] `tooling/db/ticket show 274` returns ticket data - [ ] `db/connectors/ticket show 274` works via symlink - [ ] `make ci` passes (note: pre-existing clippy warnings in server code unrelated to this PR) - [ ] Other worktree agents can still use `db/connectors/` paths via symlink
jpmschweitzer added 3 commits 2026-02-27 11:10:09 +01:00
chore(db): move db/connectors/ to tooling/db/ (#274) bc226d8baf 
Consolidates all connector scripts under tooling/ per project
structure conventions. Symlink at db/connectors → tooling/db/
preserves backwards compatibility (remove after Sprint 22).

Updated references in CLAUDE.md, Makefile, DEVOPS.md, all skill
files, agent files, rules, schema comments, and Sprint 21
briefings. Python scripts updated with correct SCHEMA_PATH
(now relative to WORKTREE_ROOT/db/schema.sql).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
chore(meta): update changelog 2893366a6f 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
chore(meta): sync Cargo.lock version after main merge 0ab81961dc 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jpmschweitzer commented 2026-02-27 11:14:12 +01:00
Author
Owner
Copy Link
Copy Source

Review APPROVED - see details below

Review APPROVED - see details below
jpmschweitzer commented 2026-02-27 17:44:38 +01:00
Author
Owner
Copy Link
Copy Source

Review: ci -> main (PR #74, type: code)

Hoshe (Code Quality): REQUEST_CHANGES

Clean move overall — path calculations are correct, symlink is valid, hot paths updated. Two gaps need fixing.

# File Severity Issue
1 .claude/agent-memory/hoshe/MEMORY.md:37,39 warning Stale db/connectors/ references in agent memory — injected into system prompt, will misdirect agents
2 .claude/settings.json warning Legacy db/connectors/ permission block missing decision * entry — agents using symlink path for decision claim will be denied
3 docs/DEVOPS.md:16 suggestion Layout table still describes db/ as containing connectors
4 docs/sprints/sprint-2..20/ suggestion ~111 stale db/connectors/ references in archived sprint docs (functional via symlink, low risk)

Tyre (Architecture): APPROVE

Architecturally sound — operational scripts belong in tooling/, not alongside schema DDL. Clean separation. D-010/D-012 unaffected.

# File Severity Issue
1 db/connectors (symlink) warning "Remove after Sprint 22" has no enforcement ticket — file one before merge
2 whatsinagame/ templates suggestion Intentionally uses db/connectors/ (kit canonical path) — note in Sprint 22 removal ticket
3 .claude/agent-memory/hoshe/MEMORY.md suggestion Stale references, will break after symlink removal

Verdict: CHANGES REQUESTED

Fix the settings.json missing decision * permission entry and the agent memory stale paths before merge. File Sprint 22 symlink-removal ticket.

## Review: ci -> main (PR #74, type: code) ### Hoshe (Code Quality): REQUEST_CHANGES Clean move overall — path calculations are correct, symlink is valid, hot paths updated. Two gaps need fixing. | # | File | Severity | Issue | |---|------|----------|-------| | 1 | `.claude/agent-memory/hoshe/MEMORY.md:37,39` | warning | Stale `db/connectors/` references in agent memory — injected into system prompt, will misdirect agents | | 2 | `.claude/settings.json` | warning | Legacy `db/connectors/` permission block missing `decision *` entry — agents using symlink path for `decision claim` will be denied | | 3 | `docs/DEVOPS.md:16` | suggestion | Layout table still describes `db/` as containing connectors | | 4 | `docs/sprints/sprint-2..20/` | suggestion | ~111 stale `db/connectors/` references in archived sprint docs (functional via symlink, low risk) | ### Tyre (Architecture): APPROVE Architecturally sound — operational scripts belong in `tooling/`, not alongside schema DDL. Clean separation. D-010/D-012 unaffected. | # | File | Severity | Issue | |---|------|----------|-------| | 1 | `db/connectors` (symlink) | warning | "Remove after Sprint 22" has no enforcement ticket — file one before merge | | 2 | `whatsinagame/` templates | suggestion | Intentionally uses `db/connectors/` (kit canonical path) — note in Sprint 22 removal ticket | | 3 | `.claude/agent-memory/hoshe/MEMORY.md` | suggestion | Stale references, will break after symlink removal | ### Verdict: CHANGES REQUESTED Fix the `settings.json` missing `decision *` permission entry and the agent memory stale paths before merge. File Sprint 22 symlink-removal ticket.
jpmschweitzer added 1 commit 2026-02-27 17:51:15 +01:00
fix(ci): address PR #74 review comments ccff595101 
Add missing db/connectors/decision permission in settings.json and
update DEVOPS.md layout table to reflect connector move. Filed #568
for Sprint 22 symlink removal.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jpmschweitzer commented 2026-02-27 17:51:56 +01:00
Author
Owner
Copy Link
Copy Source

Review comments addressed in ccff595:

  • Hoshe #1 (agent memory stale paths): Updated locally (gitignored, not in diff)
  • Hoshe #2 (missing decision permission): Added Bash(db/connectors/decision *) to settings.json
  • Hoshe #3 (DEVOPS layout table): Updated db/ description
  • Tyre #1 (symlink removal ticket): Filed as #568, includes whatsinagame/ template note
  • Hoshe #4 / Tyre #3 (archived sprint docs): Skipped — functional via symlink, will self-resolve with #568
Review comments addressed in ccff595: - **Hoshe #1** (agent memory stale paths): Updated locally (gitignored, not in diff) - **Hoshe #2** (missing decision permission): Added `Bash(db/connectors/decision *)` to settings.json - **Hoshe #3** (DEVOPS layout table): Updated db/ description - **Tyre #1** (symlink removal ticket): Filed as #568, includes whatsinagame/ template note - **Hoshe #4 / Tyre #3** (archived sprint docs): Skipped — functional via symlink, will self-resolve with #568
jpmschweitzer commented 2026-02-27 18:46:07 +01:00
Author
Owner
Copy Link
Copy Source

Re-review: ci -> main (PR #74, round 2)

Hoshe (Code Quality): REQUEST_CHANGES

Both previous fixes verified correct. One new parity gap found.

# File Severity Issue
1 .claude/settings.json warning Legacy db/connectors/ block missing audio-batch * — new block has tooling/db/audio-batch * but no legacy equivalent

Tyre (Architecture): APPROVE

Both fixes verified. Sprint 22 symlink-removal ticket (#568) filed. Notes audio-batch gap as pre-existing, scoped to Sprint 22 cleanup.

Verdict: CHANGES REQUESTED

One more parity fix: add "Bash(db/connectors/audio-batch *)" to the legacy permission block in settings.json.

## Re-review: ci -> main (PR #74, round 2) ### Hoshe (Code Quality): REQUEST_CHANGES Both previous fixes verified correct. One new parity gap found. | # | File | Severity | Issue | |---|------|----------|-------| | 1 | `.claude/settings.json` | warning | Legacy `db/connectors/` block missing `audio-batch *` — new block has `tooling/db/audio-batch *` but no legacy equivalent | ### Tyre (Architecture): APPROVE Both fixes verified. Sprint 22 symlink-removal ticket (#568) filed. Notes `audio-batch` gap as pre-existing, scoped to Sprint 22 cleanup. ### Verdict: CHANGES REQUESTED One more parity fix: add `"Bash(db/connectors/audio-batch *)"` to the legacy permission block in `settings.json`.
jpmschweitzer added 1 commit 2026-02-27 18:54:25 +01:00
fix(ci): add missing db/connectors/audio-batch permission 394742ee98 
Parity fix from PR #74 re-review round 2: legacy permission block
was missing audio-batch entry that exists in the tooling/db/ block.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jpmschweitzer commented 2026-02-27 18:54:28 +01:00
Author
Owner
Copy Link
Copy Source

Round 2 fix in 394742e: added missing Bash(db/connectors/audio-batch *) to legacy permission block. All parity gaps now closed.

Round 2 fix in 394742e: added missing `Bash(db/connectors/audio-batch *)` to legacy permission block. All parity gaps now closed.
jpmschweitzer commented 2026-02-27 18:56:19 +01:00
Author
Owner
Copy Link
Copy Source

Re-review: ci -> main (PR #74, round 3)

Hoshe: APPROVE

audio-batch * added to legacy permission block (394742e). Both tooling/db/ and db/connectors/ blocks are now fully symmetric.

Tyre: APPROVE (standing from round 2)

Verdict: APPROVED

All blockers resolved across 3 rounds. Clean to merge.

## Re-review: ci -> main (PR #74, round 3) ### Hoshe: APPROVE `audio-batch *` added to legacy permission block (394742e). Both `tooling/db/` and `db/connectors/` blocks are now fully symmetric. ### Tyre: APPROVE (standing from round 2) ### Verdict: APPROVED All blockers resolved across 3 rounds. Clean to merge.
jpmschweitzer closed this pull request 2026-02-27 18:57:11 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jpmschweitzer (Jeroen Schweitzer)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: jpmschweitzer/settled-reach#74