Block a user
feat(ui): entity-bound speaker colors + entity renderer test fixes (#573, #574)
Update: PR now also includes #581 (debug console).
Additional commits since opening:
fix(ui): clear color registry on conversation end, add speaker color tests (#573)fix(ui): correct…
feat(ui): entity-bound speaker colors + entity renderer test fixes (#573, #574)
Review:
Review: client → main (type: code)
Hoshe (Code Quality): REQUEST_CHANGES
Summary: Entity renderer test fixes (#574) are correct — Sprite2D/self_modulate assertions match the…
feat(ui): entity-bound speaker colors + entity renderer test fixes (#573, #574)
feat(server): Sprint 23 — tile system, storyteller activation, debug console, LOS fix
feat(server): Sprint 23 — tile system, storyteller activation, debug console, LOS fix
Re-review:
Re-review: server → main — after fix commit ac68ec6
Hoshe (Code Quality): APPROVE
All 3 criticals and 14 warnings from the first review verified fixed. 3 minor new observations (all…
feat(server): Sprint 23 — tile system, storyteller activation, debug console, LOS fix
Review Fixes Applied (ac68ec6)
All 3 critical and 14 high-priority issues from the review have been addressed:
Critical (3/3 fixed)
feat(server): Sprint 23 — tile system, storyteller activation, debug console, LOS fix
Review:
Review: server → main (type: code)
Hoshe (Code Quality): REQUEST_CHANGES
Summary: Well-structured sprint delivering five features with good test coverage. However, the deep pass…
feat(server): Sprint 23 — tile system, storyteller activation, debug console, LOS fix
feat(simulation): Sprint 22 — NPC pool, triangles, contamination