Jeroen Schweitzer jpmschweitzer
0 Followers · 0 Following
  • Joined on 2025-11-14
Repositories
13
 Projects Packages Public Activity Starred Repositories
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#79 2026-02-28 23:51:37 +01:00
feat(simulation): Sprint 22 — NPC pool, triangles, contamination

Review: server → main (type: code, round 4)

Hoshe (Code Quality): APPROVE

All four round 3 issues confirmed fixed:

  • StorytellerPlugin registered in main() (L150) and `dump_schedule_g…
jpmschweitzer pushed to server at jpmschweitzer/settled-reach 2026-02-28 23:48:09 +01:00
282dad8d50 fix(simulation): address all round 3 PR review issues
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-02-28 23:43:31 +01:00
f80b6c1aca Merge remote-tracking branch 'origin/visual'
12c2d86771 fix(assets): deprecate VIS_PERIPHERAL and fix spec table label
2f22fbe4c1 fix(assets): purge stale 5-layer/peripheral references from fog spec
a1bdab949b fix(assets): sync spec noise amplitudes and gradient radius
b9b9c923a0 fix(assets): correct gradient radius comment from 6-8 to 3-4 tiles
Compare 8 commits »
jpmschweitzer closed pull request jpmschweitzer/settled-reach#77 2026-02-28 23:43:31 +01:00
fix(assets): Sprint 22 — fog shader alpha and zone temperature tint
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#77 2026-02-28 23:40:26 +01:00
fix(assets): Sprint 22 — fog shader alpha and zone temperature tint

Review: visual → main (type: visual, round 5)

Hoshe (QA): APPROVE

Full numeric consistency sweep — every value matches between spec and shader. Both round 4 warnings resolved:…

jpmschweitzer pushed to visual at jpmschweitzer/settled-reach 2026-02-28 23:38:36 +01:00
12c2d86771 fix(assets): deprecate VIS_PERIPHERAL and fix spec table label
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#77 2026-02-28 23:36:43 +01:00
fix(assets): Sprint 22 — fog shader alpha and zone temperature tint

Review: visual → main (type: visual, round 4)

Hoshe (QA): REQUEST_CHANGES

Round 3 issues #2 (player_pos uniform) and #3 ("5-layer" label) are fixed. Two stale references remain.

jpmschweitzer closed pull request jpmschweitzer/settled-reach#78 2026-02-28 23:34:41 +01:00
fix(client): Sprint 22 — fog rendering fix and seed config
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-02-28 23:34:41 +01:00
150faca5d9 Merge remote-tracking branch 'origin/client'
6fac224d55 fix(client): prevent signed overflow in world_seed generation and load
50aba3adf6 fix(client): address PR #78 review comments
b89c4d5c9d chore(meta): update changelog
d591f44b35 feat(simulation): add world_seed IPC and EntanglementConfig (#175, #178)
Compare 6 commits »
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#79 2026-02-28 23:32:37 +01:00
feat(simulation): Sprint 22 — NPC pool, triangles, contamination

Review: server → main (type: code, round 3)

Hoshe (Code Quality): REQUEST_CHANGES

ContaminationActive save/load fixed, CONTAMINATION_DELAY_TICKS corrected. But the #1 critical from round…

jpmschweitzer pushed to visual at jpmschweitzer/settled-reach 2026-02-28 23:26:38 +01:00
2f22fbe4c1 fix(assets): purge stale 5-layer/peripheral references from fog spec
jpmschweitzer pushed to server at jpmschweitzer/settled-reach 2026-02-28 23:25:14 +01:00
d3217c5ae3 fix(simulation): replace f32 fields in generator with integer types
339f112c8f fix(simulation): fix triangle state save/load and persist contamination
70de959ac3 fix(simulation): correct CONTAMINATION_DELAY_TICKS from 1800 to 300
Compare 3 commits »
jpmschweitzer pushed to client at jpmschweitzer/settled-reach 2026-02-28 23:24:51 +01:00
6fac224d55 fix(client): prevent signed overflow in world_seed generation and load
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#77 2026-02-28 23:23:51 +01:00
fix(assets): Sprint 22 — fog shader alpha and zone temperature tint

Review: visual → main (type: visual, round 3)

Hoshe (QA): REQUEST_CHANGES

Round 2 issues (noise amplitudes, gradient radius wording) are confirmed fixed. However, deeper spec audit found…

jpmschweitzer pushed to visual at jpmschweitzer/settled-reach 2026-02-28 23:21:16 +01:00
a1bdab949b fix(assets): sync spec noise amplitudes and gradient radius
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-02-28 23:15:11 +01:00
ded24de31b chore(meta): update changelog
b025fe8152 chore(db): remove db/connectors backwards-compat symlink (#568)
Compare 2 commits »
jpmschweitzer closed pull request jpmschweitzer/settled-reach#80 2026-02-28 23:15:11 +01:00
chore(ci): remove db/connectors backwards-compat symlink (#568)
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#80 2026-02-28 23:06:01 +01:00
chore(ci): remove db/connectors backwards-compat symlink (#568)

Review: ci → main (type: code)

Hoshe (QA): APPROVE

Symlink removed. All operational paths updated to tooling/db/. 80 remaining db/connectors hits are in archived docs (sprint…

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#79 2026-02-28 23:06:01 +01:00
feat(simulation): Sprint 22 — NPC pool, triangles, contamination

Re-review: server → main (round 2)

No new commits since previous review. Original verdict stands: CHANGES REQUESTED.

Unresolved critical issues:

  1. **StorytellerPlugin not…
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#77 2026-02-28 23:06:00 +01:00
fix(assets): Sprint 22 — fog shader alpha and zone temperature tint

Re-review: visual → main (round 2)

Hoshe (QA): REQUEST_CHANGES

Original warnings resolved. Two new issues in fix commits: