Jeroen Schweitzer jpmschweitzer
  • Joined on 2025-11-14
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#97 2026-03-22 16:49:04 +01:00
docs(design): character creation screen wireframes (#685)

Review: planning -> main — Round 2

Hoshe (QA): APPROVE

All 7 fixes verified. Minor note: wireframe file table line 27 still says "Head template + eyebrows tab" — trivial post-merge…

jpmschweitzer pushed to planning at jpmschweitzer/settled-reach 2026-03-22 16:46:03 +01:00
029cf67e08 fix(design): relabel auto-derive to "follow primary"
jpmschweitzer pushed to planning at jpmschweitzer/settled-reach 2026-03-22 16:45:04 +01:00
fb71ff4c9f fix(design): align hair color dock — labels above swatches in 4 columns
jpmschweitzer pushed to planning at jpmschweitzer/settled-reach 2026-03-22 16:42:59 +01:00
143185741e fix(design): address PR #97 review — all items
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#97 2026-03-22 16:33:23 +01:00
docs(design): character creation screen wireframes (#685)

Review: planning -> main (type: code)

Hoshe (QA): REQUEST_CHANGES

Wireframe covers the right feature surface. D-159 and D-165 correctly formatted.

jpmschweitzer created pull request jpmschweitzer/settled-reach#97 2026-03-22 16:28:46 +01:00
docs(design): character creation screen wireframes (#685)
jpmschweitzer pushed to planning at jpmschweitzer/settled-reach 2026-03-22 16:28:19 +01:00
93260ed696 docs(design): add character creation screen wireframes (#685)
a435163fd0 docs(decisions): update D-159 body type count (9→11), add D-165 color palette
0b1bfe6a96 fix(assets): address PR #96 review — all 8 items
8f7e0f09b0 chore(meta): update changelog
d54040e3b7 feat(assets): add body type segment GLBs for all 11 body types
Compare 18 commits »
jpmschweitzer closed pull request jpmschweitzer/settled-reach#96 2026-03-22 15:27:15 +01:00
feat(assets): character body, head, and hair GLBs from Source tier
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-03-22 15:27:09 +01:00
0b1bfe6a96 fix(assets): address PR #96 review — all 8 items
8f7e0f09b0 chore(meta): update changelog
d54040e3b7 feat(assets): add body type segment GLBs for all 11 body types
8473986905 feat(assets): add head template library and hair/eyebrow accessory GLBs
a60493c2f7 chore(assets): add Blender headless pipeline scripts for character assets
Compare 5 commits »
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#96 2026-03-22 15:27:00 +01:00
feat(assets): character body, head, and hair GLBs from Source tier

Review: visual -> main (type: visual) — Round 2

Hoshe (QA): APPROVE

All 4 fixes verified. No remaining issues.

Araminta (Art Direction): APPROVE

All 6 fixes verified. One minor note:…

jpmschweitzer pushed to visual at jpmschweitzer/settled-reach 2026-03-22 15:24:56 +01:00
0b1bfe6a96 fix(assets): address PR #96 review — all 8 items
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#96 2026-03-22 15:18:40 +01:00
feat(assets): character body, head, and hair GLBs from Source tier

Review: visual -> main (type: visual)

Hoshe (QA): REQUEST_CHANGES

Asset library is structurally sound — all 11 body types, naming conventions, mask sidecar pairing all verified correct.…

jpmschweitzer created pull request jpmschweitzer/settled-reach#96 2026-03-22 15:14:15 +01:00
feat(assets): character body, head, and hair GLBs from Source tier
jpmschweitzer pushed to visual at jpmschweitzer/settled-reach 2026-03-22 15:13:36 +01:00
8f7e0f09b0 chore(meta): update changelog
d54040e3b7 feat(assets): add body type segment GLBs for all 11 body types
8473986905 feat(assets): add head template library and hair/eyebrow accessory GLBs
a60493c2f7 chore(assets): add Blender headless pipeline scripts for character assets
bcd5887b82 fix(client): address PR #95 review — 8 items
Compare 307 commits »
jpmschweitzer closed pull request jpmschweitzer/settled-reach#95 2026-03-20 09:07:13 +01:00
feat(client): character visual pipeline — compositor, descriptor, assets
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-03-20 09:07:08 +01:00
bcd5887b82 fix(client): address PR #95 review — 8 items
f34e6362c4 docs(decisions): update camera presets, bone names, accessory slots
23ec1ddebd feat(client): CharacterVisualDescriptor and compositor (#703, #704)
ff3a8e95e4 feat(client): port character shaders, skin tones, skeleton, and animations (#702, #706)
Compare 4 commits »
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#95 2026-03-20 09:05:15 +01:00
feat(client): character visual pipeline — compositor, descriptor, assets

Review: client -> main (type: code) — Round 2

Hoshe (Code Quality): APPROVE

All 8 fixes from round 1 verified. Three suggestions for follow-up:

jpmschweitzer pushed to client at jpmschweitzer/settled-reach 2026-03-20 07:59:27 +01:00
bcd5887b82 fix(client): address PR #95 review — 8 items
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#95 2026-03-20 07:53:34 +01:00
feat(client): character visual pipeline — compositor, descriptor, assets

Review: client -> main (type: code)

Hoshe (Code Quality): REQUEST_CHANGES

Well-structured compositor with thorough test-first coverage. Skip-with-warning pattern is right for this…

jpmschweitzer created pull request jpmschweitzer/settled-reach#95 2026-03-20 07:49:33 +01:00
feat(client): character visual pipeline — compositor, descriptor, assets