jpmschweitzer/settled-reach
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

docs(design): character creation screen wireframes (#685) #97

Closed
jpmschweitzer wants to merge 0 commits from planning into main
pull from: planning
merge into: :main
Conversation 2 Commits - Files Changed -
jpmschweitzer commented 2026-03-22 16:28:46 +01:00
Owner
Copy Link
Copy Source

Summary

  • 6 wireframe views for the character creation screen (Body, Head, Hair, Clothing, Accessories, Color Picker modal) as Frame0 JSON source + PNG exports
  • Summary spec document at docs/design/character-creation-screen-wireframe.md
  • D-159 updated: body type count corrected from 9 to 11 (teen was missing)
  • D-165 added: character creator color palette (6×9 HSL-computed muted swatches + hex input + 9 recent custom color slots)

Layout decisions

  • Preview pane takes ~60% of screen width with [Q]/[E] incremental rotation
  • 5 tabs: Body, Head, Hair, Clothing, Accessories (no separate Colors tab)
  • Each tab: search bar (top, fixed), scrollable grid (middle), color dock (bottom, fixed)
  • Skin tone (9 swatches) docked at bottom of Body and Head tabs (shared state)
  • Hair/clothing/accessory colors docked at bottom of their respective tabs
  • Wrist L/R slots replace Held L/R (held items are play-time, not creation-time)

Downstream

Unblocks #694 (client: character creation screen) and #705 (character editor Godot tool).

🤖 Generated with Claude Code

## Summary - 6 wireframe views for the character creation screen (Body, Head, Hair, Clothing, Accessories, Color Picker modal) as Frame0 JSON source + PNG exports - Summary spec document at `docs/design/character-creation-screen-wireframe.md` - D-159 updated: body type count corrected from 9 to 11 (teen was missing) - D-165 added: character creator color palette (6×9 HSL-computed muted swatches + hex input + 9 recent custom color slots) ## Layout decisions - Preview pane takes ~60% of screen width with [Q]/[E] incremental rotation - 5 tabs: Body, Head, Hair, Clothing, Accessories (no separate Colors tab) - Each tab: search bar (top, fixed), scrollable grid (middle), color dock (bottom, fixed) - Skin tone (9 swatches) docked at bottom of Body and Head tabs (shared state) - Hair/clothing/accessory colors docked at bottom of their respective tabs - Wrist L/R slots replace Held L/R (held items are play-time, not creation-time) ## Downstream Unblocks #694 (client: character creation screen) and #705 (character editor Godot tool). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
jpmschweitzer added 2 commits 2026-03-22 16:28:46 +01:00
docs(decisions): update D-159 body type count (9→11), add D-165 color palette a435163fd0 
D-159 was missing teen body type — updated to 5 types × 2 genders + 1 child = 11.
D-165 records the character creator color palette (6×9 HSL-computed swatches).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
docs(design): add character creation screen wireframes (#685) 93260ed696 
6 wireframe views (Body, Head, Hair, Clothing, Accessories, Color Picker)
as Frame0 JSON source + PNG exports, plus summary spec document.

Layout: 60% preview pane with [Q]/[E] rotation, 35% tabbed panel with
search bar, scrollable grid, and docked color controls per tab.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jpmschweitzer commented 2026-03-22 16:33:23 +01:00
Author
Owner
Copy Link
Copy Source

Review: planning -> main (type: code)

Hoshe (QA): REQUEST_CHANGES

Wireframe covers the right feature surface. D-159 and D-165 correctly formatted.

# File Severity Issue
1 wireframe doc, line 22 warning PR description path doesn't match actual file location
2 wireframe doc warning Body tab not explicitly called out as covered by main-layout — ambiguous
3 scope.md D-155 anchor warning Stale cross-reference anchor (still says "full 360 rotation")
4 wireframe, Accessories tab warning Missing earring_l/r and necklace slots — no note explaining deferral
5 wireframe, Head tab suggestion Eyebrow names (Thin, Arched) don't match asset spec keys (regular, female, teen, thick)
6 wireframe, line 62 suggestion Skin tone D-165 note could be clearer

Tyre (Architecture): REQUEST_CHANGES

Core structure is solid — D-146, D-158, D-159 all correctly implemented. CharacterVisualDescriptor coverage is complete.

# File Severity Issue
1 wireframe, Body tab warning "Other" row label for Child — should be unlabeled or neutral, not gendered framing
2 wireframe, Notes warning Coverage.json compositor flow not documented — clothing preview needs segment visibility updates
3 wireframe, Head tab warning Eyebrow tint control missing — descriptor has eyebrow_tint but no UI for it
4 architecture.md D-160 warning Still says 17 segments, should be 18 (pre-existing, surfaced by this PR)
5 scope.md D-165 suggestion Missing cross-reference to skin tone system / asset spec
6 wireframe, Head tab suggestion Eyebrow display names don't match Source tier asset names

Verdict: CHANGES REQUESTED

Overlap: Both reviewers flag the eyebrow name mismatch (Hoshe #5 / Tyre #6) and accessory slot gap (Hoshe #4).

Priority fixes:

  1. "Other" → neutral label for Child row
  2. Add coverage.json note to implementation section
  3. Add eyebrow tint control or document auto-derive-from-hair decision
  4. Fix D-160 segment count (17→18) in architecture.md
  5. Reconcile eyebrow display names with asset keys
  6. Add earring/necklace slots or document deferral
  7. Fix D-155 cross-reference anchor

Reviewed by Hoshe (code quality) and Tyre (architecture) via /pr-review

## Review: planning -> main (type: code) ### Hoshe (QA): REQUEST_CHANGES Wireframe covers the right feature surface. D-159 and D-165 correctly formatted. | # | File | Severity | Issue | |---|------|----------|-------| | 1 | wireframe doc, line 22 | warning | PR description path doesn't match actual file location | | 2 | wireframe doc | warning | Body tab not explicitly called out as covered by main-layout — ambiguous | | 3 | scope.md D-155 anchor | warning | Stale cross-reference anchor (still says "full 360 rotation") | | 4 | wireframe, Accessories tab | warning | Missing earring_l/r and necklace slots — no note explaining deferral | | 5 | wireframe, Head tab | suggestion | Eyebrow names (Thin, Arched) don't match asset spec keys (regular, female, teen, thick) | | 6 | wireframe, line 62 | suggestion | Skin tone D-165 note could be clearer | ### Tyre (Architecture): REQUEST_CHANGES Core structure is solid — D-146, D-158, D-159 all correctly implemented. CharacterVisualDescriptor coverage is complete. | # | File | Severity | Issue | |---|------|----------|-------| | 1 | wireframe, Body tab | warning | "Other" row label for Child — should be unlabeled or neutral, not gendered framing | | 2 | wireframe, Notes | warning | Coverage.json compositor flow not documented — clothing preview needs segment visibility updates | | 3 | wireframe, Head tab | warning | Eyebrow tint control missing — descriptor has `eyebrow_tint` but no UI for it | | 4 | architecture.md D-160 | warning | Still says 17 segments, should be 18 (pre-existing, surfaced by this PR) | | 5 | scope.md D-165 | suggestion | Missing cross-reference to skin tone system / asset spec | | 6 | wireframe, Head tab | suggestion | Eyebrow display names don't match Source tier asset names | ### Verdict: CHANGES REQUESTED **Overlap:** Both reviewers flag the eyebrow name mismatch (Hoshe #5 / Tyre #6) and accessory slot gap (Hoshe #4). **Priority fixes:** 1. "Other" → neutral label for Child row 2. Add coverage.json note to implementation section 3. Add eyebrow tint control or document auto-derive-from-hair decision 4. Fix D-160 segment count (17→18) in architecture.md 5. Reconcile eyebrow display names with asset keys 6. Add earring/necklace slots or document deferral 7. Fix D-155 cross-reference anchor --- *Reviewed by Hoshe (code quality) and Tyre (architecture) via `/pr-review`*
jpmschweitzer added 1 commit 2026-03-22 16:42:59 +01:00
fix(design): address PR #97 review — all items 143185741e 
Review fixes:
- Eyebrows moved from Head tab to Hair tab (with brow tint + beard tint)
- Head tab now has skin tone dock only
- Eyebrow names match asset keys (regular, female, teen, thick)
- Added earring L/R and necklace slots to Accessories tab
- Added wrist L/R slot labels already present, shifted grid for 3rd row
- Removed "Other" row label for Child (no gendered framing)
- D-155 cross-reference anchor fixed (was stale "full-360-rotation")
- D-160 segment count corrected 17→18 (added torso_upper)
- D-164 rationale corrected: Superhero mesh retained as muscular type
- Added compositor segment visibility note to implementation section
- D-165 cross-ref clarified (clothing colors only, not skin tones)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jpmschweitzer added 1 commit 2026-03-22 16:45:04 +01:00
fix(design): align hair color dock — labels above swatches in 4 columns fb71ff4c9f 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jpmschweitzer added 1 commit 2026-03-22 16:46:03 +01:00
fix(design): relabel auto-derive to "follow primary" 029cf67e08 
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jpmschweitzer commented 2026-03-22 16:49:04 +01:00
Author
Owner
Copy Link
Copy Source

Review: planning -> main — Round 2

Hoshe (QA): APPROVE

All 7 fixes verified. Minor note: wireframe file table line 27 still says "Head template + eyebrows tab" — trivial post-merge fix.

Tyre (Architecture): APPROVE (conditional)

6 of 7 fixes verified. Eyebrow-in-Hair-tab is architecturally sound. One stale footer in asset org doc ("17+" → "18") will be fixed on main post-merge.

Verdict: APPROVED

Stale "17+" in character-asset-organization.md Decisions Referenced footer to be fixed on main after merge.

Re-reviewed by Hoshe (QA) and Tyre (architecture) via /pr-review

## Review: planning -> main — Round 2 ### Hoshe (QA): APPROVE All 7 fixes verified. Minor note: wireframe file table line 27 still says "Head template + eyebrows tab" — trivial post-merge fix. ### Tyre (Architecture): APPROVE (conditional) 6 of 7 fixes verified. Eyebrow-in-Hair-tab is architecturally sound. One stale footer in asset org doc ("17+" → "18") will be fixed on main post-merge. ### Verdict: APPROVED Stale "17+" in `character-asset-organization.md` Decisions Referenced footer to be fixed on main after merge. --- *Re-reviewed by Hoshe (QA) and Tyre (architecture) via `/pr-review`*
jpmschweitzer closed this pull request 2026-03-22 16:49:36 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jpmschweitzer (Jeroen Schweitzer)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: jpmschweitzer/settled-reach#97