
jpmschweitzerandClaude Opus 4.8
fb47f144f8
fix(simulation): address PR #162 review (morphology geometry)
Hoshe + Tyre CHANGES REQUESTED (§8 laws + D-010 confirmed clean):
- FjordWall floor 4+grade -> ~12m violated D-239 §9 (<=8m). Cap to
glacier_grade.clamp(2,4) = 4-8m (still widens with glaciation, in-spec);
add fjord_wall_floor_width_in_spec test. (Hoshe #1)
- BraidedDelta circular-distance wrap was one-sided (edge threads invisible).
Fix to true modular distance: d.rem_euclid(64).min(64-d). (Tyre #1)
- BraidedDelta thread centres used correlated bit-slices of one u8 -> threads
could merge. Derive 3 centres via independent splitmix64 passes (distinct
salts) so separation holds across all phase values. Remove dead *64/64. (Tyre #2, Hoshe #4)
- Add N/S basin-direction guard asserts to the gorge + 2 fjord cross-section
tests (were passing by seed luck). (Hoshe #2)
- meander_reach_stronger_sinuosity test was a tautology (|| elev_q!=elev_q
always true). Rewrite: same elev_q, only morphology_zone differs, assert
wet-tile sets differ -> fails if MeanderReach regresses to AlluvialPlain. (Hoshe #3)
- Fix FjordWall moraine + DuneStrand comments. (Tyre #3/#4)
- Lead: fix manual RangeInclusive::contains in the new fjord test.
cargo test passes (1457 lib), clippy -D warnings clean, fmt clean.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-08 16:40:38 +02:00
..
2026-04-22 08:55:48 +02:00
2026-06-08 09:28:31 +02:00
2026-05-23 10:11:43 +02:00
2026-04-15 23:11:14 +02:00
2026-06-08 16:40:38 +02:00
2026-06-08 09:28:31 +02:00
2026-03-17 10:33:15 +01:00
2026-04-19 13:12:23 +02:00
2026-05-30 22:06:57 +02:00
2026-05-30 22:06:57 +02:00
2026-04-19 13:12:23 +02:00