jpmschweitzer/settled-reach
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(copy): triangle activation proximity monologue lines #84

Closed
jpmschweitzer wants to merge 0 commits from copy into main
pull from: copy
merge into: :main
Conversation 2 Commits - Files Changed -
jpmschweitzer commented 2026-03-05 09:08:04 +01:00
Owner
Copy Link
Copy Source

Summary

  • 4 smuggler monologue lines (Kael Davan, T1 hub-power anchor) — physical observation → rationalization → doubt → sensory confirmation
  • 5 detective monologue lines (Sera Venn/Torek Lintar, T2 informant-question anchor) — pattern recognition → deviation → hypothesis → inference → procedural next step
  • Schema update: triangle_activated situation enum value and npc_in_los prerequisite added to monologue-pool.schema.json

All lines: situation: [triangle_activated], trigger: observe_npc, cooldown: 9999, priority: 8, prerequisite: npc_in_los: true

Ticket

#597 — Triangle activation copy (blocks #593 playthrough proof)

Voice registers (D-090)

  • Smuggler: contracted, risk-reading, personal — noticing Kael through the lens of knowing him
  • Detective: uncontracted, institutional, evidence-cataloguing — Sera's behavior as anomalous data

Validation

  • check-fact-ids and check-decision-ids pass
  • make validate-content passes for new lines (11 pre-existing errors in other files)
## Summary - 4 smuggler monologue lines (Kael Davan, T1 hub-power anchor) — physical observation → rationalization → doubt → sensory confirmation - 5 detective monologue lines (Sera Venn/Torek Lintar, T2 informant-question anchor) — pattern recognition → deviation → hypothesis → inference → procedural next step - Schema update: `triangle_activated` situation enum value and `npc_in_los` prerequisite added to `monologue-pool.schema.json` All lines: `situation: [triangle_activated]`, `trigger: observe_npc`, `cooldown: 9999`, `priority: 8`, `prerequisite: npc_in_los: true` ## Ticket #597 — Triangle activation copy (blocks #593 playthrough proof) ## Voice registers (D-090) - **Smuggler:** contracted, risk-reading, personal — noticing Kael through the lens of knowing him - **Detective:** uncontracted, institutional, evidence-cataloguing — Sera's behavior as anomalous data ## Validation - `check-fact-ids` and `check-decision-ids` pass - `make validate-content` passes for new lines (11 pre-existing errors in other files)
jpmschweitzer added 2 commits 2026-03-05 09:08:04 +01:00
feat(copy): triangle activation proximity monologue lines (#597) 0472dcb86c 
Author 4 smuggler and 5 detective monologue lines that fire when
the player observes triangle anchor NPCs post-TriangleActivated.

Smuggler (Kael Davan): physical observation → rationalization →
doubt → sensory confirmation. Contracted, personal, friend-arc.

Detective (Sera Venn/Torek): pattern recognition → deviation →
hypothesis → inference → procedural next step. Analytical,
institutional, evidence-cataloguing.

All lines: situation: [triangle_activated], trigger: observe_npc,
cooldown: 9999, priority: 8, prerequisite: npc_in_los: true.

Schema updated: triangle_activated added to situation enum,
npc_in_los added to prerequisites in monologue-pool.schema.json.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
chore(meta): update changelog 46cfec4183 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jpmschweitzer commented 2026-03-05 09:13:41 +01:00
Author
Owner
Copy Link
Copy Source

Review: copy → main (PR #84, type: copy)

Hoshe (QA): REQUEST_CHANGES

Well-structured YAML, valid schema extension, consistent field ordering. Two factual errors need fixing.

# File Severity Issue
1 CHANGELOG.md:10 critical States "4 smuggler lines" — actual count is 5 (pc-smuggler_m_s_036–040)
2 smuggler/the-terminal.yaml:378–380 warning Comment lists 4 beats for 5 lines. Detective section correctly has 5 beats. Add a 5th beat label.
3 monologue-pool.schema.json:84 suggestion Situation description note mentions only greeting as missing from server enum — triangle_activated also not added yet. Extend the note.
4 CHANGELOG.md:10 suggestion D-039 is a scope decision (wow moments), not the monologue structural spec. Could cite D-035 too.

Paula (Narrative Depth): APPROVE

The smuggler sequence is the stronger of the two — clean emotional momentum, earns the devastating final line. The detective sequence is voice-consistent but the inference chain moves too fast.

# File Severity Issue
1 detective/the-terminal.yaml:041–045 warning Lines 043→044 leap from question to near-certainty too fast. The detective should register inference as inference, not conclusion.
2 detective/the-terminal.yaml:043 warning References "manifest discrepancy" but has no prerequisites.facts gate — line can fire before player discovers the manifest, breaking the inference chain. Add a fact prerequisite or rewrite to remove the implicit reference.
3 detective/the-terminal.yaml:041 suggestion If this fires after existing bay-four investigation lines, it reads as confirmation rather than anomaly-detection. Consider priority/prerequisite tuning.
4 smuggler/the-terminal.yaml:037 suggestion Rationalization beat may lose dramatic function if existing line 022 (Torek schedule anomaly) has already primed the player. Minor risk.
5 smuggler/the-terminal.yaml:040 suggestion "I don't know what I'm looking at" slightly abstract for body-first character voice. "what I'm seeing" might fit register better.
6 Both files suggestion Smuggler beat comment lists 4 beats for 5 lines (same as Hoshe's finding).

Miri (World Consistency): APPROVE

NPC roles, relationships, and locations are internally consistent with D-034, D-036, D-087. No franchise-derivative content. Original IP throughout.

# File Severity Issue
1 Both files — tags warning triangle-signal and tell-observation are freeform tags not in D-035 taxonomy. Should be registered to prevent future misspelling across files.
2 detective/the-terminal.yaml header suggestion Comment says "T2 informant-question" — D-087 uses "T2: Sera-Detective-Commission". Align to decision terminology.
3 detective/the-terminal.yaml:041 suggestion "Bay four bypass" is a new sub-location. Track it for setting consistency.
4 smuggler/the-terminal.yaml header suggestion Comment says "T1 hub-power" — D-087 uses "T1: Kael-Smuggler-Ring".

Verdict: CHANGES REQUESTED

Critical/warning issues to address:

  1. CHANGELOG line count (4 → 5 smuggler lines)
  2. Smuggler beat comment (4 → 5 beats)
  3. Detective lines 043–044: inference pacing too fast / missing fact prerequisite for manifest reference
  4. Register triangle-signal / tell-observation tags in D-035 or a tag registry
## Review: `copy` → `main` (PR #84, type: copy) ### Hoshe (QA): REQUEST_CHANGES Well-structured YAML, valid schema extension, consistent field ordering. Two factual errors need fixing. | # | File | Severity | Issue | |---|------|----------|-------| | 1 | `CHANGELOG.md:10` | critical | States "4 smuggler lines" — actual count is 5 (pc-smuggler_m_s_036–040) | | 2 | `smuggler/the-terminal.yaml:378–380` | warning | Comment lists 4 beats for 5 lines. Detective section correctly has 5 beats. Add a 5th beat label. | | 3 | `monologue-pool.schema.json:84` | suggestion | Situation description note mentions only `greeting` as missing from server enum — `triangle_activated` also not added yet. Extend the note. | | 4 | `CHANGELOG.md:10` | suggestion | D-039 is a scope decision (wow moments), not the monologue structural spec. Could cite D-035 too. | ### Paula (Narrative Depth): APPROVE The smuggler sequence is the stronger of the two — clean emotional momentum, earns the devastating final line. The detective sequence is voice-consistent but the inference chain moves too fast. | # | File | Severity | Issue | |---|------|----------|-------| | 1 | `detective/the-terminal.yaml:041–045` | warning | Lines 043→044 leap from question to near-certainty too fast. The detective should register inference *as* inference, not conclusion. | | 2 | `detective/the-terminal.yaml:043` | warning | References "manifest discrepancy" but has no `prerequisites.facts` gate — line can fire before player discovers the manifest, breaking the inference chain. Add a fact prerequisite or rewrite to remove the implicit reference. | | 3 | `detective/the-terminal.yaml:041` | suggestion | If this fires after existing bay-four investigation lines, it reads as confirmation rather than anomaly-detection. Consider priority/prerequisite tuning. | | 4 | `smuggler/the-terminal.yaml:037` | suggestion | Rationalization beat may lose dramatic function if existing line 022 (Torek schedule anomaly) has already primed the player. Minor risk. | | 5 | `smuggler/the-terminal.yaml:040` | suggestion | "I don't know what I'm looking at" slightly abstract for body-first character voice. "what I'm seeing" might fit register better. | | 6 | Both files | suggestion | Smuggler beat comment lists 4 beats for 5 lines (same as Hoshe's finding). | ### Miri (World Consistency): APPROVE NPC roles, relationships, and locations are internally consistent with D-034, D-036, D-087. No franchise-derivative content. Original IP throughout. | # | File | Severity | Issue | |---|------|----------|-------| | 1 | Both files — tags | warning | `triangle-signal` and `tell-observation` are freeform tags not in D-035 taxonomy. Should be registered to prevent future misspelling across files. | | 2 | `detective/the-terminal.yaml` header | suggestion | Comment says "T2 informant-question" — D-087 uses "T2: Sera-Detective-Commission". Align to decision terminology. | | 3 | `detective/the-terminal.yaml:041` | suggestion | "Bay four bypass" is a new sub-location. Track it for setting consistency. | | 4 | `smuggler/the-terminal.yaml` header | suggestion | Comment says "T1 hub-power" — D-087 uses "T1: Kael-Smuggler-Ring". | --- ### Verdict: CHANGES REQUESTED **Critical/warning issues to address:** 1. CHANGELOG line count (4 → 5 smuggler lines) 2. Smuggler beat comment (4 → 5 beats) 3. Detective lines 043–044: inference pacing too fast / missing fact prerequisite for manifest reference 4. Register `triangle-signal` / `tell-observation` tags in D-035 or a tag registry
jpmschweitzer added 1 commit 2026-03-05 10:56:57 +01:00
fix(copy): address PR #84 review — pacing, prerequisites, terminology 3a481b32a5 
Review fixes for triangle activation monologue lines:

- CHANGELOG: correct smuggler line count (4 → 5), add D-035 ref
- Smuggler comment: align beat labels to 5-line structure
- Smuggler 040: "looking at" → "seeing" for body-first register
- Detective 043: rewrite to remove implicit manifest knowledge
  reference — line now works without fact prerequisite gate
- Detective 044: soften from near-certainty to enumerated
  possibilities with "insufficient data" qualifier
- Triangle comments: align to D-087 terminology (T1: Kael-
  Smuggler-Ring, T2: Sera-Detective-Commission)
- Schema description: note triangle_activated also missing from
  server Situation enum alongside greeting
- D-035 amendment: register triangle-signal, tell-observation
  tags and npc_in_los prerequisite as conventions

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jpmschweitzer commented 2026-03-05 11:03:37 +01:00
Author
Owner
Copy Link
Copy Source

Re-review: copy → main (PR #84, round 2)

Hoshe (QA): APPROVE

All 4 round-1 issues confirmed resolved:

  1. ✅ CHANGELOG: "5 smuggler lines" (was 4)
  2. ✅ Smuggler beat comment: 5 beats labeled (was 4)
  3. ✅ Schema note: mentions both greeting and triangle_activated
  4. ✅ CHANGELOG cites both D-035 and D-039

One minor note: pc-smuggler_m_s_039 has both tell-observation and bare tell tags — slightly redundant but not blocking.

Paula (Narrative Depth): APPROVE

Rewritten detective lines 043–044 fix the pacing and prerequisite issues. The arc now moves through epistemological steps rather than collapsing into conclusion. Line 043 ("Avoidance without cause...") properly frames as conditional hypothesis. Line 044 ("Possible explanations: fear, loyalty, complicity. Insufficient data to distinguish.") holds inference open correctly. Smuggler line 040 register fix ("seeing" vs "looking at") strengthens body-first voice.

Miri (World Consistency): APPROVE

D-035 Sprint 24 amendment registered in decisions/content.md. Tags triangle-signal and tell-observation formally documented. Comment headers use D-087 terminology. All world references consistent.

Verdict: APPROVED ✅

All round-1 warnings addressed. Ready for merge.

## Re-review: `copy` → `main` (PR #84, round 2) ### Hoshe (QA): APPROVE All 4 round-1 issues confirmed resolved: 1. ✅ CHANGELOG: "5 smuggler lines" (was 4) 2. ✅ Smuggler beat comment: 5 beats labeled (was 4) 3. ✅ Schema note: mentions both `greeting` and `triangle_activated` 4. ✅ CHANGELOG cites both D-035 and D-039 One minor note: `pc-smuggler_m_s_039` has both `tell-observation` and bare `tell` tags — slightly redundant but not blocking. ### Paula (Narrative Depth): APPROVE Rewritten detective lines 043–044 fix the pacing and prerequisite issues. The arc now moves through epistemological steps rather than collapsing into conclusion. Line 043 ("Avoidance without cause...") properly frames as conditional hypothesis. Line 044 ("Possible explanations: fear, loyalty, complicity. Insufficient data to distinguish.") holds inference open correctly. Smuggler line 040 register fix ("seeing" vs "looking at") strengthens body-first voice. ### Miri (World Consistency): APPROVE D-035 Sprint 24 amendment registered in `decisions/content.md`. Tags `triangle-signal` and `tell-observation` formally documented. Comment headers use D-087 terminology. All world references consistent. ### Verdict: APPROVED ✅ All round-1 warnings addressed. Ready for merge.
jpmschweitzer closed this pull request 2026-03-05 11:05:48 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jpmschweitzer (Jeroen Schweitzer)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: jpmschweitzer/settled-reach#84