jpmschweitzer/settled-reach
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat(client): interaction prompt system + v4 protocol alignment #17

Closed
jpmschweitzer wants to merge 0 commits from client into main
pull from: client
merge into: :main
Conversation 1 Commits - Files Changed -
jpmschweitzer commented 2026-02-13 00:06:27 +01:00
Owner
Copy Link
Copy Source

Summary

  • Interaction prompt system (#405) — decodes v4 nearby_interactions from server snapshots, displays context-sensitive "E - Talk to [NPC]" prompt with fade animation, extensible get_interaction_target()/get_selected_verb() interface for future radial verb menu
  • v4 protocol alignment — all tests updated for strict PROTOCOL_VERSION enforcement, 1-indexed verb priorities, corrected ExamineNpc "Observe" label
  • E2E test resilience — player entity found by kind instead of array index, wall/corner proof tests check specific NPC positions to support server's 3-NPC proof room layout

Files changed

Area Files Change
Protocol protocol.gd Decode nearby_interactions from v4 snapshots
State game_state.gd Store nearby_interactions, tick_rate comment fix
SimBridge sim_bridge.gd Test mode generates interactions near NPCs, correct priorities/labels
UI interaction_prompt.gd, interaction_prompt.tscn New prompt component
Main main.gd, main.tscn Wire E key to interaction target
Tests test_interaction_prompt.gd 17 test cases for protocol, state, bridge, UI, encoding
Tests test_protocol.gd, test_local_bridge.gd Version enforcement alignment
Tests test_e2e_connection.gd, test_sprint2_proof.gd Entity ordering resilience

Test plan

  • 112/112 tests passing (0 errors, 0 failures)
  • E2E tests pass against freshly built server binary
  • Sprint 2 proof tests (wall-hides, corner-reveal) pass with 3-NPC proof room
  • Visual test: walk to NPC in test mode, verify prompt appears/fades

🤖 Generated with Claude Code

## Summary - **Interaction prompt system (#405)** — decodes v4 `nearby_interactions` from server snapshots, displays context-sensitive "E - Talk to [NPC]" prompt with fade animation, extensible `get_interaction_target()`/`get_selected_verb()` interface for future radial verb menu - **v4 protocol alignment** — all tests updated for strict PROTOCOL_VERSION enforcement, 1-indexed verb priorities, corrected ExamineNpc "Observe" label - **E2E test resilience** — player entity found by kind instead of array index, wall/corner proof tests check specific NPC positions to support server's 3-NPC proof room layout ## Files changed | Area | Files | Change | |------|-------|--------| | Protocol | `protocol.gd` | Decode `nearby_interactions` from v4 snapshots | | State | `game_state.gd` | Store `nearby_interactions`, tick_rate comment fix | | SimBridge | `sim_bridge.gd` | Test mode generates interactions near NPCs, correct priorities/labels | | UI | `interaction_prompt.gd`, `interaction_prompt.tscn` | New prompt component | | Main | `main.gd`, `main.tscn` | Wire E key to interaction target | | Tests | `test_interaction_prompt.gd` | 17 test cases for protocol, state, bridge, UI, encoding | | Tests | `test_protocol.gd`, `test_local_bridge.gd` | Version enforcement alignment | | Tests | `test_e2e_connection.gd`, `test_sprint2_proof.gd` | Entity ordering resilience | ## Test plan - [x] 112/112 tests passing (0 errors, 0 failures) - [x] E2E tests pass against freshly built server binary - [x] Sprint 2 proof tests (wall-hides, corner-reveal) pass with 3-NPC proof room - [ ] Visual test: walk to NPC in test mode, verify prompt appears/fades 🤖 Generated with [Claude Code](https://claude.com/claude-code)
jpmschweitzer added 6 commits 2026-02-13 00:06:27 +01:00
feat(client): add interaction prompt system (#405) 6bebbd9933 
Server-driven interaction prompt that displays "E - Talk" when near
an interactable NPC. Decodes v4 nearby_interactions from snapshot,
stores in GameState, renders via InteractionPrompt UI with fade
animation. Extensible interface (get_interaction_target/get_selected_verb)
for future radial verb menu (v0.2).

- Protocol: decode nearby_interactions array with nested VerbOption structs,
  entity relationship/observation fields, tick_rate in GameTime
- GameState: store/clear nearby_interactions per snapshot
- SimBridge: test mode generates v4 format with structured verbs
- InteractionPrompt: PanelContainer with fade in/out, polls GameState
- Tests: 19 new test cases covering protocol, state, sim bridge, UI, encoding
- Fixture assertions updated for v4 protocol version

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
chore(meta): update changelog 5d94363d48 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Merge remote-tracking branch 'origin/main' into client 7af8de0117 
# Conflicts:
#	CHANGELOG.md
#	client/scripts/autoloads/sim_bridge.gd
fix(client): align tests and data with server v4 protocol changes 52972e6f21 
Server team shipped strict PROTOCOL_VERSION enforcement (c05ff7b),
1-indexed verb priorities, and "Observe" label for ExamineNpc.
Updates all test snapshots to include version: 4, fixes sim_bridge
test mode priorities (0-indexed → 1-indexed) and labels, replaces
v1 backward-compat tests with strict version rejection tests.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
fix(client): make E2E tests resilient to entity ordering a1c5db9490 
Server proof room now has 3 NPCs instead of 1. Find player entity
by kind instead of assuming entities[0]. Wall-hides test checks
specific NPC position (16.5, 13.5) rather than asserting zero NPC
count. Corner-reveal test searches for NPC1 by position.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
chore(meta): update changelog 8117f775c5 
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
jpmschweitzer commented 2026-02-13 00:10:00 +01:00
Author
Owner
Copy Link
Copy Source

Review: client -> main (type: code)

PR #17: feat(client): interaction prompt system + v4 protocol alignment

Hoshe (Code Quality): APPROVE

Summary: Clean interaction prompt system with proper separation of concerns (display-only UI, server-driven data). Protocol v4 alignment is correctly enforced across all tests. Comprehensive test coverage (24 new tests) with no critical issues.

# File Severity Issue
1 interaction_prompt.gd:25-29 warning Empty-check inconsistency: _process checks interactions.size() > 0 but _show_prompt re-checks verbs.is_empty(). Not a bug (nested catch works), but consolidating the logic would be cleaner.
2 protocol.gd:162-169 suggestion Dropped interactions (malformed decode) are silently discarded — no decode_warnings counter like entities have. Consider debug logging for dropped interactions.
3 sim_bridge.gd:237-248 suggestion Test interaction range npc_dist <= 2 is a magic number. Extract to named constant TEST_INTERACTION_RANGE.
4 main.gd:32-39 suggestion TODO for Interact(InteractData) has no ticket reference. Add ticket # for tracking.

Tyre (Architecture): APPROVE

Summary: Architecture is sound: server-driven interaction data flows through protocol layer into GameState, UI reads reactively, input encoding is ready for future extension. Respects D-010 (information boundaries), D-020 (client-server separation), and D-030 (testability). The TODO in main.gd correctly defers server integration until the Rust side is ready.

# File Severity Issue
1 game_state.gd:24 warning nearby_interactions field not documented as "v4+ field" like game_time and player_facing are documented as "v2 fields". Add version comment for consistency.
2 protocol.gd:104-105 suggestion _decode_nearby_interaction drops zero-verb interactions silently. Add push_warning before returning null for debugging visibility.
3 test_protocol.gd suggestion Consider adding test_decode_snapshot_rejects_version_wrong_type (version as String "4" instead of int 4) for belt-and-suspenders validation.
4 test_interaction_prompt.gd:65 suggestion test_prompt_get_selected_verb_returns_first_kind is v0.1-specific — add comment noting radial menu (v0.2) will change selection logic.
5 test_e2e_connection.gd:119-126 suggestion "Find player by kind" pattern now appears in multiple test files. Consider extracting to test utility helper.

Verdict: APPROVED

Both reviewers approve. Solid implementation — server-driven interaction prompt with proper v4 protocol enforcement, 24 new tests, entity ordering resilience fix. All comments are minor suggestions.

## Review: client -> main (type: code) PR #17: feat(client): interaction prompt system + v4 protocol alignment --- ### Hoshe (Code Quality): APPROVE **Summary:** Clean interaction prompt system with proper separation of concerns (display-only UI, server-driven data). Protocol v4 alignment is correctly enforced across all tests. Comprehensive test coverage (24 new tests) with no critical issues. | # | File | Severity | Issue | |---|------|----------|-------| | 1 | interaction_prompt.gd:25-29 | warning | Empty-check inconsistency: `_process` checks `interactions.size() > 0` but `_show_prompt` re-checks `verbs.is_empty()`. Not a bug (nested catch works), but consolidating the logic would be cleaner. | | 2 | protocol.gd:162-169 | suggestion | Dropped interactions (malformed decode) are silently discarded — no `decode_warnings` counter like entities have. Consider debug logging for dropped interactions. | | 3 | sim_bridge.gd:237-248 | suggestion | Test interaction range `npc_dist <= 2` is a magic number. Extract to named constant `TEST_INTERACTION_RANGE`. | | 4 | main.gd:32-39 | suggestion | TODO for Interact(InteractData) has no ticket reference. Add ticket # for tracking. | --- ### Tyre (Architecture): APPROVE **Summary:** Architecture is sound: server-driven interaction data flows through protocol layer into GameState, UI reads reactively, input encoding is ready for future extension. Respects D-010 (information boundaries), D-020 (client-server separation), and D-030 (testability). The TODO in main.gd correctly defers server integration until the Rust side is ready. | # | File | Severity | Issue | |---|------|----------|-------| | 1 | game_state.gd:24 | warning | `nearby_interactions` field not documented as "v4+ field" like `game_time` and `player_facing` are documented as "v2 fields". Add version comment for consistency. | | 2 | protocol.gd:104-105 | suggestion | `_decode_nearby_interaction` drops zero-verb interactions silently. Add `push_warning` before returning null for debugging visibility. | | 3 | test_protocol.gd | suggestion | Consider adding `test_decode_snapshot_rejects_version_wrong_type` (version as String "4" instead of int 4) for belt-and-suspenders validation. | | 4 | test_interaction_prompt.gd:65 | suggestion | `test_prompt_get_selected_verb_returns_first_kind` is v0.1-specific — add comment noting radial menu (v0.2) will change selection logic. | | 5 | test_e2e_connection.gd:119-126 | suggestion | "Find player by kind" pattern now appears in multiple test files. Consider extracting to test utility helper. | --- ### Verdict: APPROVED Both reviewers approve. Solid implementation — server-driven interaction prompt with proper v4 protocol enforcement, 24 new tests, entity ordering resilience fix. All comments are minor suggestions.
jpmschweitzer closed this pull request 2026-02-13 00:10:49 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jpmschweitzer (Jeroen Schweitzer)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: jpmschweitzer/settled-reach#17