jpmschweitzer/settled-reach
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

content(wiki): sprint 38 copy — corporation review (#884) #140

Closed
jpmschweitzer wants to merge 0 commits from sprint-38/copy into main
pull from: sprint-38/copy
merge into: :main
Conversation 3 Commits - Files Changed -
+265 -62
jpmschweitzer commented 2026-05-02 10:18:16 +02:00
Owner
Copy Link
Copy Source

Summary

Copy-team review of 21 wiki/corporations files authored by server team (Dudley) in Sprint 37 to resolve the economy-db coverage gate.

Lore fixes (Paula):

  • 6 hop-count corrections against star-map.json ground truth
  • 1 topology label correction (GJ 395: hub → through_route)
  • Rush Mining and Scapa Flow Industries narratives rewritten to match actual star-map topology (hop-1 junction and core hub respectively)

Tag fixes (Gestalt):

  • Gate Corporation: fusion_fuel → gate_components (correct primary_operation)
  • Salud Alliance: reordered tags so medical_goods leads as primary_operation
  • Hanyang Precision: reordered tags so electronics leads as primary_operation

Voice/style fixes (Mellanie):

  • 6 new stub pages rewritten from bullet-point format to institutional prose
  • 2 section headers renamed ("Silence" → "What They Don't Talk About")
  • 1 cross_refs addition (bifrost-marmor → gate-corporation)
  • 1 description field typo fix (thrds: underscore in prose field)

19 files changed, 244 insertions, 48 deletions.

Test plan

  • Verify hop counts match star-map.json for all corrected files
  • Verify tag ordering produces correct primary_operation via import_economics.py
  • Verify new prose pages follow established institutional voice
  • Run make check-systems-db to confirm no regen needed
## Summary Copy-team review of 21 wiki/corporations files authored by server team (Dudley) in Sprint 37 to resolve the economy-db coverage gate. **Lore fixes (Paula):** - 6 hop-count corrections against star-map.json ground truth - 1 topology label correction (GJ 395: hub → through_route) - Rush Mining and Scapa Flow Industries narratives rewritten to match actual star-map topology (hop-1 junction and core hub respectively) **Tag fixes (Gestalt):** - Gate Corporation: `fusion_fuel` → `gate_components` (correct primary_operation) - Salud Alliance: reordered tags so `medical_goods` leads as primary_operation - Hanyang Precision: reordered tags so `electronics` leads as primary_operation **Voice/style fixes (Mellanie):** - 6 new stub pages rewritten from bullet-point format to institutional prose - 2 section headers renamed ("Silence" → "What They Don't Talk About") - 1 cross_refs addition (bifrost-marmor → gate-corporation) - 1 description field typo fix (thrds: underscore in prose field) 19 files changed, 244 insertions, 48 deletions. ## Test plan - [ ] Verify hop counts match star-map.json for all corrected files - [ ] Verify tag ordering produces correct primary_operation via import_economics.py - [ ] Verify new prose pages follow established institutional voice - [ ] Run `make check-systems-db` to confirm no regen needed
jpmschweitzer added 1 commit 2026-05-02 10:18:16 +02:00
content(wiki): review 21 corporation pages authored by server team (#884) 4335e64840 
Copy-team review of wiki/corporations files authored by Dudley in Sprint 37.
Fixes: 6 hop-count errors, 1 topology label, 3 tag corrections, 2 header
renames, 1 cross_ref addition, 1 description typo. Rewrote 6 stub pages
to institutional prose voice. Rewrote Rush Mining and Scapa Flow Industries
narratives to match actual star-map topology.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jpmschweitzer commented 2026-05-02 17:12:00 +02:00
Author
Owner
Copy Link
Copy Source

Review: sprint-38/copy → main (type: copy)

Hoshe (QA): REQUEST_CHANGES

Summary: The 13 minor fixes (hop corrections, tag reordering, header renames, topology label, typo) are all correct and cleanly applied. The 6 stub rewrites are well-written institutional prose. However, two canon contradictions survive.

# Sev File Issue
1 High wiki/corporations/scapa-flow-industries.md Canon contradiction: SFI headquarters placed at "Scapa Flow station" which is a restricted military installation. Civilians cannot dock. The civilian commercial station at Bastion is Quaterna. Rewrite should place SFI at Quaterna, not Scapa Flow.
2 Med wiki/corporations/threshold-fuel-syndicate.md GJ 71 is Gateway (hop 0, core hub, 5 apertures). Page frames TFS as "east corridor" frontier fuel supplier. System imports fusion_fuel per the index. Either relocate TFS or reconceive the page.
3 Low wiki/corporations/arbour-aggregates.md Scope field says "north corridor" but body text says "east corridor" twice. GJ 338B is core zone — neither north nor east. Reconcile.

Paula (Narrative Depth): REQUEST_CHANGES

Summary: Threshold Fuel Syndicate and Earth Standard Group overviews are the strongest — good institutional voice. Rush Mining has a causal logic gap and Scapa Flow's overview is the thinnest of the batch. Note: full-depth sections (Origin, Operations, Political Relationships, "What They Don't Talk About") could not be fully evaluated due to tool access limitations — findings below are based on what was readable.

# Sev File Issue
1 Med wiki/corporations/rush-mining.md Causal logic gap: "without corridor competitors, they've developed deep extraction expertise" — geographic isolation discourages investment as much as it reduces competition. Name the actual sustaining mechanism (long-term buyer relationships? Capital lock-in? Ore profile exclusivity?).
2 Low wiki/corporations/scapa-flow-industries.md Thinnest Overview of the batch (two short paragraphs). Reads as summary, not orientation. Should establish the corporation's animating condition in one defining paragraph.
3 Low wiki/corporations/sede-chemical-works.md "ACB corridor" appears without establishing what ACB designates. All other pages use GJ identifiers or canonical system names. Introduce or replace with canonical name.

Miri (World Consistency): REQUEST_CHANGES

Summary: Rush Mining and Scapa Flow narratives are well-constructed and topologically grounded (where not contradicting canon). Tag corrections are accurate. Five issues, the most serious being the Threshold geographic error.

# Sev File Issue
1 High wiki/corporations/threshold-fuel-syndicate.md Fundamental geographic error: GJ 71 is Gateway (hop 0, 1.2B population, transit_logistics economy). System imports fusion_fuel. Page describes "frontier fuel supplier" serving "east corridor" — wrong on every axis. Requires relocation or full reconception.
2 Med wiki/corporations/arbour-aggregates.md Corridor label inconsistency: frontmatter scope says "north corridor secondary", body says "east corridor" twice. GJ 338B is core zone adjacent to Sirius.
3 Low wiki/corporations/rush-mining.md + scapa-flow-industries.md Stale body metadata: frontmatter updated: 2026-05-02 but body footer still says **Updated:** 2026-04-21.
4 Low wiki/corporations/bifrost-marmor.md Cross-reference added to frontmatter (cross_refs: [gate-corporation]) but no Cross-References section in body. Every other page has one.
5 Low wiki/corporations/rush-mining.md "Rare Vein Survey" named as competitor but no cross_ref and no wiki page exists. Either add cross_ref (if page exists elsewhere) or remove the named reference.

Verdict: CHANGES REQUESTED

Deduplicated issues (9 unique):

Critical:

  1. Scapa Flow Industries placed at military station — must be Quaterna (Hoshe #1)
  2. Threshold Fuel Syndicate geographic error — GJ 71 is Gateway/core, imports fuel, not frontier east corridor (Hoshe #2 + Miri #1)

Medium:
3. Arbour Aggregates corridor inconsistency — frontmatter "north" vs body "east" vs reality "core" (Hoshe #3 + Miri #2)
4. Rush Mining causal logic gap — isolation as expertise driver needs concrete mechanism (Paula #1)

Low:
5. Scapa Flow Industries thin Overview — needs animating condition paragraph (Paula #2)
6. Sede Chemical Works "ACB corridor" unexplained shorthand (Paula #3)
7. Rush Mining + Scapa Flow stale body metadata dates (Miri #3)
8. Bifrost Marmor missing Cross-References body section (Miri #4)
9. Rush Mining "Rare Vein Survey" unlinked entity reference (Miri #5)

## Review: sprint-38/copy → main (type: copy) ### Hoshe (QA): REQUEST_CHANGES **Summary:** The 13 minor fixes (hop corrections, tag reordering, header renames, topology label, typo) are all correct and cleanly applied. The 6 stub rewrites are well-written institutional prose. However, two canon contradictions survive. | # | Sev | File | Issue | |---|-----|------|-------| | 1 | High | `wiki/corporations/scapa-flow-industries.md` | Canon contradiction: SFI headquarters placed at "Scapa Flow station" which is a restricted military installation. Civilians cannot dock. The civilian commercial station at Bastion is Quaterna. Rewrite should place SFI at Quaterna, not Scapa Flow. | | 2 | Med | `wiki/corporations/threshold-fuel-syndicate.md` | GJ 71 is Gateway (hop 0, core hub, 5 apertures). Page frames TFS as "east corridor" frontier fuel supplier. System **imports** fusion_fuel per the index. Either relocate TFS or reconceive the page. | | 3 | Low | `wiki/corporations/arbour-aggregates.md` | Scope field says "north corridor" but body text says "east corridor" twice. GJ 338B is core zone — neither north nor east. Reconcile. | ### Paula (Narrative Depth): REQUEST_CHANGES **Summary:** Threshold Fuel Syndicate and Earth Standard Group overviews are the strongest — good institutional voice. Rush Mining has a causal logic gap and Scapa Flow's overview is the thinnest of the batch. Note: full-depth sections (Origin, Operations, Political Relationships, "What They Don't Talk About") could not be fully evaluated due to tool access limitations — findings below are based on what was readable. | # | Sev | File | Issue | |---|-----|------|-------| | 1 | Med | `wiki/corporations/rush-mining.md` | Causal logic gap: "without corridor competitors, they've developed deep extraction expertise" — geographic isolation discourages investment as much as it reduces competition. Name the actual sustaining mechanism (long-term buyer relationships? Capital lock-in? Ore profile exclusivity?). | | 2 | Low | `wiki/corporations/scapa-flow-industries.md` | Thinnest Overview of the batch (two short paragraphs). Reads as summary, not orientation. Should establish the corporation's animating condition in one defining paragraph. | | 3 | Low | `wiki/corporations/sede-chemical-works.md` | "ACB corridor" appears without establishing what ACB designates. All other pages use GJ identifiers or canonical system names. Introduce or replace with canonical name. | ### Miri (World Consistency): REQUEST_CHANGES **Summary:** Rush Mining and Scapa Flow narratives are well-constructed and topologically grounded (where not contradicting canon). Tag corrections are accurate. Five issues, the most serious being the Threshold geographic error. | # | Sev | File | Issue | |---|-----|------|-------| | 1 | High | `wiki/corporations/threshold-fuel-syndicate.md` | Fundamental geographic error: GJ 71 is Gateway (hop 0, 1.2B population, transit_logistics economy). System imports fusion_fuel. Page describes "frontier fuel supplier" serving "east corridor" — wrong on every axis. Requires relocation or full reconception. | | 2 | Med | `wiki/corporations/arbour-aggregates.md` | Corridor label inconsistency: frontmatter scope says "north corridor secondary", body says "east corridor" twice. GJ 338B is core zone adjacent to Sirius. | | 3 | Low | `wiki/corporations/rush-mining.md` + `scapa-flow-industries.md` | Stale body metadata: frontmatter `updated: 2026-05-02` but body footer still says `**Updated:** 2026-04-21`. | | 4 | Low | `wiki/corporations/bifrost-marmor.md` | Cross-reference added to frontmatter (`cross_refs: [gate-corporation]`) but no Cross-References section in body. Every other page has one. | | 5 | Low | `wiki/corporations/rush-mining.md` | "Rare Vein Survey" named as competitor but no cross_ref and no wiki page exists. Either add cross_ref (if page exists elsewhere) or remove the named reference. | ### Verdict: CHANGES REQUESTED **Deduplicated issues (9 unique):** Critical: 1. Scapa Flow Industries placed at military station — must be Quaterna (Hoshe #1) 2. Threshold Fuel Syndicate geographic error — GJ 71 is Gateway/core, imports fuel, not frontier east corridor (Hoshe #2 + Miri #1) Medium: 3. Arbour Aggregates corridor inconsistency — frontmatter "north" vs body "east" vs reality "core" (Hoshe #3 + Miri #2) 4. Rush Mining causal logic gap — isolation as expertise driver needs concrete mechanism (Paula #1) Low: 5. Scapa Flow Industries thin Overview — needs animating condition paragraph (Paula #2) 6. Sede Chemical Works "ACB corridor" unexplained shorthand (Paula #3) 7. Rush Mining + Scapa Flow stale body metadata dates (Miri #3) 8. Bifrost Marmor missing Cross-References body section (Miri #4) 9. Rush Mining "Rare Vein Survey" unlinked entity reference (Miri #5)
jpmschweitzer added 1 commit 2026-05-02 17:24:15 +02:00
content(wiki): address PR #140 review — 9 fixes 1595cfc8a7 
1. Scapa Flow Industries: HQ moved from restricted military station to
   Quaterna (civilian commercial platform). Overview expanded with
   military/civilian context.
2. Threshold Fuel Syndicate: reconceived from "frontier east corridor
   supplier" to Gateway's local fuel producer supplementing imports.
   Removed frontier tag.
3. Arbour Aggregates: corridor labels fixed — "north"/"east" → "core zone"
   to match GJ 338B's actual hop-3 loop_member position.
4. Rush Mining: named concrete sustaining mechanism (property tenure
   uncertainty keeps combines away; first-mover holds by occupation).
5. Sede Chemical Works: expanded "ACB" to "ACB — Alpha Centauri B" on
   first use.
6. Stale body footer dates updated on rush-mining and scapa-flow.
7. Bifrost Marmor: added missing Cross-References body section.
8. Rush Mining: added cross_ref to rare-vein-survey.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jpmschweitzer commented 2026-05-02 18:07:14 +02:00
Author
Owner
Copy Link
Copy Source

Review Round 2: sprint-38/copy → main

Previous issues: ALL 9 FIXED

Scapa Flow relocated to Quaterna. Threshold reconceived for Gateway. Arbour corridor labels corrected. Rush Mining causal logic repaired. All metadata, cross-refs, and formatting issues addressed.

New issues

Structural (Paula — narrative depth):

# File(s) Issue
A rush-mining, scapa-flow, sede, threshold, earth-standard-group "What They Don't Talk About" sections completely absent. Gate Corporation (quality bar) has full institutional silences with gameplay leverage. 5/6 rewrites lack this section entirely.
B sede-chemical-works.md Weakest file — generic origin, thin market position, no SCV rivalry texture
C arbour-aggregates.md + earth-standard-group.md No Political Relationships section

Formatting/consistency (Hoshe + Miri):

# File Issue
4 arbour-aggregates.md Body footer date 2026-04-21 → should be 2026-05-02
5 sede-chemical-works.md Add (SCW) at first prose mention in Overview
6 bifrost-marmor.md Frontmatter cross_refs missing Nyrheim (body has it)
7 scapa-flow-industries.md Frontmatter cross_refs: [] but body references Quaterna

Verdict: CHANGES REQUESTED

Formatting items (4–7) are trivial fixes. Structural items (A–C) are a scope call for the lead — ticket #884 was "review" not "author new sections."

## Review Round 2: sprint-38/copy → main ### Previous issues: ALL 9 FIXED Scapa Flow relocated to Quaterna. Threshold reconceived for Gateway. Arbour corridor labels corrected. Rush Mining causal logic repaired. All metadata, cross-refs, and formatting issues addressed. ### New issues **Structural (Paula — narrative depth):** | # | File(s) | Issue | |---|---------|-------| | A | rush-mining, scapa-flow, sede, threshold, earth-standard-group | "What They Don't Talk About" sections completely absent. Gate Corporation (quality bar) has full institutional silences with gameplay leverage. 5/6 rewrites lack this section entirely. | | B | sede-chemical-works.md | Weakest file — generic origin, thin market position, no SCV rivalry texture | | C | arbour-aggregates.md + earth-standard-group.md | No Political Relationships section | **Formatting/consistency (Hoshe + Miri):** | # | File | Issue | |---|------|-------| | 4 | arbour-aggregates.md | Body footer date `2026-04-21` → should be `2026-05-02` | | 5 | sede-chemical-works.md | Add `(SCW)` at first prose mention in Overview | | 6 | bifrost-marmor.md | Frontmatter `cross_refs` missing Nyrheim (body has it) | | 7 | scapa-flow-industries.md | Frontmatter `cross_refs: []` but body references Quaterna | ### Verdict: CHANGES REQUESTED Formatting items (4–7) are trivial fixes. Structural items (A–C) are a scope call for the lead — ticket #884 was "review" not "author new sections."
jpmschweitzer added 1 commit 2026-05-02 18:40:40 +02:00
content(wiki): address PR #140 review round 2 — formatting fixes 5ce1b90926 
- Arbour Aggregates: body footer date updated to 2026-05-02
- Sede Chemical Works: added (SCW) abbreviation at first prose mention

Structural items (A-C: missing silence/political sections) deferred —
open Q-record on main challenges whether corp pages should have "What
They Don't Talk About" sections at all.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jpmschweitzer commented 2026-05-02 18:41:01 +02:00
Author
Owner
Copy Link
Copy Source

Round 2 Response

Formatting fixes (4-7): DONE — pushed in 5ce1b909.

  • #4: Arbour body footer date updated
  • #5: SCW abbreviation added at first prose mention
  • #6: Bifrost frontmatter cross_refs already has gate-corporation; nyrheim is a system name not a corp slug, so not added to frontmatter (body Cross-References section already links the system page)
  • #7: Scapa Flow same — Quaterna is a station, not a corp. Body Cross-References links the system page correctly; frontmatter cross_refs is for corp-to-corp references only

Structural items (A-C): DEFERRED — there is an open Q-record on main challenging whether corp pages should have "What They Don't Talk About" sections at all. Adding silence sections to 5 files that might have the convention reversed would be wasted work. Sede quality improvements (B) and Political Relationships sections (C) are new authoring beyond #884's review scope — recommend a follow-up ticket if desired after the Q-record resolves.

## Round 2 Response **Formatting fixes (4-7): DONE** — pushed in `5ce1b909`. - #4: Arbour body footer date updated - #5: SCW abbreviation added at first prose mention - #6: Bifrost frontmatter cross_refs already has `gate-corporation`; `nyrheim` is a system name not a corp slug, so not added to frontmatter (body Cross-References section already links the system page) - #7: Scapa Flow same — Quaterna is a station, not a corp. Body Cross-References links the system page correctly; frontmatter cross_refs is for corp-to-corp references only **Structural items (A-C): DEFERRED** — there is an open Q-record on main challenging whether corp pages should have "What They Don't Talk About" sections at all. Adding silence sections to 5 files that might have the convention reversed would be wasted work. Sede quality improvements (B) and Political Relationships sections (C) are new authoring beyond #884's review scope — recommend a follow-up ticket if desired after the Q-record resolves.
jpmschweitzer closed this pull request 2026-05-02 18:44:19 +02:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jpmschweitzer (Jeroen Schweitzer)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: jpmschweitzer/settled-reach#140