content(atlas): sprint 36 — atlas refinement and brand corps #133
Assignees
jpmschweitzer (Jeroen Schweitzer)
Clear assignees
jpmschweitzer (Jeroen Schweitzer)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: jpmschweitzer/settled-reach#133
Reference in New Issue
Block a user
Summary
Sprint 36 copy team — closes Phase 3 atlas (refinement + brand layer), establishes Phase 4 foundations via the shared infrastructure.
atlas_cohesion_audit.py+sol_name_fixes.pytooling added.wiki/economics/corporations/brands.tomlacross all 8 D-189 categories (terroir / heritage_craft / tech_premium / cultural / service_premium / commodity_branded / design_heritage / platform_catalogue). 248 brand_products entries total. 112 new wiki corp stub pages (minimal frontmatter — full three-layer authoring tracked separately in #861). Brand layer validation V-B01..V-B06 passes. D-189 §5 amended with lockedprice_tierenum:mass/premium/luxury/flagship/institutional.Also in this PR:
/sprint-startskill lifecycle update (team stays alive through review AND merge, not just approval).Audit metrics (#849)
Known deferred issues (tracked, not blocking merge)
Follow-up tickets filed
Files
333 files changed, +14,055 / -718. Full systematic-issue notes in
docs/design/atlas-generator-refinement-notes.mdand per-body log intooling/planet-gen/refine_log_849.md.Test plan
make economy-dbbuilds brand_products table fromwiki/economics/corporations/brands.toml(coverage gate still fails on #860 items — pre-existing, not introduced here)python3 tooling/planet-gen/generate_atlas.py --body <id>round-trips markers.json ↔ atlas_* tables cleanly🤖 Generated with Claude Code
Continues the core-world cohesion pass. All markers.json edits synced to atlas_* tables. apply_name_fixes.py extended with all new fix tables. GJ244Ad Edict (400M pop): 5 fixes — 2 lazy mountain names replaced with Edict-vocabulary terms ("The Statute", "Charter Spur"); 3 cardinal oceans replaced with cross-referential names (Veil Shelf → Veil Institute POI, Concord Mere → Concord Assembly Archive POI, Charter Tarn → Charter Spur mountain). Note: "Westwall" flagged by Gestalt not found in markers.json or DB; stale data issue. Arcs established: Charter-, Concord-, Veil-. GJ380c Lendel (900M pop): 2 fixes — "Pale Run" river renamed "Durneth Beck" (cross-refs Durneth Range; "beck" = British stream); "Tember Ridge" renamed "Tember Spine" (keeps stem, removes lazy Ridge suffix). Aldren- stem arc (capital + river + exchange) is intentional — preserved. GJ699b Verada (1.9B pop): 8 fixes — all 3 rivers renamed from civic-grid names to geographic names (Verada Reach, The Meridian, Capitol Beck); 5 oceans renamed to replace architectural/district suffixes with geographic ones (Prospect Sea, Haven Sea, Meridian Sound, Capitol Mere, Sterling Pool). Arcs: Capitol- (city + river + ocean), Meridian- (river + ocean), Haven/Port- (city + ocean). GJ699b-1 Verada moon: 8 fixes — all 8 mountains renamed from street addresses (Grandview Avenue, Harmony Boulevard, Beacon Street, etc.) to geological/institutional cross-references. The moon's peaks now carry the names of Verada's civic institutions as seen from orbit: Tribunal Spur, Zenith Spine, Keystone Scarp, Ironwood Spur, Consulate Scarp, Prefecture Spur, Barnard Heights, Verada Scarp (largest range). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>Review:
sprint-36/copy→ main (type: copy)Pre-review checks:
Hoshe (QA / data integrity): REQUEST_CHANGES
Brands structurally solid (D-189 coverage complete, FK integrity passes, 112 wiki stubs match corp_ids one-to-one,
make economy-dbdemonstrably run). Butprice_tier— documented in D-189 §5 as a locked enum field — is entirely absent from the DB schema, importer, and validator. The field gets authored into TOML and silently discarded. Five smaller issues.Paula (narrative depth): REQUEST_CHANGES
Atlas hand-refine work is good: internal cross-reference arcs intentional, cardinal labels gone, Earth/Luna selections carry real weight. But the 112 new corp wiki stubs are all 24-line frontmatter-only placeholders ("X is a Y operating out of Z. Details to be expanded.") in a codebase whose canonical stubs (Calloway, Thrds, VGV, Thalassa) run 95–125 lines with origin histories, political relationships, and concealed facts. Either populate to the three-layer minimum or split the PR.
Miri (worldbuilding): REQUEST_CHANGES (with retractions — see below)
Substantive setting-level concerns on Earth's selection logic and Groombridge's monocultural texture stand. Several other comments were based on stale reads and have been verified against the branch and retracted.
Consolidated comments
wiki/economics/corporations/brands.toml+tooling/economy-db/import_economics.py:55-110, 795-801price_tierdocumented in D-189 §5 as locked enum (mass/premium/luxury/flagship/institutional), present in 240/248 TOML entries, absent from schema, INSERT, and V-B06 enum_checks. Silently discarded on import. Either addprice_tier TEXT+ V-B06 entry, or strip from TOML and mark D-189 §5 as Phase 3+ authoring stub.wiki/corporations/*.md(all 112 new stubs)wiki/economics/corporations/brands.toml(Calloway, VGV, Thrds, Bífröst + run of pre-Sato entries)price_tierentirely. Will become V-B06 gap once field lands in schema. Fix now.decisions/economics.md:340(amended Sprint 36 … locked on sprint-36/copy branch)rather than standard**Amendment (YYYY-MM-DD):**block (see D-019/D-091/D-191). Branch-scoped language becomes factually wrong on merge. Reformat.tooling/planet-gen/sol_name_fixes.py:47-48range_606andrange_570assigned"Montes Riphaeus".range_606absent in current markers.json so the duplicate didn't fire, but re-import will silently produce a Luna duplicate. Add dedup guard or remove the redundant entry.tooling/planet-gen/sol_markers/earth_features.jsonwiki/star-systems/GJ-380/bodies/GJ380c/markers.jsonwiki/star-systems/GJ-251/bodies/GJ251c/markers.json+wiki/star-systems/GJ-71/bodies/GJ71c/markers.jsondocs/design/atlas-generator-refinement-notes.mdtooling/planet-gen/sol_name_fixes.py,tooling/generate_corp_stubs.py--help/--dry-run.apply_name_fixes.pyhas--dry-run; these don't. A file-rewriting tool without a dry-run is a footgun.wiki/corporations/{calloway-distillery,thrds,vins-de-grand-vide,thalassa-resort-group}.mdcross_refs: []despite body text explicitly cross-referencing each other (Thrds→Calloway; Calloway/VGV→untraced holding structure). Populatecross_refsto match assertions in prose.docs/atlas/hand-refine-log.md+tooling/planet-gen/refine_log_849.mdRetractions (reviewer comments verified as stale against branch)
atlas-generator-refinement-notes.mdmissingVerdict: CHANGES REQUESTED
2 blockers, 6 issues, 4 nits. Blockers are fundamentally about
price_tierdiscipline and stub narrative depth; everything else is concrete pass-before-merge work.Please address each (or push back with a concrete technical rationale per the review-disagreement protocol).
Review:
sprint-36/copy→ main (round 2)Round 1 recap: 2 blockers, 6 issues, 4 nits, 7 retractions.
Team response: 4 commits, 9 items resolved, 1 blocker (112-stub narrative depth) split to ticket #861 under reviewer-accepted protocol.
Hoshe (QA): APPROVE
All 9 Hoshe-relevant items correctly resolved.
price_tierpresent in schema / INSERT (16 columns, 16 placeholders) / V-B06 enum validation (mandatory on everymake economy-db). Column migration is idempotent (_add_columncatches duplicate-column errors). D-189 §5 amendment uses standard**Amendment (2026-04-19):**format, no branch-scoped language. Dedup guard onsol_name_fixes.py. argparse/--dry-runon both scripts. PR description updated (248 + deferred-issues section). Ticket #861 DoD matches split conditions.Paula (narrative depth): APPROVE
All 4 Paula-relevant items resolved. Canonical stub cross_refs populated honestly (no stuffing, no omissions). Logs cross-reference each other. Aethelred lore migration is "the strongest narrative addition in this diff" — the inference chain from Threshold's all-Latin rivers to Renaissance's "Aethelred's Gate" POI is genuine systems-emergent lore. Brussels-for-London swap is defensible given the documented rationale; Paula notes the tradeoff (London carries cultural weight Brussels doesn't) but doesn't block since the swap is user-approved and the log is explicit about what is being traded. #861 DoD captures the split conditions with actionable specificity.
Miri (worldbuilding): REQUEST_CHANGES
Aethelred migration fully resolved — inference chain is exactly the environmental storytelling the setting should reward. Earth + Groombridge fixes partially resolved; three small items remain.
Remaining comments
tooling/planet-gen/earth_blocklist.txt:60+tooling/planet-gen/sol_markers/earth_features.jsonsol_import.pyrun may strip or flag Brussels as a violation unless GJ0d is explicitly exempt. Add a one-line comment inearth_blocklist.txtnoting GJ0d (Earth body) is blocklist-exempt, or document the exemption at the sol_import.py callsite.wiki/star-systems/GJ-380/bodies/GJ380c/markers.jsonSelet Basin(mid-eastern lake at [220,336], currently Anglo-compound name) →Subin Basin(Subin = the river running through Kumasi itself). Brings Akan presence to 3/29 and distributes across three feature types (river, mountain, lake), converting the minimum-viable patch into a credible corridor read. Single rename + DB re-sync.docs/atlas/hand-refine-log.md:119river_1 "Gap Crossing" → "Aldren Pass"as the final state for GJ144d, but the DB hasRandalfoss(verified:['Rán's Run', 'Randalfoss', 'Scarp Fork', 'Timber Keld', 'Ranfall Beck', 'Cliff Leat']). The Aldren stem was subsequently removed to eliminate the cross-system dup with GJ380c Groombridge. Update the log entry:…→ "Aldren Pass" (subsequently renamed Randalfoss in a later fix pass to eliminate the cross-system Aldren stem collision with GJ380c).Verdict: CHANGES REQUESTED
Very close — all 9 original items resolved cleanly, the split to #861 is clean, two reviewers approve. Only three small items remain, all on Miri's worldbuilding axis: one documentation-only (log stale), one one-line policy exemption comment, one single-feature rename. No new blockers. Expect round 3 to be short.
Review:
sprint-36/copy→ main (round 3, final)Scope of round 3: 1 commit (
6d9bb6ea), 5 lines changed across 4 files + 1 binary DB resync, closing the 3 remaining Miri items from round 2.Miri (worldbuilding): APPROVE
earth_blocklist.txt:60correctly scopes the blocklist to alien worlds only.Selet Basin → Subin Basinbrings Akan register to 3/29 features across three feature types (river: Nkwanta Beck, mountain: Bosomtwe Spur, lake: Subin Basin). Geographic placement is honest — features dispersed east-center and west rather than co-located, consistent with multi-directional corridor influence. Reads as credible Kumasi trade-lane presence, not token patch.Gap Crossing → Aldren Pass (subsequently renamed Randalfoss to eliminate cross-system Aldren stem collision with GJ380c).Hoshe (round 2: APPROVE, no new items) + Paula (round 2: APPROVE, no new items)
No remaining items from rounds 1–2. Round-3 commit surface is minimal (5 text lines + DB resync). Ruff clean. No regression vectors introduced.
Overall verdict: APPROVED
Recommend merge. Known-deferred items (186 empty mountain range names, non-city cross-body collisions, 112 stub narrative depth via #861) remain tracked as documented out-of-scope items per reviewer-accepted protocol.
Pull request closed