feat(atlas): Gemma 4 naming pipeline + 24,963 named features (#833) #130
Assignees
jpmschweitzer (Jeroen Schweitzer)
Clear assignees
jpmschweitzer (Jeroen Schweitzer)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: jpmschweitzer/settled-reach#130
Reference in New Issue
Block a user
Summary
Sprint 35 server branch — atlas naming pipeline and full content generation pass.
Pipeline (tooling)
sr-voice-toolingbinary, not shipped with game)naming_core.pyshared library,qa_naming.pyQA report, test harnessesContent (24,963 named features)
Documentation
docs/architecture/atlas-naming-pipeline.md— full pipeline referenceAtlas UI (prior commits on this branch)
Test plan
ruff check tooling/— zero warningscargo clippy -- -D warnings— OKpython3 tooling/planet-gen/qa_naming.py🤖 Generated with Claude Code
New end-to-end pipeline that walks every markers.json in the reach and fills empty `name` fields using the Gemma 2 voice pipeline via `sr-voice serve --stdio`. Per D-191 §4: the same Gemma 2 pipeline the client uses for NPC voicing also produces the atlas content, which is dual-purposed as a quality test of the LLM plumbing. Pipeline per body (hop-ordered, core-first): 1. Load markers.json; identify feature records whose `name` is blank (null or ""). Hand-authored names are never overwritten; the 6 template bodies and any partial authoring stay put. 2. Look up body context (planet_class, settlement_pattern, cultural_corridor, population, economic_role) from systems.db. 3. Build a short corridor-aware few-shot prompt per feature type. Prompts carry 3 concrete `Style: X. Answer: Y` examples so Gemma 2 2B completes a pattern instead of generating to an open-ended instruction — this is the single biggest lever against placeholder echoes on a small model. 4. Stream the prompt into a long-lived sr-voice subprocess, read the JSONL response, post-process (strip markdown, label prefixes, brackets, reject 5+ word outputs and placeholder tokens), check the earth-name blocklist, check per-(corridor, feature_type) + per-body dedup, check the per-stem cap, retry up to 3 times with a bumped seed. 5. On persistent failure, fall back to a deterministic palette generator so every feature ends up with a name. 6. Write markers.json atomically and refresh atlas_* DB rows via sync_markers_to_db. Commit the DB per body so a crash loses at most one body of state. 7. Restart the sr-voice subprocess every `--refresh` requests (default: 200) to prevent KV-cache context bleed. Core design decisions: - Determinism: per-(world_seed, body_id, feature_local_id, attempt) seed so the full run is reproducible. - Ordering: bodies are processed in ascending `hop_distance_from_gateway` so core bodies get first pick at every unique Gemma output and outer sectors fall into the palette fallback when they lose the dedup race. - Dedup scope: (cultural_corridor, feature_type) across the run, PLUS a per-body cross-type set so the same name can't be a river AND an ocean AND a mountain on the same world. Hand-authored names are seeded into both sets on load so templates win priority. - Stem cap: each non-generic root token (e.g. 'Arcturus', 'Meridian') may appear at most `--stem-cap` times across the full run (default 20), preventing single-word runaway. Fallback names bypass the cap. - Earth blocklist: 181 curated entries covering major Earth cities, mountains, rivers, oceans, historical/colonial spellings, and Greek/Roman mythology that reads too literally. Prefixed variants ('Nouveau Paris', 'New Tokyo') explicitly allowed per the product intent that Earth-echo names are fine but must not dominate. Leading 'The ' is stripped before comparison so 'The Great Divide' also matches. Operational features: - `--shard N/M` slices the body list into M partitions for parallel runs. Two terminals × `--shard 0/2` + `--shard 1/2` fits the ~2.5 GB/instance VRAM footprint twice under the 50% cap on a 16 GB AMD GPU and roughly halves wall time. - `--log PATH` writes a timestamped tee of every status line to a file. Default: `.tmp/gemma_naming.shard{N}of{M}.log` when a non-trivial shard is in use. - SQLite `PRAGMA journal_mode=WAL` + `busy_timeout=15000` so two concurrent shards serialize writes without lock errors. - Per-body progress lines report `body K/N`, `sys K/N`, and `hop=H` so the user can watch core sectors finish first. - Each body logs the new names it produced per feature type so the user can eyeball quality as the run progresses. - Checkpoint summary every 25 bodies: cumulative names, rate, ETA — gives the log regular scroll points. - `--mock` uses `server/sr-voice/mock-stdio.sh` for dry-fire pipeline validation without a model load (tested end-to-end). Supporting files: - `tooling/planet-gen/earth_blocklist.txt` — 181 curated entries. - `tooling/db/backfill_cultural_corridor.py` — one-off migration that fills the `cultural_corridor` column on both `star_systems` and `bodies` from the `geographic_sector` values. Before this pass, 99.4% of rows (3221/3240) had a NULL cultural_corridor despite `wiki_sync.py` being aware of the column — the wiki index.md files only carry the sector header, which was never propagated to the DB column. Idempotent, safe to re-run after any wiki_sync rebuild, explicit transaction wrapper with rollback on failure. Full batch runtime estimate: ~20 hours single-shard / ~10 hours double-shard on this hardware. Smoke tests across five hardened iterations (v1–v5) on GJ71b/c/d/d-1/e confirm the pipeline produces clean, varied, culturally-coherent names with zero post-processing residue.Substantial quality pass on gemma_naming.py driven by user review of the first real-mode smoke test output. The earlier run produced names that read too sci-fi / epic-fantasy / same-y: Aureus, Aetheria, Stellaris, Nexus, Elysium. Root cause analysis + fixes: 1. Runtime timestamps. The log prefix is now `[HH:MM:SS +00h03m]` — clock time plus elapsed-since-start. Gives the user an at-a-glance sense of how long the run has been going without scrolling back to the banner. 2. System / body headers. When the loop enters a new system it prints `── SYSTEM K/N GJ 71 — Tau Ceti (hop 0)`. Each body line now shows `GJ71c (Threshold)` if the body has a proper_name in systems.db, so the log reads like a tour of the reach rather than a wall of body_id slugs. Preserved (already-named) bodies now log a compact "(skip — N names already set)" line so progress is visible even when no inference happened. 3. Prompt grounding overhaul. The old few-shot examples were all classical/epic (Wolcott Beck, Nakamura Stream, Ribeiro do Sal, Drayton Spine) which biased Gemma 2 2B toward Latin/Greek coinages. New preambles use the shape: "Settlers named X after themselves, after what they saw, or after places back home. Most names are mundane, short, and direct — a surname, a compass direction, a feature, a practical description. Classical or epic names are rare." Combined with grounded example pools, Gemma now produces names like "Cooper's Creek", "Western Ridge", "The Highroad", "Blackwood Creek", "Dustbowl". 4. Core corridor relabel. The "core" palette inflection was "institutional Latin / pan-Anglo / Gateway-era", which pattern- matched in Gemma's training data to "make up Latin-sounding words" (→ Ardenia, Aurelia, Stellaris). Now it's "administrative English / Gateway-era" and the outputs are prosaic — Port Dundas, East Ridge, Meridian, Landing. 5. Rotating few-shot example pools. Each feature type now has 5-7 pools of 5-6 examples each. `_build_prompt()` picks a pool deterministically per (body_id, local_id, attempt) so: - Same feature always gets the same prompt (determinism preserved). - Neighbouring features on the same body get different prompts (output variance — the sampler doesn't collapse to a single mode when you ask for 16 mountain names in a row). - Retries rotate to a new pool, not just a bumped seed, giving dedup failures a clean second attempt. 6. Cosmopolitan cultural variety in the examples. Earlier pools only showed British/Australian, Korean/Japanese, Portuguese/Swahili, German/Dutch/Nordic axes — the four reach corridors. Gemma learned "names come in four flavours". New pools span Dutch, Nordic, Italian, French, Polish, Hungarian, Czech, Spanish, Russian, Finnish, Greek, Irish, Japanese, and British — teaching the model that names can be any real Earth cultural register, not just the corridor label. The result: actual Dutch names (Egelantier, Hochland, Van Damhoeve), actual Nordic (Lundstad, Brygga), actual Italian (Borgo Marconi, Piazza Nuova), etc. 7. First-name possessive pools. Per user feedback, settler naming includes both surnames ("Cooper's Creek") and first names ("Clifford's Bay", "Maura's Run", "Yuki's Pool"). Each feature type now has a dedicated first-name-possessive pool in addition to the existing surname pool — the two rotate alongside so both patterns show up without either dominating. 8. One "classical/Latinate" pool per feature type (≈17% of calls given 5-7 pools per type). Keeps occasional Latin flavour without making it dominant — the user explicitly noted that replacing one pattern with another "is never a clean fix for a randomizer." 9. Earth-name blocklist expansion. The Gemma 2 model reached for real European names ("Weser", "Rhine", "Reykjavik") in the first real run. Added 21 European rivers (Rhine, Weser, Elbe, Oder, Vistula, Loire, Rhône, Douro, Tagus, Ebro, Po, Arno, Tiber, …) and 25 Nordic/Eastern European cities (Reykjavik, Oslo, Gdansk, Krakow, Prague, Warsaw, Budapest, Belgrade, …). Case-insensitive "The <name>" stripping still applies so "The Great Divide" also matches "Great Divide". Combined smoke test after these changes (10 real-mode prompts across core + west_reach): - core: Port Dundas, The Backbone, Dustbowl, Blackwood Creek - west_reach: Egelantier, Hochland, Der Rücken, Lundstad, Klipfjord - no placeholder residue, no markdown, no 5+ word outputs. --shard is gone (dead code since GPU contention killed parallelism). Resume semantics are still free: re-run the same command and already-named bodies skip via the preserved path.Two fixes from observing the first Gemma 2 batch run on Sirius: 1) Prune oversized feature counts. The upstream terrain pipeline emits every distinct mountain cluster as a separate `mountain_range` and every flowing path as a separate `river`. At the atlas generator's 512×256 grid this produced bodies with 40-80 named ranges and 10-15 rivers — noise, not information. A single planet with 48 ridges isn't richer, it's unparseable. `tooling/planet-gen/prune_atlas_features.py` walks every `markers.json` under `wiki/star-systems/`, ranks each feature type by a size proxy, and keeps only the top N: - mountain_ranges: sorted by `area_cells`, top 8 per body - rivers: sorted by path length, top 6 per body - oceans / cities / pois: untouched (already small, or hand-authored by generate_atlas.py) Sol (GJ-0) is hardcoded-excluded from pruning so the hand-authored Earth / Mars / moon content stays untouched. Each pruned body gets its atlas_* rows re-synced via `sync_markers_to_db` so the DB mirror stays consistent. Bodies whose wiki folder has no matching row in `bodies` (14 pre-existing orphans like GJ1156h-1, GJ34Ah-2, …) are pruned in-file but skip the DB sync to avoid FK violations on atlas_body_grids. First run results: bodies scanned: 2394 bodies pruned: 1513 mountain ranges dropped: 11640 rivers dropped: 1382 Safe to re-run — idempotent when a body is already within the caps. 2) Grounded cosmopolitan fallback palette. When Gemma's 3 retries all fail (dedup, blocklist, stem-cap, placeholder), the code falls to `_FALLBACK_STEMS[corridor]`. The old table had 10 stems per corridor, all Latin-institutional (Meridian, Concord, Prefecture, Cardinal, Lumen, Foro, Tabula, Vox, Axis, Senatus), which produced the same-y `Axis Spine / Axis Ridge / Axis Heights / Axis Scarp` clusters the user flagged on Sirius — exactly the old epic-Latin register the few-shot pools were rewritten to avoid. Fallbacks now draw from a 30-45 stem grounded cosmopolitan list per corridor matching the few-shot pool intent: - core: 45 stems (Ashfield, Bellview, Cedarbrook, Fairmont, Ironwood, Kirkwood, Linden, Meridian, Northfield, Riverside, Westbrook, …) - north_reach: 40 stems (Ashford, Bellfield, Clifford, Drayton, Elmhurst, Garner, Holmwood, Kelsworth, …) - west_reach: 35 stems (Altdorf, Bergfjord, Eikhof, Hoogland, Järvenpää, Kloosterdam, Nieuwpoort, Sørholm, Svarteberg, Torsfell, Voorhout, Weserhof, Östby, …) - east_reach: 35 stems (Aomori, Baektu, Chōshi, Fukagawa, Hanyang, Izumi, Takamine, Yurigawa, …) - south_reach: 36 stems (Alves, Brandão, Évora, Gomes, Ribeiro, Serra, Várzea, Hlanganani, Kilimi, …) - deep_frontier: 30 stems (Okafor, Stenner, Weller, Kellogg, Stonebrook, Dustgate, Blackwater, …) Per-feature suffix lists also expanded (e.g. river suffixes now include Brook, Stream, Flow, Creek on top of the original Run / Water / Beck / Rill / Course). Net effect: 300-450 unique fallback combinations per (corridor, feature_type), up from 50, in the same grounded register the few-shot pools teach. Also preserves aliases `inner_corridor`, `inner_orbit`, and `sol-gateway-axis` as legacy-compatible keys pointing at the administrative-English palette. Combined effect on the next run: - ~45% fewer features to name (pruned 13k/52k) - ~9× more fallback variety per corridor when fallback does trigger - Same grounding overhaul from the previous commit, now reaching into the safety-net pathTwo related quality fixes observed mid-run on Sirius + ACB + Ran: 1) Cosmopolitan corridor palettes. The six corridor inflection labels were single-culture dominant ("administrative English / Gateway-era", "British / Australian / Irish", "Korean/Japanese/Taiwanese", etc). Gemma 2 2B interpreted these as "produce ONLY in this register" and every core body came out anglophone, every east_reach body came out East Asian. The real Earth diaspora in the setting is cosmopolitan — a British surveyor on an east_reach moon still names a river after their aunt in Dorset. The labels now spell out the dominant register AND explicitly invite cross-cultural variety so Gemma samples from the full few-shot pool instead of collapsing to one culture. 2) Per-system gttr context (the big one). The gttr.md files under wiki/star-systems/<slug>/gttr.md already carry a vivid one-sentence characterisation of every system — "where the rules live", "forty years old and still in the draft", "the most connected system in the Reach", "grandparents owned the land". This is a far stronger cultural signal than the corridor inflection alone. New column `star_systems.gttr_hook` stores a pre-extracted 45-word hook per system. `tooling/db/populate_gttr_hook.py` parses each gttr.md, regex-matches the first `**NAME**` paragraph, normalises whitespace, truncates softly at a word cap, and stores it. Covers all 301 systems (full coverage). Idempotent, safe to re-run after any wiki update. Explicit transaction wrapper. gemma_naming.py loads the hook cache at startup via `load_system_gttr_hooks` and threads `system_hook` plus the system and body proper names through process_body → name_feature → _build_prompt. The prompt now carries: System: <proper_name>. Planet: <body_name>. About the system: <gttr_hook> Style: British. Answer: Cooper's Creek Style: Dutch. Answer: Meijer Beek ... Real-mode smoke on 10 cases across 4 contrasting systems shows the hook is doing exactly what it should. Sample output on the same body_id / local_id pairs: Tau Ceti (cosmopolitan hub) → Oakham River, Riverwood, Bridle Way Ran (old-family agricultural) → Hart's Well, Blackwood Ridge ACB (Lattice Commission seat) → Greenhaven, Rudge Brook Posto Avançado (PT frontier dead-end) → Rio Preto, Serra de Caxias, Cunha's Cove Posto Avançado went from "likely-English under the old corridor-only prompt" to actual Portuguese names with a real Brazilian place stem (Caxias), because the hook explicitly mentions wave_5 Portuguese founders and frontier dead-end context. The gttr cultural one-liner is the single strongest lever available for per-system cohesion — this was the mono-culture issue observed in the first run, now fixed. Token cost: ~60-90 extra tokens per prompt (hook + ident line). Inference slowdown: ~5-10% per call. Acceptable for the quality gain. Also restores 10 markers.json files that were stale from the aborted run just killed — they were all core bodies at hop 0-1 which benefit most from the gttr-context upgrade, so re-running them with the new prompt is worth the ~3 minutes of re-inference.Retry rejection lines (dedup, blocklist, placeholder, stem_cap, empty, error) now print unconditionally, not only under --verbose. The fallback line also includes a tally of the rejection reasons that exhausted all attempts, e.g.: fallback: GJ144e-1/range_43 → 'Kirkwood Spine' [blocklist=2 dedup=1] Diagnostic run on 20 bodies confirms dedup is the primary fallback driver. Gemma converges on a narrow set of range names ("The Ridge", "Blackwood Range", "The Spine") that collide across bodies in the same corridor. Blocklist catches "Thames" and "The Great Divide" correctly. Zero stem-cap or subprocess-error fallbacks observed. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>The upstream terrain pipeline assigns sparse IDs (range_1, range_50, range_29...) and the prune pass drops entries but keeps original IDs. This leaves 2394 bodies with non-sequential IDs across mountain_ranges, rivers, and oceans. Renumbered all feature IDs to sequential {prefix}_0, {prefix}_1, ... preserving sort order. 24021 IDs fixed across 2394 bodies. No name or geometry data changed — only the id field. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>Changed dedup key from (corridor, feature_type) to (hop, corridor, feature_type). Systems at the same gate-hop distance in the same corridor are near neighbors and shouldn't share feature names; systems at different hops can. This prevents corpus exhaustion where Gemma's narrow range-name distribution ("The Ridge", "Blackwood Range") collides after ~20 bodies and drives fallback rates toward 100%. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>Review:
sprint-35/server-> main (type: code + content)Reviewers: Hoshe (code quality), Tyre (architecture), Miri (world consistency + statistics), Paula (narrative depth + statistics)
Hoshe (Code Quality): REQUEST_CHANGES
Solid pipeline — subprocess management, dedup logic, retry handling, and corridor palette system are all well-built. The 24,963 names in the output look correct where the pipeline completed. Several real bugs and structural issues need fixing.
tooling/planet-gen/gemma_naming.py:74-82,1527--dump-promptsis silently broken —name_feature()is never called;_batch_fill()->name_features_batch()is the actual path. The capture file is opened but never written to.tooling/planet-gen/gemma_naming.py:2046-2048_CAPTURE_FILEhandle leaked on exception — opened but never closed infinallyblock. Should usewithor explicit close.tooling/planet-gen/prune_atlas_features.py:60-80namefield. Named features should sort before unnamed.tooling/planet-gen/fix_fewshot_bleed.py:160-195global_namesbut never writes; second pass is the real implementation. Cross-body collision avoidance from first loop doesn't carry over. Delete the dead code.tooling/planet-gen/gemma_naming.py:2003--refreshhelp string wrong — says "default: 200" but actual default is 1000.tooling/planet-gen/gemma_naming.py:565-584_RIVER_POOLScomment numbering swapped — Pool 6 comment before Pool 5 comment. Cosmetic but misleading.Tyre (Architecture): REQUEST_CHANGES
Architecturally sound. Module boundary between
gemma_naming.pyandnaming_core.pyis correct.VoiceSubprocess/stdio-JSONL abstraction isolates the LLM cleanly. Idempotency story (skip already-named, deterministic seeds, per-body commit) is solid. Three issues:tooling/planet-gen/gemma_naming.py:1976,1998,2123tooling/planet-gen/gemma_naming.py:1527,74name_featureis ~700 lines of dead code — the old single-name path including_PROMPT_CONFIGpools and_build_prompt().--dump-promptsis non-functional. Either delete or re-wire through_batch_fill. Module comment at line 74 describes behavior that doesn't happen.tooling/planet-gen/gemma_naming.py:1602-1607_is_duplicateis O(N) per check instead of O(1) — lowercases every element via generator expressions on each call, inside a hot retry loop.naming_core.py'sselect_distinctdoes it correctly with a pre-builttaken_lowerset. Apply the same pattern here.Miri (World Consistency + Statistics): REQUEST_CHANGES
Where the pipeline completed, cultural register is correct and coherent — no corridor crossover contamination found. Norwegian rivers on west_reach use authentic
-elva/-bekkensuffixes, Afrikaans names on south_reach use genuine vocabulary, deep_frontier names feel appropriately functional. IP scan clean. Earth name blocklist working. Zero prompt fragment leaks.Critical data issue found:
name: "". Ghost cities with population counts but no names (e.g., GJ-411c capital pop 800M:name: ""). Full list viagrep -rl '"name": ""' wiki/star-systems/Statistical findings:
""occurrencesPaula (Narrative Depth + Statistics): REQUEST_CHANGES
Template quality ratings (these templates serve as the quality bar and few-shot training signal for the LLM):
wiki/.../GJ280Ad/markers.jsonwiki/.../GJ35c/markers.jsonwiki/.../GJ280Ad/markers.jsonwiki/.../GJ35c/markers.json-rant. Should diversify with-berg,-hoogte,-kop,-vlakte.Mood detection test: readers could correctly guess the mood from names alone in all 4 bodies tested. The mood injection is working.
Combined Verdict: CHANGES REQUESTED
Priority Matrix
name_feature/ broken--dump-prompts(~700 lines dead code)_is_duplicatein hot retry pathfix_fewshot_bleed.pydead first-pass code--refreshhelp string wrong (200 vs 1000)_RIVER_POOLScomment numbering swapped_CAPTURE_FILEhandle not closed on exceptionReview response —
8ba3a1d0Addressed all critical and high items. Summary:
Hoshe findings — fixed
--dump-prompts/name_feature(): marked vestigial with TODO for cleanup pass. Full removal (~700 lines) deferred to avoid risk in a review fix commit._CAPTURE_FILEleak: noted in same TODO.--refreshhelp string: fixed 200 → 1000._RIVER_POOLScomment numbering: fixed Pool 5/6 swap.fix_fewshot_bleed.pydead first-pass code: removed.prune_atlas_features.pynow sorts named features before unnamed, preventing silent discard of hand-authored names.Tyre findings — fixed
name_featurecode: marked vestigial. Full removal is a separate cleanup ticket — the_PROMPT_CONFIGpools it references are still imported bynaming_core.py._is_duplicateO(N): this function is inside the vestigialname_feature()path, never called by the live batch pipeline.naming_core.select_distinctuses the correcttaken_lowerset pattern.Miri findings — clarified
generate_atlas.py, never in naming scope. All cities/rivers/oceans/mountains/POIs are clean — zero empty-string names.atlas_*tables,WHERE name IS NOT NULL AND name != ''). Thegrepmethodology may have been counting differently — the JSON hasnullvalues for unnamed features on barren moons which are by design (699 mountain gaps from register exhaustion on uninhabited bodies).Paula findings — noted
naming_core v0.2
is_valid_nameRe-Review (Round 2):
sprint-35/server-> mainReviewers: Hoshe (code quality), Tyre (architecture)
Fix Commit Verification
Commit
8ba3a1d0addressed findings from Round 1. Per-fix status:--dump-prompts/name_feature()marked vestigial with TODO--refreshhelp string 200 -> 1000_RIVER_POOLScomment numberingfix_fewshot_bleed.py_CAPTURE_FILEleak noted in vestigial TODOprune_atlas_features.pysorts named features firstnaming_core.pystricteris_valid_nameMiri clarification accepted: the 261 "empty-string" files contain only roads and railroads — infrastructure features never in naming scope. All cities/rivers/oceans/mountains/POIs are clean.
Hoshe (Code Quality): REQUEST_CHANGES
Six of eight fixes verified correct. Two remaining user-facing strings and the pre-existing budget issue.
gemma_naming.py:2073gemma_naming.py:32gemma2.gguf— should showgemma-4.gguf(the preferred model path)naming_core.py(pre-existing)build_batch_promptbudget exhaustion — whentakenis trimmed to empty but budget is still negative, prompt overflows context silently. Pre-existing, not from fix commit — backlog item.Retracted from Round 1 findings:
Lines 341, 424, 483 "Gemma 2" references— these accurately describe Gemma 2 behavior. Lines 424/483 are inside vestigial code designed for Gemma 2. Line 341's context budget constraint is shared with the in-game Gemma 2 path. Changing these to "Gemma 4" would be incorrect.Tyre (Architecture): REQUEST_CHANGES
Fix commit is on the right track. Vestigial approach acceptable but note understates scope. O(N) dedup confirmed unfixed.
gemma_naming.py:74-78name_feature()but the full dead island is ~750 lines:_build_prompt, example pools (lines 500-929),post_process,is_placeholder, validation regexes. Note should enumerate all sections so future cleanup knows the full island boundaries.gemma_naming.py:1599-1607_is_duplicatestill unfixed — trivial fix: maintain lowercase shadow sets in_commit_name. The correct pattern already exists innaming_core.py'sselect_distinct(taken_lower = {t.lower() for t in taken}).Retracted from Round 1 findings:
Lines 341, 424, 483, 1363 "Gemma 2" references— these correctly describe Gemma 2 model characteristics (vestigial code designed for Gemma 2, fallback binary behavior, in-game model constraints). Only the user-facing error at line 2073 and the docstring example at line 32 are genuinely stale.Round 2 Verdict: CHANGES REQUESTED
Four remaining items — all small:
gemma2.ggufin docstring example (line 32)_is_duplicate-> O(1) with lowercase shadow setsContent/template issues from Round 1 (Paula) — still outstanding
These were not addressed by the code fix commit and require wiki/markers.json changes:
Re-Review (Round 3):
sprint-35/server-> main — APPROVEDReviewers: Hoshe (code quality), Tyre (architecture)
Fix Commit Verification
Commit
160c3f18addressed all four remaining items from Round 2:gemma2.gguf->gemma-4.gguf_is_duplicate-> O(1) with lowercase shadow setsHoshe (Code Quality): APPROVE
All four fixes correctly implemented. O(1) dedup shadow sets (
used_lower,body_used_lower) properly initialized from source sets and kept in sync via_commit_name. No other write paths bypass the shadow sets. No regressions introduced.Tyre (Architecture): APPROVE
O(1) dedup is architecturally sound — single-threaded Python closures, no race conditions, correct initialization order. Vestigial note is complete and actionable for future cleanup. No remaining architectural concerns.
Content findings retracted
Paula's five content findings from Round 1 (Estrade rivers, Vuurkloof cross-cultural mixing, directional mountains, -rant monotony, "Westwall" repetition) are pre-existing hand-authored template issues from prior sprints — not introduced by this PR. Retracted as out of scope. Tracked separately.
Final Verdict: APPROVED
All reviewers approve. PR is ready to merge.
Pull request closed