fix(tooling): run-atlas-naming.sh — use grep -a instead of strings (#833)
The gfx1201 preflight check piped `strings` into grep, which fails silently on a Bazzite host where binutils is not installed and `strings` is not on PATH. `grep -a` reads the binary directly as text, works everywhere grep exists, and produces the same result. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -54,7 +54,10 @@ fi
|
||||
# "amdgcn-amd-amdhsa--gfx1201". If gfx1201 is missing and e.g. only
|
||||
# gfx906 is present, the build shipped kernels for a different arch
|
||||
# and every inference will crash with "invalid device function".
|
||||
if ! strings "$BIN" 2>/dev/null | grep -qw gfx1201; then
|
||||
#
|
||||
# Uses `grep -a` to scan the binary directly so we don't depend on
|
||||
# `strings` being on PATH (not present on a stock Bazzite host).
|
||||
if ! grep -a -q gfx1201 "$BIN"; then
|
||||
echo "error: $BIN does not contain gfx1201 kernels" >&2
|
||||
echo " expected target for AMD Radeon RX 9070 (Navi 48)" >&2
|
||||
echo " rebuild with CMAKE_HIP_ARCHITECTURES=gfx1201 inside $DISTROBOX_NAME" >&2
|
||||
|
||||
Reference in New Issue
Block a user