fix(ci): address PR #69 review — stale comments, dead CLI flags
- gen_fixtures.rs: version comments now say PROTOCOL_VERSION instead of hardcoded 14, so they stay correct across bumps - run-ipc-benchmark: remove --iterations flag that was parsed but never forwarded to the Rust test (compile-time constant governs) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -290,7 +290,7 @@ fn generate_msgpack_fixtures() {
|
||||
|
||||
// === #271 fixtures: named fixtures for cross-language Layer 1 testing ===
|
||||
|
||||
// snapshot_minimal: version=14, tick=0, one Player entity, all optionals absent
|
||||
// snapshot_minimal: version=PROTOCOL_VERSION, tick=0, one Player entity, all optionals absent
|
||||
let snapshot_minimal = fixture_snapshot(
|
||||
0,
|
||||
vec![VisibleEntity {
|
||||
@@ -310,7 +310,7 @@ fn generate_msgpack_fixtures() {
|
||||
&rmp_serde::to_vec_named(&snapshot_minimal).unwrap(),
|
||||
);
|
||||
|
||||
// snapshot_full: version=14, tick=42, monologue + dialogue + inventory + POIs + KG dump
|
||||
// snapshot_full: version=PROTOCOL_VERSION, tick=42, monologue + dialogue + inventory + POIs + KG dump
|
||||
let snapshot_full = ObserverSnapshot {
|
||||
version: PROTOCOL_VERSION,
|
||||
tick: 42,
|
||||
|
||||
@@ -14,14 +14,10 @@
|
||||
# Stdout: {"p50_ms":N,"p95_ms":N,"p99_ms":N,"threshold_ms":5,"passed":true,"rounds":100}
|
||||
set -euo pipefail
|
||||
|
||||
ITERATIONS=100
|
||||
THRESHOLD_MS=5
|
||||
|
||||
while [[ $# -gt 0 ]]; do
|
||||
case "$1" in
|
||||
--iterations) ITERATIONS="${2:-100}"; shift 2 ;;
|
||||
--iterations=*) ITERATIONS="${1#--iterations=}"; shift ;;
|
||||
--threshold-ms) THRESHOLD_MS="${2:-5}"; shift 2 ;;
|
||||
--filter) shift 2 ;; # ignored — benchmark has no test filter
|
||||
--filter=*) shift ;;
|
||||
*) echo "Unknown argument: $1" >&2; exit 2 ;;
|
||||
|
||||
Reference in New Issue
Block a user