From af3398ea34dee8288d2e5b20da1487f3457a3c63 Mon Sep 17 00:00:00 2001 From: Jeroen Schweitzer Date: Wed, 25 Feb 2026 13:10:23 +0100 Subject: [PATCH] =?UTF-8?q?fix(ci):=20address=20PR=20#69=20review=20?= =?UTF-8?q?=E2=80=94=20stale=20comments,=20dead=20CLI=20flags?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - gen_fixtures.rs: version comments now say PROTOCOL_VERSION instead of hardcoded 14, so they stay correct across bumps - run-ipc-benchmark: remove --iterations flag that was parsed but never forwarded to the Rust test (compile-time constant governs) Co-Authored-By: Claude Opus 4.6 --- server/tests/gen_fixtures.rs | 4 ++-- tests/run-ipc-benchmark | 4 ---- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/server/tests/gen_fixtures.rs b/server/tests/gen_fixtures.rs index ed309fe3b..46c361ab3 100644 --- a/server/tests/gen_fixtures.rs +++ b/server/tests/gen_fixtures.rs @@ -290,7 +290,7 @@ fn generate_msgpack_fixtures() { // === #271 fixtures: named fixtures for cross-language Layer 1 testing === - // snapshot_minimal: version=14, tick=0, one Player entity, all optionals absent + // snapshot_minimal: version=PROTOCOL_VERSION, tick=0, one Player entity, all optionals absent let snapshot_minimal = fixture_snapshot( 0, vec![VisibleEntity { @@ -310,7 +310,7 @@ fn generate_msgpack_fixtures() { &rmp_serde::to_vec_named(&snapshot_minimal).unwrap(), ); - // snapshot_full: version=14, tick=42, monologue + dialogue + inventory + POIs + KG dump + // snapshot_full: version=PROTOCOL_VERSION, tick=42, monologue + dialogue + inventory + POIs + KG dump let snapshot_full = ObserverSnapshot { version: PROTOCOL_VERSION, tick: 42, diff --git a/tests/run-ipc-benchmark b/tests/run-ipc-benchmark index dc638e83f..38d4b5c0d 100755 --- a/tests/run-ipc-benchmark +++ b/tests/run-ipc-benchmark @@ -14,14 +14,10 @@ # Stdout: {"p50_ms":N,"p95_ms":N,"p99_ms":N,"threshold_ms":5,"passed":true,"rounds":100} set -euo pipefail -ITERATIONS=100 THRESHOLD_MS=5 while [[ $# -gt 0 ]]; do case "$1" in - --iterations) ITERATIONS="${2:-100}"; shift 2 ;; - --iterations=*) ITERATIONS="${1#--iterations=}"; shift ;; - --threshold-ms) THRESHOLD_MS="${2:-5}"; shift 2 ;; --filter) shift 2 ;; # ignored — benchmark has no test filter --filter=*) shift ;; *) echo "Unknown argument: $1" >&2; exit 2 ;;