jpmschweitzer/settled-reach
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

test(client): add_child AtlasViewer in view-api tests — bare .new() has nil _canvas

Browse Source 
Three of the four new tests skipped scene-tree entry, so _ready() never resolved _canvas and set_view crashed _apply_transform. Mirrors the fourth (passing) test. Targeted suite green.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This commit is contained in:
jpmschweitzer
2026-07-16 20:34:01 +02:00
co-authored by Claude Fable 5
parent 2b2f4f8abb
commit 56b9f135d0
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/tests/test_atlas_view_api.gd
+3
View File
@@ -12,6 +12,7 @@ extends GdUnitTestSuite
func test_set_view_applies_zoom_and_offset() -> void:
var v: AtlasViewer = auto_free(AtlasViewer.new())
add_child(v) # _canvas resolves in _ready(); a bare .new() crashes _apply_transform
v.set_view(3.0, Vector2(100.0, -40.0))
assert_that(v.get_view_zoom()).is_equal_approx(3.0, 0.001)
assert_that(v.get_view_offset()).is_equal(Vector2(100.0, -40.0))
@@ -22,6 +23,7 @@ func test_set_view_applies_zoom_and_offset() -> void:
## a range the rest of the viewer doesn't expect.
func test_set_view_clamps_zoom_to_min_max() -> void:
var v: AtlasViewer = auto_free(AtlasViewer.new())
add_child(v)
v.set_view(0.01, Vector2.ZERO)
assert_that(v.get_view_zoom()).is_equal_approx(AtlasViewer.MIN_ZOOM, 0.001)
@@ -36,6 +38,7 @@ func test_set_view_clamps_zoom_to_min_max() -> void:
## _canvas.scale/_canvas.position instead of the cached _view_zoom/_view_offset).
func test_view_getters_round_trip_after_set_view() -> void:
var v: AtlasViewer = auto_free(AtlasViewer.new())
add_child(v)
var cases: Array = [
[1.0, Vector2.ZERO],