From 56b9f135d02612682054adadcfcf55fec026e2b4 Mon Sep 17 00:00:00 2001 From: Jeroen Schweitzer Date: Thu, 16 Jul 2026 20:34:01 +0200 Subject: [PATCH] =?UTF-8?q?test(client):=20add=5Fchild=20AtlasViewer=20in?= =?UTF-8?q?=20view-api=20tests=20=E2=80=94=20bare=20.new()=20has=20nil=20?= =?UTF-8?q?=5Fcanvas?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Three of the four new tests skipped scene-tree entry, so _ready() never resolved _canvas and set_view crashed _apply_transform. Mirrors the fourth (passing) test. Targeted suite green. Co-Authored-By: Claude Fable 5 --- client/tests/test_atlas_view_api.gd | 3 +++ 1 file changed, 3 insertions(+) diff --git a/client/tests/test_atlas_view_api.gd b/client/tests/test_atlas_view_api.gd index 6236d889c..f4c30d784 100644 --- a/client/tests/test_atlas_view_api.gd +++ b/client/tests/test_atlas_view_api.gd @@ -12,6 +12,7 @@ extends GdUnitTestSuite func test_set_view_applies_zoom_and_offset() -> void: var v: AtlasViewer = auto_free(AtlasViewer.new()) + add_child(v) # _canvas resolves in _ready(); a bare .new() crashes _apply_transform v.set_view(3.0, Vector2(100.0, -40.0)) assert_that(v.get_view_zoom()).is_equal_approx(3.0, 0.001) assert_that(v.get_view_offset()).is_equal(Vector2(100.0, -40.0)) @@ -22,6 +23,7 @@ func test_set_view_applies_zoom_and_offset() -> void: ## a range the rest of the viewer doesn't expect. func test_set_view_clamps_zoom_to_min_max() -> void: var v: AtlasViewer = auto_free(AtlasViewer.new()) + add_child(v) v.set_view(0.01, Vector2.ZERO) assert_that(v.get_view_zoom()).is_equal_approx(AtlasViewer.MIN_ZOOM, 0.001) @@ -36,6 +38,7 @@ func test_set_view_clamps_zoom_to_min_max() -> void: ## _canvas.scale/_canvas.position instead of the cached _view_zoom/_view_offset). func test_view_getters_round_trip_after_set_view() -> void: var v: AtlasViewer = auto_free(AtlasViewer.new()) + add_child(v) var cases: Array = [ [1.0, Vector2.ZERO],