Jeroen Schweitzer jpmschweitzer
  • Joined on 2025-11-14
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#189 2026-07-21 17:07:41 +02:00
feat(ui): T-1145 regional polish — cover-fit, WASD+edge-scroll pan, smoothed composite

Review: atlas-regional-polish → main (type: code) — single round

Single reviewer (client-only polish implementing Jeroen's explicit round-2 rulings; live full-chain drive by the lead…

jpmschweitzer created pull request jpmschweitzer/settled-reach#189 2026-07-21 17:03:21 +02:00
feat(ui): T-1145 regional polish — cover-fit, WASD+edge-scroll pan, smoothed composite
jpmschweitzer pushed to atlas-regional-polish at jpmschweitzer/settled-reach 2026-07-21 17:03:13 +02:00
372ce37bb6 feat(ui): T-1145 round-2 polish — cover-fit, WASD+edge-scroll pan, smoothed composite (Jeroen rulings)
848fa12003 chore(meta): file+activate T-1145 (round-2 friction: cover-fit, WASD pan, smoothing); expand T-1143 with sub-district sampling design
Compare 2 commits »
jpmschweitzer created branch atlas-regional-polish in jpmschweitzer/settled-reach 2026-07-21 17:03:13 +02:00
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-07-21 15:32:42 +02:00
9bfd86309a chore(meta): close T-1142 — PR #188 merged (descent fixes, live full-chain verified)
af07672c5b Merge remote-tracking branch 'origin/atlas-descent-fixes'
7ce6cc08fd test(ui): pin the _user_adjusted resize guard both ways; fix coalescing doc overstatement (PR #188 review)
d426059cb6 chore(meta): T-1142 to review — PR #188 up (descent fixes, live full-chain verified)
ce71abec28 chore(meta): file T-1144 — atlas_viewer.gd structural extraction (at gdlint cap two rounds running)
Compare 9 commits »
jpmschweitzer deleted branch atlas-descent-fixes from jpmschweitzer/settled-reach 2026-07-21 15:29:56 +02:00
jpmschweitzer closed pull request jpmschweitzer/settled-reach#188 2026-07-21 15:26:14 +02:00
fix(simulation+ui): T-1142 descent bounds, fit, pole wall, east-west wrap — live-verified full chain
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#188 2026-07-21 15:25:35 +02:00
fix(simulation+ui): T-1142 descent bounds, fit, pole wall, east-west wrap — live-verified full chain

Review: atlas-descent-fixes → main (type: code) — round 2 (fix round)

Single reviewer (proportionality: a bug-fix round implementing explicit prescriptions from Jeroen's hands-on + prior…

jpmschweitzer pushed to atlas-descent-fixes at jpmschweitzer/settled-reach 2026-07-21 15:25:07 +02:00
7ce6cc08fd test(ui): pin the _user_adjusted resize guard both ways; fix coalescing doc overstatement (PR #188 review)
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#188 2026-07-21 15:25:00 +02:00
fix(simulation+ui): T-1142 descent bounds, fit, pole wall, east-west wrap — live-verified full chain

QA re-review — Hoshe

Verdict: APPROVE (was REQUEST_CHANGES)

Re-reviewed commit 7ce6cc08f against both findings from my prior pass. Both closed, verified independently rather than…

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#188 2026-07-21 15:19:53 +02:00
fix(simulation+ui): T-1142 descent bounds, fit, pole wall, east-west wrap — live-verified full chain

QA review — Hoshe

Verdict: REQUEST_CHANGES

Verified all six review items against source at 831625019/4a65bb210 (worktree HEAD == origin tip). The bounds gate, canonicalization…

jpmschweitzer created pull request jpmschweitzer/settled-reach#188 2026-07-21 15:11:43 +02:00
fix(simulation+ui): T-1142 descent bounds, fit, pole wall, east-west wrap — live-verified full chain
jpmschweitzer pushed to atlas-descent-fixes at jpmschweitzer/settled-reach 2026-07-21 15:11:34 +02:00
831625019a fix(ui): T-1142 client — descent bounds gate, fit-and-center, pole wall, east-west wrap, body-name header
4a65bb210d fix(simulation): normalize window_center before cache and coalescing keys (T-1142 server half)
e7319cf322 chore(meta): file T-1142 (descent bounds + fit bugs, Jeroen hands-on) + T-1143 (quiet-interior legibility)
Compare 3 commits »
jpmschweitzer created branch atlas-descent-fixes in jpmschweitzer/settled-reach 2026-07-21 15:11:34 +02:00
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-07-21 14:09:57 +02:00
4ad3b1b352 chore(meta): close regional-window batch — T-1137/T-1138 done (PR #187 merged, triple review, 6 findings fixed incl. the off-equator descent bug)
64d26995fc Merge remote-tracking branch 'origin/atlas-regional-window'
96f6baa930 docs(meta): D-226 T-1124 prose corrections — real TerrainAnalysis cost model + glaciation gate (PR #187 C1/C4)
4eed3bccb2 fix(ui): latitude-inverse denominator + reticle city-hover gate (PR #187 findings)
df33e9f2fb fix(simulation): per-body TerrainAnalysis LRU + full-path determinism test (PR #187 C1/C3)
Compare 9 commits »
jpmschweitzer deleted branch atlas-regional-window from jpmschweitzer/settled-reach 2026-07-21 14:07:10 +02:00
jpmschweitzer closed pull request jpmschweitzer/settled-reach#187 2026-07-21 14:03:00 +02:00
feat(simulation+ui): the regional map — click-through descent to district-resolution windows (D-226 T-1124)
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#187 2026-07-21 14:02:28 +02:00
feat(simulation+ui): the regional map — click-through descent to district-resolution windows (D-226 T-1124)

Review: atlas-regional-window → main (type: code + governance) — round 2 (fix round)

Three reviewers: Hoshe (QA), Tyre (architecture — the amendment is his design; implementation only),…

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#187 2026-07-21 14:01:25 +02:00
feat(simulation+ui): the regional map — click-through descent to district-resolution windows (D-226 T-1124)

Tyre — re-review of the four C1–C4 deltas (df33e9f2f / 4eed3bccb / 96f6baa93)

Verdict flips to APPROVE. All four findings addressed on the merits — verified against the code and tests…

jpmschweitzer pushed to atlas-regional-window at jpmschweitzer/settled-reach 2026-07-21 14:00:33 +02:00
96f6baa930 docs(meta): D-226 T-1124 prose corrections — real TerrainAnalysis cost model + glaciation gate (PR #187 C1/C4)
4eed3bccb2 fix(ui): latitude-inverse denominator + reticle city-hover gate (PR #187 findings)
df33e9f2fb fix(simulation): per-body TerrainAnalysis LRU + full-path determinism test (PR #187 C1/C3)
Compare 3 commits »