Jeroen Schweitzer jpmschweitzer
  • Joined on 2025-11-14
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#16 2026-02-12 23:37:17 +01:00
feat(server): sprint 3 — tick rate, interactions, content skeleton

Re-Review Round 4: server -> main (type: code)

2 new commits addressing final 3 blockers.


Hoshe (Code Quality): APPROVE

Summary: All 3 Round 3 blockers fixed correctly. Observer…

jpmschweitzer pushed to server at jpmschweitzer/settled-reach 2026-02-12 23:33:17 +01:00
c765572bea chore(meta): update changelog
c05ff7b063 feat(client): enforce PROTOCOL_VERSION check in snapshot decode
18d8253bfe refactor(server): decompose observer pipeline and fix interaction boundary
Compare 3 commits »
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-02-12 23:30:18 +01:00
30f6666d7d Merge remote-tracking branch 'origin/main' into visual
ebcaff1a05 chore(config): remove client .uid/.import gitignore additions
921d2aef0d refactor(assets): move sprite renderer to standalone project at renderer/
8a1b10786f chore(meta): update changelog
3a01d9659f chore(config): add .uid and recursive .import to gitignore
Compare 7 commits »
jpmschweitzer pushed to visual at jpmschweitzer/settled-reach 2026-02-12 23:28:43 +01:00
30f6666d7d Merge remote-tracking branch 'origin/main' into visual
fd775878e7 Merge remote-tracking branch 'origin/copy'
2827dd3a83 fix(decisions): update stale Hael references to Naia in D-034 and D-036
010c4158f9 docs(copy): address PR #15 review feedback
16ee660b5d Merge remote-tracking branch 'origin/main' into copy
Compare 33 commits »
jpmschweitzer pushed to visual at jpmschweitzer/settled-reach 2026-02-12 23:27:49 +01:00
ebcaff1a05 chore(config): remove client .uid/.import gitignore additions
921d2aef0d refactor(assets): move sprite renderer to standalone project at renderer/
Compare 2 commits »
jpmschweitzer pushed to visual at jpmschweitzer/settled-reach 2026-02-12 23:22:50 +01:00
8a1b10786f chore(meta): update changelog
3a01d9659f chore(config): add .uid and recursive .import to gitignore
2ed8fb5b37 feat(assets): add 3D-to-2D sprite render pipeline and /render-sprite skill
0358eedbc5 docs(workshops): archive art direction & mood board workshop (3 rounds + closing)
Compare 4 commits »
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#16 2026-02-12 22:58:36 +01:00
feat(server): sprint 3 — tick rate, interactions, content skeleton

Re-Review Round 3: server -> main (type: code)

5 new commits since Round 2. Evaluating full punch list.


Hoshe (Code Quality): REQUEST_CHANGES

Summary: 5/12 fully fixed, 3…

jpmschweitzer pushed to server at jpmschweitzer/settled-reach 2026-02-12 22:53:28 +01:00
e6bd577a5a chore(meta): update changelog
0c91f5af21 chore(tooling): add make validate-content for schema validation
0157d1fa38 test(server): add Entity::to_bits roundtrip and TickRate switch tests
02fa89b1d7 refactor(server): extract observer tests to separate file
6f9537fff3 refactor(server): NearbyInteractionBuffer from Resource to Component
Compare 5 commits »
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#16 2026-02-12 22:30:32 +01:00
feat(server): sprint 3 — tick rate, interactions, content skeleton

Re-Review: server -> main (type: code) — Round 2

PR #16: feat(server): sprint 3 — tick rate, interactions, content skeleton 7 fix commits since initial review.


Hoshe (Code…

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#16 2026-02-12 22:30:01 +01:00
feat(server): sprint 3 — tick rate, interactions, content skeleton

Re-Review Round 2: server -> main. See full review below.

jpmschweitzer pushed to server at jpmschweitzer/settled-reach 2026-02-12 22:18:50 +01:00
c970d2eba7 chore(meta): update changelog
ba867564a8 fix(server): add error logging, protocol version, and architecture docs
e2f2f4e590 refactor(server): remove dead generate_snapshot function
9d53869ca7 refactor(data): restructure content directory for galaxy scale
Compare 4 commits »
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#16 2026-02-12 20:21:44 +01:00
feat(server): sprint 3 — tick rate, interactions, content skeleton

Supplementary Review: Content Directory Scalability (Tyre, Architecture)

Verdict: REQUEST_CHANGES

The current content/districts/{slug}/ flat structure works for v0.1 but has **critical…

jpmschweitzer pushed to server at jpmschweitzer/settled-reach 2026-02-12 20:15:01 +01:00
8cd7ef21ae chore(meta): update changelog
ece4dfe1c4 fix(data): restore hierarchical fields in district metadata
9943684f2c refactor(server): address PR #16 review feedback
Compare 3 commits »
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#16 2026-02-12 20:00:22 +01:00
feat(server): sprint 3 — tick rate, interactions, content skeleton

Review: server -> main (type: code)

Hoshe (Code Quality): REQUEST_CHANGES

The PR implements tick rate scaling, proximity interactions, and content schemas with generally solid code…

jpmschweitzer created pull request jpmschweitzer/settled-reach#16 2026-02-12 19:52:25 +01:00
feat(server): sprint 3 — tick rate, interactions, content skeleton
jpmschweitzer pushed to server at jpmschweitzer/settled-reach 2026-02-12 19:49:29 +01:00
458be0f621 chore(meta): update changelog
2de413dd87 feat(simulation): add proximity detection and interaction verbs
5afea99622 feat(simulation): add tick rate scaling system
ad55dfaa72 feat(data): add content schema definitions
10f5be29b1 feat(data): create content/ directory skeleton
Compare 5 commits »
jpmschweitzer pushed to server at jpmschweitzer/settled-reach 2026-02-12 19:19:45 +01:00
b5333f1612 Merge remote-tracking branch 'origin/main' into server
fd775878e7 Merge remote-tracking branch 'origin/copy'
2827dd3a83 fix(decisions): update stale Hael references to Naia in D-034 and D-036
010c4158f9 docs(copy): address PR #15 review feedback
16ee660b5d Merge remote-tracking branch 'origin/main' into copy
Compare 11 commits »
jpmschweitzer pushed to client at jpmschweitzer/settled-reach 2026-02-12 19:18:42 +01:00
fd775878e7 Merge remote-tracking branch 'origin/copy'
2827dd3a83 fix(decisions): update stale Hael references to Naia in D-034 and D-036
010c4158f9 docs(copy): address PR #15 review feedback
16ee660b5d Merge remote-tracking branch 'origin/main' into copy
d17a3ff060 Merge remote-tracking branch 'origin/main'
Compare 28 commits »
jpmschweitzer pushed to maintenance at jpmschweitzer/settled-reach 2026-02-12 19:18:39 +01:00
fd775878e7 Merge remote-tracking branch 'origin/copy'
2827dd3a83 fix(decisions): update stale Hael references to Naia in D-034 and D-036
010c4158f9 docs(copy): address PR #15 review feedback
16ee660b5d Merge remote-tracking branch 'origin/main' into copy
d17a3ff060 Merge remote-tracking branch 'origin/main'
Compare 24 commits »
jpmschweitzer pushed to copy at jpmschweitzer/settled-reach 2026-02-12 19:18:28 +01:00
fd775878e7 Merge remote-tracking branch 'origin/copy'
2827dd3a83 fix(decisions): update stale Hael references to Naia in D-034 and D-036
Compare 2 commits »