Jeroen Schweitzer jpmschweitzer
  • Joined on 2025-11-14
jpmschweitzer pushed to copy at jpmschweitzer/settled-reach 2026-02-19 15:43:05 +01:00
f42c3209d8 chore(db): backup database after worktree merge
8c92ae2285 Merge remote-tracking branch 'origin/visual'
4bdcc8c3fa Merge remote-tracking branch 'origin/ci'
87a90b27bd feat(simulation): wire footstep sound events into movement system
f533235f58 chore(meta): update changelog
Compare 17 commits »
jpmschweitzer pushed to client at jpmschweitzer/settled-reach 2026-02-19 15:41:12 +01:00
dfcafee3ee fix(client): address PR #43 review — walk key mismatch + 5 suggestions
jpmschweitzer closed pull request jpmschweitzer/settled-reach#44 2026-02-19 15:37:36 +01:00
docs(visual): Sprint 12 — spatial layouts (#311, #312, #313)
jpmschweitzer closed pull request jpmschweitzer/settled-reach#41 2026-02-19 15:37:36 +01:00
feat(ci): Sprint 12 — HashMap lint, rng_seed, tracing, schedule debug
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-02-19 15:37:33 +01:00
f42c3209d8 chore(db): backup database after worktree merge
8c92ae2285 Merge remote-tracking branch 'origin/visual'
4bdcc8c3fa Merge remote-tracking branch 'origin/ci'
3c4bf742ea docs(visual): Sprint 12 — spatial layouts for three v0.1 locations (#311, #312, #313)
e047218ad2 fix(ci): remove duplicate doc comment, add rng_seed serialization tests (#344, #527)
Compare 12 commits »
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-02-19 15:29:22 +01:00
87a90b27bd feat(simulation): wire footstep sound events into movement system
f533235f58 chore(meta): update changelog
03c44bebaf fix(simulation): address PR #42 review — 8 items from Hoshe and Tyre
8e00db2b2d feat(simulation): #94 #99 active tier filtering and transition system
066f8031fd feat(simulation): sprint 12 server — tier system, sound events, KG access, line previewer
Compare 5 commits »
jpmschweitzer closed pull request jpmschweitzer/settled-reach#42 2026-02-19 15:29:21 +01:00
feat(simulation): sprint 12 server — tier system, sound events, KG access, line previewer
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#43 2026-02-19 15:28:52 +01:00
feat(client): Sprint 12 — sound pipeline, indicators, renderer fix

Review: client -> main (type: code) — PR #43

Verdict: CHANGES REQUESTED


Hoshe (Code Quality): REQUEST_CHANGES

The PR delivers four coherent feature tickets with good structural…

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#42 2026-02-19 15:28:50 +01:00
feat(simulation): sprint 12 server — tier system, sound events, KG access, line previewer

Re-Review: server -> main (type: code) — PR #42

Verdict: APPROVED

All 8 items from the previous review are verified fixed. No new critical or warning issues introduced.


Hoshe…

jpmschweitzer pushed to server at jpmschweitzer/settled-reach 2026-02-19 15:14:58 +01:00
87a90b27bd feat(simulation): wire footstep sound events into movement system
jpmschweitzer created pull request jpmschweitzer/settled-reach#44 2026-02-19 15:10:09 +01:00
docs(visual): Sprint 12 — spatial layouts (#311, #312, #313)
jpmschweitzer pushed to visual at jpmschweitzer/settled-reach 2026-02-19 15:09:03 +01:00
3c4bf742ea docs(visual): Sprint 12 — spatial layouts for three v0.1 locations (#311, #312, #313)
jpmschweitzer pushed to server at jpmschweitzer/settled-reach 2026-02-19 15:08:58 +01:00
f533235f58 chore(meta): update changelog
03c44bebaf fix(simulation): address PR #42 review — 8 items from Hoshe and Tyre
Compare 2 commits »
jpmschweitzer pushed to ci at jpmschweitzer/settled-reach 2026-02-19 15:07:17 +01:00
e047218ad2 fix(ci): remove duplicate doc comment, add rng_seed serialization tests (#344, #527)
3d306b8a2b feat(ci): add tracing::instrument to heavy per-tick systems, fix stale protocol comment (#344, #527)
a71218f6bc feat(ci): tracing JSON format in CI, tick duration logging, schedule dump (#344, #346)
6a7dc915de feat(bridge): add rng_seed to ObserverSnapshot for deterministic replay (#527)
3248603838 feat(simulation): ban HashMap via clippy disallowed_types, fix violations (#343)
Compare 7 commits »
jpmschweitzer created pull request jpmschweitzer/settled-reach#43 2026-02-19 15:06:39 +01:00
feat(client): Sprint 12 — sound pipeline, indicators, renderer fix
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#41 2026-02-19 15:06:29 +01:00
feat(ci): Sprint 12 — HashMap lint, rng_seed, tracing, schedule debug

Review: ci -> main (type: code)

Hoshe (Code Quality): APPROVE

Well-structured PR delivering four tickets cleanly. HashMap-to-BTreeMap migration is correct with principled clippy…

jpmschweitzer pushed to client at jpmschweitzer/settled-reach 2026-02-19 15:06:11 +01:00
e1a1a9cfc2 fix(client): address PR review warnings — field guard + public API rename
f337bb3ca8 fix(client): correct 5 bugs found in pre-PR review
719721cd4c fix(client): apply arch review corrections — 640px dialogue width, D-067 chime
c6bd7c2db2 feat(client): Sprint 12 — renderer fix, sound pipeline, medium-range indicators
Compare 4 commits »
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#42 2026-02-19 15:04:04 +01:00
feat(simulation): sprint 12 server — tier system, sound events, KG access, line previewer

Review: server -> main (type: code)

Verdict: CHANGES REQUESTED


Hoshe (Code Quality): REQUEST_CHANGES

The PR delivers working tier system, sound pipeline, KG access control, and…

jpmschweitzer created pull request jpmschweitzer/settled-reach#42 2026-02-19 14:50:54 +01:00
feat(simulation): sprint 12 server — tier system, sound events, KG access, line previewer
jpmschweitzer pushed to server at jpmschweitzer/settled-reach 2026-02-19 14:50:28 +01:00
8e00db2b2d feat(simulation): #94 #99 active tier filtering and transition system
066f8031fd feat(simulation): sprint 12 server — tier system, sound events, KG access, line previewer
Compare 2 commits »