Jeroen Schweitzer

jpmschweitzer closed pull request jpmschweitzer/settled-reach#73

2026-02-27 18:53:19 +01:00

feat(client): Sprint 21 — save/load game flow + debug_overlay move

jpmschweitzer pushed to main at jpmschweitzer/settled-reach

2026-02-27 18:53:16 +01:00

64bf4ec539 fix(client): address PR #73 review — race conditions and defensive guards (#257)

c797869503 feat(client): add save/load game flow and move debug_overlay (#257, #561)

Compare 2 commits »

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#75

2026-02-27 18:46:12 +01:00

feat(simulation): Sprint 21 — template instantiation, error handling, interactions

Review: server -> main (PR #75, type: code)

Hoshe (Code Quality): REQUEST_CHANGES

Strong work — well-structured, good test coverage for happy paths. Two issues need fixing.

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#73

2026-02-27 18:46:09 +01:00

feat(client): Sprint 21 — save/load game flow + debug_overlay move

Re-review: client -> main (PR #73, round 2)

Hoshe (Code Quality): APPROVE

All 6 issues from round 1 verified fixed:

CRITICAL race condition — fixed via deferred dispatch…

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#74

2026-02-27 18:46:07 +01:00

chore(ci): move db/connectors/ to tooling/db/ (#274)

Re-review: ci -> main (PR #74, round 2)

Hoshe (Code Quality): REQUEST_CHANGES

Both previous fixes verified correct. One new parity gap found.

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#75

2026-02-27 18:33:37 +01:00

feat(simulation): Sprint 21 — template instantiation, error handling, interactions

Tyre (Architecture) — PR #75 Review

Verdict: REQUEST_CHANGES

Summary: This is strong, well-structured work. The template instantiation pipeline is clean, the three-phase spawn model…

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#75

2026-02-27 18:26:07 +01:00

feat(simulation): Sprint 21 — template instantiation, error handling, interactions

Test comment to verify tool is working

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#73

2026-02-27 18:07:42 +01:00

feat(client): Sprint 21 — save/load game flow + debug_overlay move

All review comments addressed in 64bf4ec:

Hoshe (Code Quality):

✅ Critical — LOAD_GAME race: deferred dispatch until SimBridge reaches CONNECTED (test mode dispatches synchronously,…

jpmschweitzer pushed to client at jpmschweitzer/settled-reach

2026-02-27 18:06:20 +01:00

64bf4ec539 fix(client): address PR #73 review — race conditions and defensive guards (#257)

jpmschweitzer created pull request jpmschweitzer/settled-reach#75

2026-02-27 18:04:17 +01:00

feat(simulation): Sprint 21 — template instantiation, error handling, interactions

jpmschweitzer pushed to server at jpmschweitzer/settled-reach

2026-02-27 18:00:01 +01:00

88fc6c30dc feat(simulation): template instantiation engine — load, spawn, lifecycle (#161)

b6340f9663 fix(simulation): clean up warnings in spawn and template modules (#166)

ace5cb811f wip(simulation): template-to-instance mapping — spawn_template_npcs (#166)

6f39df884c feat(simulation): tier 2 template definition format — FullTemplateDef with tests (#159)

d31ac1cc70 feat(simulation): error handling and recovery — panic supervision, state hash, structured errors (#85)

Compare 24 commits »

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#74

2026-02-27 17:51:56 +01:00

chore(ci): move db/connectors/ to tooling/db/ (#274)

Review comments addressed in ccff595:

Hoshe #1 (agent memory stale paths): Updated locally (gitignored, not in diff)
Hoshe #2 (missing decision permission): Added `Bash(db/connectors/d…

jpmschweitzer pushed to ci at jpmschweitzer/settled-reach

2026-02-27 17:51:15 +01:00

ccff595101 fix(ci): address PR #74 review comments

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#73

2026-02-27 17:44:39 +01:00

feat(client): Sprint 21 — save/load game flow + debug_overlay move

Review: client -> main (PR #73, type: code)

Hoshe (Code Quality): REQUEST_CHANGES

Save/load flow has a critical race condition in live mode.

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#74

2026-02-27 17:44:38 +01:00

chore(ci): move db/connectors/ to tooling/db/ (#274)

Review: ci -> main (PR #74, type: code)

Hoshe (Code Quality): REQUEST_CHANGES

Clean move overall — path calculations are correct, symlink is valid, hot paths updated. Two gaps need…

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#74

2026-02-27 11:14:12 +01:00

chore(ci): move db/connectors/ to tooling/db/ (#274)

Review APPROVED - see details below

jpmschweitzer pushed to planning at jpmschweitzer/settled-reach

2026-02-27 11:11:03 +01:00

a44a1081bc docs(docs): record D-110–D-112 — z-level addressing, subterranean architecture, no instancing

jpmschweitzer created pull request jpmschweitzer/settled-reach#74

2026-02-27 11:10:09 +01:00

chore(ci): move db/connectors/ to tooling/db/ (#274)

jpmschweitzer pushed to ci at jpmschweitzer/settled-reach

2026-02-27 11:09:48 +01:00

0ab81961dc chore(meta): sync Cargo.lock version after main merge

2893366a6f chore(meta): update changelog

bc226d8baf chore(db): move db/connectors/ to tooling/db/ (#274)

93e050f3bf chore(db): backup database after sprint 21 merges

d8497962c6 Merge branch 'planning'

Compare 62 commits »

jpmschweitzer created pull request jpmschweitzer/settled-reach#73

2026-02-27 11:08:55 +01:00

feat(client): Sprint 21 — save/load game flow + debug_overlay move