Jeroen Schweitzer jpmschweitzer
  • Joined on 2025-11-14
jpmschweitzer closed pull request jpmschweitzer/settled-reach#113 2026-04-05 10:17:35 +02:00
feat(client): Sprint 31 — star map popup, god object decomposition, gdlint zero
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-04-05 10:17:28 +02:00
bee93ddbb7 Merge remote-tracking branch 'origin/sprint-31/client'
4eb54a6f7a fix(client): resolve all gdlint warnings — zero warnings policy
260eefcdd1 refactor(client): decompose main.gd and game_state.gd god objects
8eb9e0a383 feat(ui): star map click-through with wiki/GTTR popup and edge visibility
Compare 4 commits »
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#113 2026-04-05 10:16:58 +02:00
feat(client): Sprint 31 — star map popup, god object decomposition, gdlint zero

Review: sprint-31/client -> main (type: code)

Reviewers: Hoshe (code quality), Tyre (architecture)

Hoshe (Code Quality): APPROVE

All three tickets correct. Decomposition verified — no…

jpmschweitzer created pull request jpmschweitzer/settled-reach#113 2026-04-05 10:00:23 +02:00
feat(client): Sprint 31 — star map popup, god object decomposition, gdlint zero
jpmschweitzer pushed to sprint-31/client at jpmschweitzer/settled-reach 2026-04-05 10:00:09 +02:00
4eb54a6f7a fix(client): resolve all gdlint warnings — zero warnings policy
260eefcdd1 refactor(client): decompose main.gd and game_state.gd god objects
8eb9e0a383 feat(ui): star map click-through with wiki/GTTR popup and edge visibility
Compare 3 commits »
jpmschweitzer created branch sprint-31/client in jpmschweitzer/settled-reach 2026-04-05 10:00:09 +02:00
jpmschweitzer closed pull request jpmschweitzer/settled-reach#111 2026-04-05 09:59:59 +02:00
refactor(simulation): Sprint 31 — split atlas.rs into modules
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#111 2026-04-05 09:59:58 +02:00
refactor(simulation): Sprint 31 — split atlas.rs into modules

Review Round 2: APPROVED

Changelog fix confirmed — server/CHANGELOG.md deleted, entry moved to root CHANGELOG.md under [Unreleased].

Merged to main.

jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-04-05 09:59:54 +02:00
5941ff791f Merge remote-tracking branch 'origin/sprint-31/server'
65bcbd0aa7 fix(meta): move changelog entry to root CHANGELOG.md
fe788a0ae3 fix(simulation): rustfmt long argument lists in atlas dispatch
1640c880da fix(simulation): suppress clippy too_many_arguments on cmd_add_body
7f23185035 chore(meta): update changelog
Compare 6 commits »
jpmschweitzer pushed to sprint-31/server at jpmschweitzer/settled-reach 2026-04-05 09:57:01 +02:00
65bcbd0aa7 fix(meta): move changelog entry to root CHANGELOG.md
jpmschweitzer closed pull request jpmschweitzer/settled-reach#112 2026-04-05 09:55:00 +02:00
chore(ci): Sprint 31 — ruff linting + shared DB module
jpmschweitzer closed pull request jpmschweitzer/settled-reach#110 2026-04-05 09:54:59 +02:00
data(copy): Sprint 31 — cultural sweep, GTTR depth, wiki quality
jpmschweitzer pushed to main at jpmschweitzer/settled-reach 2026-04-05 09:54:53 +02:00
784bcbf034 Merge remote-tracking branch 'origin/sprint-31/copy'
742d51a3c4 Merge remote-tracking branch 'origin/sprint-31/ci'
84c3314924 fix(skills): sprint-start team branch must not run pr-review
f60ae48769 chore(meta): update changelog
74d6aee0c1 chore(ci): add ruff to pre-push hook and Makefile
Compare 14 commits »
jpmschweitzer commented on pull request jpmschweitzer/settled-reach#112 2026-04-05 09:54:26 +02:00
chore(ci): Sprint 31 — ruff linting + shared DB module

Review: sprint-31/ci -> main (type: code)

Reviewers: Hoshe (code quality), Tyre (architecture)

Hoshe (Code Quality): APPROVE

Shared module correctly extracts duplicated patterns. All…

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#111 2026-04-05 09:54:26 +02:00
refactor(simulation): Sprint 31 — split atlas.rs into modules

Review: sprint-31/server -> main (type: code)

Reviewers: Hoshe (code quality), Tyre (architecture)

Hoshe (Code Quality): REQUEST_CHANGES

Refactor is correct — all 16 subcommands…

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#110 2026-04-05 09:54:25 +02:00
data(copy): Sprint 31 — cultural sweep, GTTR depth, wiki quality

Review: sprint-31/copy -> main (type: copy)

Reviewers: Hoshe (QA), Paula (narrative depth), Miri (world consistency)

Hoshe (QA): APPROVE

25 per-body GTTR files structurally clean,…

jpmschweitzer commented on pull request jpmschweitzer/settled-reach#110 2026-04-05 09:48:35 +02:00
data(copy): Sprint 31 — cultural sweep, GTTR depth, wiki quality

Process fix added: sprint-start step 9b now explicitly instructs team leads to NOT run /pr-review from the team worktree. Team windows push the PR and wait — reviews run from main.

Commit…

jpmschweitzer pushed to sprint-31/copy at jpmschweitzer/settled-reach 2026-04-05 09:47:54 +02:00
84c3314924 fix(skills): sprint-start team branch must not run pr-review
jpmschweitzer created pull request jpmschweitzer/settled-reach#112 2026-04-05 09:41:54 +02:00
chore(ci): Sprint 31 — ruff linting + shared DB module
jpmschweitzer pushed to sprint-31/ci at jpmschweitzer/settled-reach 2026-04-05 09:41:29 +02:00
f60ae48769 chore(meta): update changelog
74d6aee0c1 chore(ci): add ruff to pre-push hook and Makefile
2300d9659d fix(tooling): remove unused imports flagged by ruff
980201fb49 chore(db): wire ensure_venv() into connector scripts
d86ebada8d refactor(db): extract shared DB module from duplicated patterns
Compare 5 commits »