jpmschweitzerandClaude Opus 5
a384ec0c7c
reach godot parse-sweep / cold-parse, reach visual diff / blank-check / thumbnail. Five scripts retired, and the callers rewired — tests/run-visual invoked three of them by path at four sites, which is a wider blast radius than the make targets were. The godot pair were grep pipelines encoding five hard-won lessons as comments nobody could test. They are Python filters now, with the reasons attached, and the engine invocation is a guarded exec. Verified on the real client: 229 scripts, clean. Their three not-ok states stay distinct, because only one is a verdict about the code. An engine that crashed or is missing is not a parse failure — reporting it as one blames the tree for a broken toolchain. A sweep that emitted no completion marker checked nothing, and zero errors from a check that never ran reads as clean, which is the false-green the sweep exists to close. The deliberate asymmetry between the two checks is preserved and documented: cold-parse filters "Cannot infer the type", the sweep does not, because that suppression is why cold-parse stayed silent about a helper that genuinely does not parse. All three visual scripts carried the same root bug as validate-checklist: Path(__file__).parent.parent, correct at tooling/ and two levels too deep at tooling/domains/visual. Fixed during the move rather than after, having learned that it fails silently — paths resolve to nothing, the work appears to have nothing to do, and the tool reports success. Three domains now where that would have shipped a false pass. Two bugs my own transformation introduced, both found by running rather than reading. Multi-line print(..., file=sys.stderr) became console.event(..., file=sys.stderr), and console puts unknown kwargs into the payload — a file object would have reached json.dumps at the exact moment something was already being reported as an error. And the replacement script wrote escaped quotes into three files. Mechanical transformations need mechanical verification. sys.exit removed from four sites: a service must not end the process. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
33 lines
1.0 KiB
Python
33 lines
1.0 KiB
Python
"""Data shapes for the `godot` domain."""
|
|
|
|
from __future__ import annotations
|
|
|
|
from pydantic import BaseModel, ConfigDict
|
|
|
|
|
|
class ParseResult(BaseModel):
|
|
"""The outcome of a parse check.
|
|
|
|
Three distinct not-ok states, kept apart because they mean different things
|
|
and only one of them is a verdict about the code:
|
|
|
|
- `engine_failed` — godot itself crashed or is missing. NOT a parse verdict,
|
|
and reporting it as one would blame the tree for a broken toolchain.
|
|
- `did_not_run` — the sweep produced no completion marker, so it checked
|
|
nothing. Zero errors from a check that never ran reads as clean, which is
|
|
the false-green this exists to close.
|
|
- `lines` non-empty — genuine parse failures.
|
|
"""
|
|
|
|
model_config = ConfigDict(frozen=True)
|
|
|
|
lines: list[str] = []
|
|
summary: str = ""
|
|
engine_failed: bool = False
|
|
engine_exit: int = 0
|
|
did_not_run: bool = False
|
|
|
|
@property
|
|
def ok(self) -> bool:
|
|
return not (self.lines or self.engine_failed or self.did_not_run)
|