One-char fix: the log10_floor doctest imported server::bps::log10_floor, but the library crate is settled_reach_server, so cargo test --doc failed to compile the example. Pre-existing since the helper landed in #145; only surfaces under --doc (the pre-push gate runs --lib).
Test plan
cargo test --doc bps now passes (1 passed).
Flagged during PR #149 review as out-of-scope; fixed here separately.
## Summary
One-char fix: the `log10_floor` doctest imported `server::bps::log10_floor`, but the library crate is `settled_reach_server`, so `cargo test --doc` failed to compile the example. Pre-existing since the helper landed in #145; only surfaces under `--doc` (the pre-push gate runs `--lib`).
## Test plan
- `cargo test --doc bps` now passes (1 passed).
Flagged during PR #149 review as out-of-scope; fixed here separately.
The doctest imported `server::bps::log10_floor`, but the library crate is
`settled_reach_server` — so `cargo test --doc` failed to compile the
example (unresolved module `server`). Broken since the helper landed in
#145; it only surfaces under `--doc`, not `--lib`, so the pre-push gate
(which runs `--lib`) never caught it.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Summary
One-char fix: the
log10_floordoctest importedserver::bps::log10_floor, but the library crate issettled_reach_server, socargo test --docfailed to compile the example. Pre-existing since the helper landed in #145; only surfaces under--doc(the pre-push gate runs--lib).Test plan
cargo test --doc bpsnow passes (1 passed).Flagged during PR #149 review as out-of-scope; fixed here separately.
Pull request closed