feat(client): AI-Enhanced Dialogue toggle, PlatformInfo OS abstraction #90
Assignees
jpmschweitzer (Jeroen Schweitzer)
Clear assignees
jpmschweitzer (Jeroen Schweitzer)
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: jpmschweitzer/settled-reach#90
Reference in New Issue
Block a user
Summary
get_diagnostics()helper for bug reports. 23 properties, 1 signal, 2 methods.Commits
01b0583feat(ui): AI-Enhanced Dialogue toggle + hardware detection (#646, D-138)d7a4e32feat(ui): PlatformInfo abstraction + battery detection + fixes (#646 D-138)12d25cefeat(ui): expand PlatformInfo to full D-141 Tier 1 interface41d16d0fix(ui): toggle stays clickable during battery suspend — D-138 player autonomy73b4f37fix(ui): include all 7 path properties in PlatformInfo.get_diagnostics()9108e5dfeat(ui): add get_battery_warning_visible() getter to settings_dialog623e2e2docs(decisions): D-141 PlatformInfo OS abstraction, resolve Q-059d3ed73btest(client): Sprint 26 AI dialogue + PlatformInfo tests23e6890chore(meta): update changelogTest plan
🤖 Generated with Claude Code
Platform abstraction: - New PlatformInfo autoload (extends Node, registered first in project.godot). Owns all OS queries: power state monitoring (30s poll), memory (on demand), file path resolution (user_data_dir, config_dir, benchmark_cache_path, install_dir, executable_path, cache_dir, model_dir). - PowerProfile enum (FULL/BATTERY/POWER_SAVER), power_profile_changed signal. Uses OS.callv("get_power_info") to defer resolution to runtime — avoids compile errors on Godot 4.6 headless builds without power API. HardwareDetector refactor: - check_ram() now delegates to PlatformInfo.refresh_memory() + free_memory_mb. All direct OS.get_memory_info() calls removed. - classify_power_state(int) and should_suspend_inference(int) delegate to PlatformInfo for single source of truth. - check_power_state() → {power_state, classification, should_suspend}. - Battery suspend/resume: on PowerProfile.BATTERY, stores pre-battery pref and sends ChangeSettings(false) to server. On FULL restore, sends ChangeSettings with saved pref if it was enabled. inference_suspended member tracks state. Settings dialog: - is_ai_inference_suspended() / set_ai_inference_suspended(bool) — testable API per Hoshe's test contract. Reads HardwareDetector.inference_suspended on open. - Toggle now disabled when battery-suspended OR hardware fails (not only fail). - get_ai_dialogue_label_text() wired to UIStrings ("settings.ai_dialogue_toggle") instead of hardcoded string. Cleanup: - Deleted ai_dialogue_detector.gd and .uid (orphaned duplicate, dead code). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>Review: client -> main (type: code) — PR #90
Hoshe (Code Quality): REQUEST_CHANGES
Well-structured feature with extensive tests. PlatformInfo and HardwareDetector are cleanly separated. Four issues need addressing before merge.
SimBridge.send_input()with no connection state guard — will bounce back on reconnect if toggled before server connectsread_benchmark_cache()opens FileAccess but doesn't close explicitly — useFileAccess.get_file_as_string()insteadval— no fallback for plainboolorpush_warningon mismatch_pre_battery_prefinitialized totruebut not synced fromGameStateafterload_ai_pref()— narrow race on startup-on-battery"red"status caught by"marginal", "yellow", "red"arm → gets yellow dot, not red — likely logic errorTyre (Architecture): APPROVE
Clean architectural work. PlatformInfo correctly centralizes OS queries behind a single seam. The layered separation (PlatformInfo → HardwareDetector → SettingsDialog) follows existing autoload patterns and respects D-010 information boundaries. Wire protocol additions are consistent with existing encode/decode patterns. D-141 properly filed.
val["Bool"]extraction is fragile if serde encoding changesDebugConsole.PREFS_PATHcreates compile-time dependency on DebugConsoleVerdict: CHANGES REQUESTED
Hoshe's 4 warnings need to be addressed. The connection guard on the settings toggle (#1) and the status dot color logic (#6) are the most impactful.
W1/A2: add SimBridge.CONNECTED guard before send_input in toggle handler W2/A1: assert PlatformInfo != null in HardwareDetector._ready(); add ordering comment in project.godot [autoload] section W3: replace FileAccess.open() with get_file_as_string() in read_benchmark_cache() — auto-closes, no leak W4/A3: add _extract_bool_setting() helper in game_state.gd that handles both {"Bool": true} and plain bool; push_warning on type mismatch S5: sync _pre_battery_pref from GameState after load_ai_pref() in HardwareDetector._ready() — closes race if system starts on battery S6: separate "red" TPT status into its own arm with STATUS_RED dot and label colour — three-colour mapping: green/yellow/red now distinct A4: replace DebugConsole.PREFS_PATH compile-time dependency in _save_ai_pref() with local SETTINGS_CFG_PATH constant S7 (battery CI guard) already applied by Hoshe in test file. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>Re-review: client -> main (type: code) — PR #90
Hoshe (Code Quality): APPROVE
All 7 previous issues fixed. One new suggestion (non-blocking).
New suggestion: Battery warning label tests don't call
dialog.open()so_build_ui()never runs — tests pass/fail for the wrong reason. Production path is correct.Tyre (Architecture): APPROVE
All 4 previous suggestions addressed. No new issues. Architecture is clean — PlatformInfo as OS abstraction, HardwareDetector as classification/policy, SettingsDialog as presentation.
Verdict: APPROVED — merged into main.
Pull request closed