docs(assets): per-class production briefs, deferral register + araminta briefing rewrite #213

Closed

jpmschweitzer wants to merge 0 commits from asset-class-stories into main

pull from: asset-class-stories

merge into: :main

:main

Conversation 2 Commits - Files Changed -

jpmschweitzer commented 2026-07-25 23:01:53 +02:00

Owner

Copy Link

Copy Source

Summary

Batch-6 visual track: T-1049 + T-1053, on the conventions T-1050/T-1052 merged yesterday.

T-1049 (araminta): the asset-brief template (scope/visual-reference/naming/gen-path/acceptance, one page) + five real briefs — station walls, rural walls, doors, floors, furniture/props — each citing its D-235 axis + palette.md register rows (or the D-257 toon default), conventions.md rules, and the image-gen→glb-gen→promotion path with concrete acceptance. docs/assets/briefs/deferred.md is the formal deferral register for the T-1051 four (lamp posts/barns/TVs/billboards) + cars (Q-067), with rationale and revisit triggers — it satisfies T-1051's 'or record formal deferral' deliverable. Child stories under T-961 are created lead-side at merge (drafted list in the ticket flow).

T-1053 (qatux): docs/briefings/araminta.md fully rewritten from the 2026-03-13 v0.2-pivot shape to the current Phase-4 landscape — points at palette.md/conventions.md as live authorities instead of restating them; every dropped v0.2-era decision citation individually verified. Side-finding: D-126/D-131 have been REPURPOSED since the era docs cited them (ID drift, wrong-decision citations) — sweep filed as T-1199.

Test plan

• Docs only; no code paths, no rendered changes (no eyeball owed)
• Pre-push gate green
• Brief citations spot-verified against D-235 token list, palette.md §3, conventions.md; deferral register grounded in the ratified batch-6 ruling recorded on T-1049

## Summary Batch-6 visual track: T-1049 + T-1053, on the conventions T-1050/T-1052 merged yesterday. **T-1049 (araminta):** the asset-brief template (scope/visual-reference/naming/gen-path/acceptance, one page) + five real briefs — station walls, rural walls, doors, floors, furniture/props — each citing its D-235 axis + palette.md register rows (or the D-257 toon default), conventions.md rules, and the image-gen→glb-gen→promotion path with concrete acceptance. docs/assets/briefs/deferred.md is the formal deferral register for the T-1051 four (lamp posts/barns/TVs/billboards) + cars (Q-067), with rationale and revisit triggers — it satisfies T-1051's 'or record formal deferral' deliverable. Child stories under T-961 are created lead-side at merge (drafted list in the ticket flow). **T-1053 (qatux):** docs/briefings/araminta.md fully rewritten from the 2026-03-13 v0.2-pivot shape to the current Phase-4 landscape — points at palette.md/conventions.md as live authorities instead of restating them; every dropped v0.2-era decision citation individually verified. Side-finding: D-126/D-131 have been REPURPOSED since the era docs cited them (ID drift, wrong-decision citations) — sweep filed as T-1199. ## Test plan - Docs only; no code paths, no rendered changes (no eyeball owed) - Pre-push gate green - Brief citations spot-verified against D-235 token list, palette.md §3, conventions.md; deferral register grounded in the ratified batch-6 ruling recorded on T-1049

jpmschweitzer added 2 commits 2026-07-25 23:01:54 +02:00

docs(assets): per-class production briefs + template + formal deferral register (T-1049) ... 2bac820c77

The asset-brief template (scope/visual-reference/naming/gen-path/
acceptance, one page) and five real briefs — station walls, rural walls,
doors, floors, furniture/props — each citing its D-235 axis tokens and
palette.md register rows (or the D-257 toon default), conventions.md
naming/mask/footprint rules, and the image-gen -> glb-gen -> promotion
path with concrete acceptance counts. Doors carry the negative
no-state-frame-files constraint (runtime mechanism stays Phase 5);
furniture/props' first acceptance is promoting the three unpromoted
spike GLBs. deferred.md is the formal register for the T-1051 four
(lamp posts, barns, TVs, billboards) + cars/Q-067, with rationale and
revisit triggers — satisfying T-1051's own 'or record formal deferral'
deliverable. Child stories under T-961 are created lead-side at merge.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

docs(briefings): rewrite araminta.md around the Phase-4 landscape (T-1053) ... 2e9bbcaaf2

Replaces the 2026-03-13 v0.2-pivot briefing (sprite pipeline, dropped
scope framing, pre-Atlas) with the current shape: palette.md +
conventions.md as the live authorities the briefing points at rather
than restates, her standing rulings (category-first naming, D-257
toon/glazing) marked as hers to extend, D-235 co-maintenance with Miri,
the wardrobe pipeline as reference model, D-255 stepped Atlas as active
co-designed work, and her real open items (T-1049, D-257 shader,
Q-119, T-1198). Every v0.2-era decision citation verified before
dropping: D-114/D-117 superseded; D-119/D-122/D-128/D-135 live but not
hers; D-033/D-045 kept. D-126/D-131 found REPURPOSED to unrelated
content since the era docs cited them — the ID-drift sweep is T-1199.
Lead added the briefs/ + deferred.md pointers (araminta's cross-agent
note; her SendMessage to the author couldn't be delivered).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

jpmschweitzer commented 2026-07-25 23:06:51 +02:00

Author

Owner

Copy Link

Copy Source

Review: asset-class-stories -> main (type: docs)

Reviewers: Hoshe (QA) + Tyre (architecture/governance). Both REQUEST_CHANGES.

Hoshe (QA): REQUEST_CHANGES

#	File	Issue
1	briefs/doors.md §1/§3	DoorSpec state list conflates two struct fields: TemporalWindow is a member of the separate credential field (None/TemporalWindow(hours)/Corporate/Resident/Authority/Social), NOT of initial_state (Open/Closed/Locked/Sealed) per D-231's actual struct. Load-bearing — §3's premise is "the runtime mechanism attaches to these states."
2	briefs/furniture-props.md §1/§5/xrefs	Prior-art inventory undercounts the brief's own scope: the spike has FIVE GLBs — 3 furniture (counted) + props/lion_statue.glb (real, unpromoted, props-category prior art per this brief's own definition — uncounted) + props/vw_beetle.glb (correctly excluded, deferred car). Acceptance and cross-refs must account for the statue.
3	briefings/araminta.md D-033 bullet	States the entity palette "active, unchanged since 2026-02-11" but omits the live D-154 amendment (relationship colors shown only in the insert/perception overlay; normal gameplay uses uniform dark outlines) — against the rewrite's own verify-before-restating standard. palette.md inherits the same D-154 gap in its restated D-033 content — folded into this fix round as leave-cleaner.

Verified clean (no action): the overwhelming majority of citations — D-235 tokens, palette/conventions section refs, D-228/D-231/D-235/D-241/D-244/D-257, Q-067's audit quote, all cross-links — check out; station-walls/rural-walls citation work precise throughout.

Tyre (architecture/governance): REQUEST_CHANGES

#	File	Issue
1	briefings/araminta.md:146	The D-257 glazing ruling cited as "recorded (palette.md §2.3)" — §2.3 is "What this does NOT change"; the carve-out spec lives in §2.1 (rationale §2.2). All five briefs cite §2.1 correctly; the briefing is the sole outlier, and it's the institutional-memory doc.
2	briefs/deferred.md (+ wall briefs' scope)	The register presents itself as the complete accounting of unbriefed classes but silently omits three of D-235's four axes: roof (7 tags), facade (8), street (7) get no brief, no deferral, no acknowledgment. Defensible on ratified-scope grounds, but the register must be honest: add a sentence stating roof/facade/street textures ride the wall-brief convention (object_tag_map_type naming per conventions.md §3) as a follow-on within the class family.

Tyre's rulings on record: the deferral register does NOT need its own D-record (Q-067 precedent + the git-tracked T-1049 ratification + deferred.md suffice; a D-record would add overhead with no new constraint); the five briefs stay cleanly within Phase-4 scope; doors correctly defers the runtime mechanism without designing it; Q-119 held-not-resolved consistently; no overlap with the styled-buildings cluster (T-977/T-988/T-994 done, T-1004 parked); the briefing correctly DROPPED the v0.2-era decision list rather than repurposing it (the D-126/D-131 drift claim lives in T-1199, not the briefing — nothing to verify in-file).

Verdict: CHANGES REQUESTED

Fix round dispatched to the authoring agents (araminta: H1/H2/T2 + the palette.md D-154 leave-cleaner; qatux: T1/H3). Lead verifies, commits, re-pushes, merges.

# Review: asset-class-stories -> main (type: docs) Reviewers: Hoshe (QA) + Tyre (architecture/governance). Both REQUEST_CHANGES. ## Hoshe (QA): REQUEST_CHANGES | # | File | Issue | |---|------|-------| | 1 | briefs/doors.md §1/§3 | DoorSpec state list conflates two struct fields: `TemporalWindow` is a member of the separate `credential` field (None/TemporalWindow(hours)/Corporate/Resident/Authority/Social), NOT of `initial_state` (Open/Closed/Locked/Sealed) per D-231's actual struct. Load-bearing — §3's premise is "the runtime mechanism attaches to these states." | | 2 | briefs/furniture-props.md §1/§5/xrefs | Prior-art inventory undercounts the brief's own scope: the spike has FIVE GLBs — 3 furniture (counted) + `props/lion_statue.glb` (real, unpromoted, props-category prior art per this brief's own definition — uncounted) + `props/vw_beetle.glb` (correctly excluded, deferred car). Acceptance and cross-refs must account for the statue. | | 3 | briefings/araminta.md D-033 bullet | States the entity palette "active, unchanged since 2026-02-11" but omits the live D-154 amendment (relationship colors shown only in the insert/perception overlay; normal gameplay uses uniform dark outlines) — against the rewrite's own verify-before-restating standard. palette.md inherits the same D-154 gap in its restated D-033 content — folded into this fix round as leave-cleaner. | Verified clean (no action): the overwhelming majority of citations — D-235 tokens, palette/conventions section refs, D-228/D-231/D-235/D-241/D-244/D-257, Q-067's audit quote, all cross-links — check out; station-walls/rural-walls citation work precise throughout. ## Tyre (architecture/governance): REQUEST_CHANGES | # | File | Issue | |---|------|-------| | 1 | briefings/araminta.md:146 | The D-257 glazing ruling cited as "recorded (palette.md §2.3)" — §2.3 is "What this does NOT change"; the carve-out spec lives in §2.1 (rationale §2.2). All five briefs cite §2.1 correctly; the briefing is the sole outlier, and it's the institutional-memory doc. | | 2 | briefs/deferred.md (+ wall briefs' scope) | The register presents itself as the complete accounting of unbriefed classes but silently omits three of D-235's four axes: roof (7 tags), facade (8), street (7) get no brief, no deferral, no acknowledgment. Defensible on ratified-scope grounds, but the register must be honest: add a sentence stating roof/facade/street textures ride the wall-brief convention (object_tag_map_type naming per conventions.md §3) as a follow-on within the class family. | Tyre's rulings on record: the deferral register does NOT need its own D-record (Q-067 precedent + the git-tracked T-1049 ratification + deferred.md suffice; a D-record would add overhead with no new constraint); the five briefs stay cleanly within Phase-4 scope; doors correctly defers the runtime mechanism without designing it; Q-119 held-not-resolved consistently; no overlap with the styled-buildings cluster (T-977/T-988/T-994 done, T-1004 parked); the briefing correctly DROPPED the v0.2-era decision list rather than repurposing it (the D-126/D-131 drift claim lives in T-1199, not the briefing — nothing to verify in-file). ## Verdict: CHANGES REQUESTED Fix round dispatched to the authoring agents (araminta: H1/H2/T2 + the palette.md D-154 leave-cleaner; qatux: T1/H3). Lead verifies, commits, re-pushes, merges.

jpmschweitzer referenced this issue from a commit 2026-07-25 23:10:19 +02:00

docs(assets): PR #213 review fixes — DoorSpec fields, spike inventory, axis honesty, D-154

jpmschweitzer added 1 commit 2026-07-25 23:10:19 +02:00

docs(assets): PR #213 review fixes — DoorSpec fields, spike inventory, axis honesty, D-154 ... 660f4a703f

doors.md now presents D-231's actual struct shape (initial_state
Open/Closed/Locked/Sealed; TemporalWindow lives in the independent
credential field) and attaches the Phase-5 runtime bridge to
initial_state only. furniture-props.md inventories all five spike GLBs
— acceptance is 4 promotable (3 furniture + lion_statue), vw_beetle
explicitly excluded to the Q-067 deferral. deferred.md + station-walls
gain the axis-completeness note: roof/facade/street textures ride the
wall-brief convention as a same-family follow-on, so the register
accounts for all four D-235 axes. The briefing's D-257 pointer
corrected to palette.md §2.1–2.2, and both the briefing and palette.md
(leave-cleaner, gap inherited from PR #211) now carry D-154's amendment
to D-033 — relationship colors display only in the insert/perception
overlay; normal gameplay is a uniform #1a1a1a outline (D-150).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

jpmschweitzer commented 2026-07-25 23:10:32 +02:00

Author

Owner

Copy Link

Copy Source

Fix round — all 5 findings addressed in 660f4a703

Reviewer	#	Resolution
Hoshe	1	Fixed — doors.md §1/§3 now present D-231's actual struct: initial_state (Open/Closed/Locked/Sealed) and the independent credential field (None/TemporalWindow(hours)/Corporate/Resident/Authority/Social); the Phase-5 runtime bridge attaches to initial_state only
Hoshe	2	Fixed — furniture-props.md inventories all five spike GLBs; acceptance is now 4 promotable (3 furniture + lion_statue), cross-refs include models/props/, vw_beetle explicitly excluded to the Q-067 deferral. (Note: the spike GLB binaries are gitignored per D-241, so the inventory is sourced from spike_main.gd's own load list — the same source the review verified)
Hoshe	3	Fixed — the briefing's D-033 bullet now carries the full display chain: D-033 palette → D-154 insert-overlay-only restriction → D-150 uniform #1a1a1a outline; D-150 added to the citation list and decisions/scope.md — D-154 to Key Documents (previously uncited anywhere in the briefing). Leave-cleaner: palette.md's inherited D-154 gap fixed too — §4 row, appendix rows, and decision_refs frontmatter
Tyre	1	Fixed — briefing's glazing pointer corrected §2.3 → §2.1–2.2, verified against palette.md's actual section titles
Tyre	2	Fixed — deferred.md gains the axis-completeness note (roof/facade/street textures ride the wall-brief <object_tag>_<map_type>.png convention as a same-family follow-on, not additional deferred classes), plus a forward-note in station-walls.md §1. Tyre's no-D-record ruling for the register is accepted and on the record

No retractions — all five findings accurate. Gate re-run green on push. Merging; child stories under T-961 and the T-1051 delivered-by-deferral close follow lead-side at merge per the T-1049 ratification.

# Fix round — all 5 findings addressed in `660f4a703` | Reviewer | # | Resolution | |----------|---|------------| | Hoshe | 1 | **Fixed** — doors.md §1/§3 now present D-231's actual struct: `initial_state` (Open/Closed/Locked/Sealed) and the independent `credential` field (None/TemporalWindow(hours)/Corporate/Resident/Authority/Social); the Phase-5 runtime bridge attaches to `initial_state` only | | Hoshe | 2 | **Fixed** — furniture-props.md inventories all five spike GLBs; acceptance is now 4 promotable (3 furniture + `lion_statue`), cross-refs include `models/props/`, `vw_beetle` explicitly excluded to the Q-067 deferral. (Note: the spike GLB binaries are gitignored per D-241, so the inventory is sourced from `spike_main.gd`'s own load list — the same source the review verified) | | Hoshe | 3 | **Fixed** — the briefing's D-033 bullet now carries the full display chain: D-033 palette → D-154 insert-overlay-only restriction → D-150 uniform `#1a1a1a` outline; D-150 added to the citation list and `decisions/scope.md — D-154` to Key Documents (previously uncited anywhere in the briefing). **Leave-cleaner:** palette.md's inherited D-154 gap fixed too — §4 row, appendix rows, and `decision_refs` frontmatter | | Tyre | 1 | **Fixed** — briefing's glazing pointer corrected §2.3 → §2.1–2.2, verified against palette.md's actual section titles | | Tyre | 2 | **Fixed** — deferred.md gains the axis-completeness note (roof/facade/street textures ride the wall-brief `<object_tag>_<map_type>.png` convention as a same-family follow-on, not additional deferred classes), plus a forward-note in station-walls.md §1. Tyre's no-D-record ruling for the register is accepted and on the record | No retractions — all five findings accurate. Gate re-run green on push. Merging; child stories under T-961 and the T-1051 delivered-by-deferral close follow lead-side at merge per the T-1049 ratification.

jpmschweitzer closed this pull request 2026-07-25 23:12:28 +02:00

jpmschweitzer referenced this pull request 2026-07-26 12:59:23 +02:00

data(assets): first production environment assets — four spike GLBs promoted (T-1204) #214

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No labels

Milestone

No items

No Milestone

Projects

Clear projects

No projects

Assignees

Clear assignees

jpmschweitzer (Jeroen Schweitzer)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: jpmschweitzer/settled-reach#213