jpmschweitzer/settled-reach
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(wiki): Sprint 30 wiki quality fixes and atlas regressions #107

Closed
jpmschweitzer wants to merge 0 commits from copy into main
pull from: copy
merge into: :main
Conversation 3 Commits - Files Changed -
jpmschweitzer commented 2026-04-03 22:48:01 +02:00
Owner
Copy Link
Copy Source

Summary

  • #763 (high): Rewrite GJ1111/GJ54.1 prose — populations rebalanced to 380K/320K planet + 1M/860K station, mid-tier framing
  • #772 (medium): Author Brandpunt (GJ 3943) — Afrikaans agricultural research station, subverts pastoral stereotype (15:1 imbalance)
  • #753: Fix Mabuhay — GJ 482A is Dagat (settled), not unsurveyed
  • #757–#771: 15 targeted fixes — spectral class corrections, header/profile mismatches, schema normalization, stale calibration notes, topology, population, etymology

30 files changed across 18 tickets. All reviewed by Paula (narrative) before commit.

Closes #753 #754 #755 #756 #757 #758 #759 #760 #761 #763 #764 #765 #767 #768 #769 #770 #771 #772.

## Summary - **#763** (high): Rewrite GJ1111/GJ54.1 prose — populations rebalanced to 380K/320K planet + 1M/860K station, mid-tier framing - **#772** (medium): Author Brandpunt (GJ 3943) — Afrikaans agricultural research station, subverts pastoral stereotype (15:1 imbalance) - **#753**: Fix Mabuhay — GJ 482A is Dagat (settled), not unsurveyed - **#757–#771**: 15 targeted fixes — spectral class corrections, header/profile mismatches, schema normalization, stale calibration notes, topology, population, etymology 30 files changed across 18 tickets. All reviewed by Paula (narrative) before commit. Closes #753 #754 #755 #756 #757 #758 #759 #760 #761 #763 #764 #765 #767 #768 #769 #770 #771 #772.
jpmschweitzer added 1 commit 2026-04-03 22:48:01 +02:00
fix(wiki): Sprint 30 — wiki quality fixes, atlas regressions, Brandpunt authoring f8b0b17252 
High priority:
- #763: Rewrite GJ1111/GJ54.1 prose for population rebalance (380K/320K
  planet + 1M/860K station = mid-tier systems, not megahubs)

Medium priority:
- #772: Author Brandpunt (GJ 3943) — Afrikaans agricultural research
  station, subverts pastoral/frontier stereotype
- #753: Fix Mabuhay (GJ 1073) — GJ 482A is Dagat, not unsurveyed
- #757: Fix Pereira's Rest population 800 → 42K
- #758: Fix Langemark schema values (breathable→standard, rivers-lakes, west_reach)
- #759: Fix Solheim topology disconnect
- #764: Fix GJ1111 star_type unusual → M
- #767: Fix GJ707 star_type/spectral_class swap
- #769: Fix GJ-147 etymology passagem → Entremeio
- #770: Fix GJ-875 header G-type → K-type

Low priority:
- #754: Update stale Calibration Notes (GJ1128, GJ136, GJ625)
- #755: Fix GJ432A Punjabi-Canadian → Punjabi heritage
- #756: Fix GJ541 header G-type → K-type (K2IIIp)
- #760: Add F2III context to GJ601A notes
- #761: Fix GJ4056 spectral_class g → M3V
- #765: Add calibration notes for intentional small populations
- #768: Reconcile GJ189 wave_2 at hop 8-11
- #771: Fix GJ-7547/GJ-6711 spectral class truncation

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jpmschweitzer commented 2026-04-04 08:47:30 +02:00
Author
Owner
Copy Link
Copy Source

QA review — Sprint 30 wiki quality fixes (#107)

Reviewed by: Hoshe (QA)
Files reviewed: 30 changed files (29 text + 1 binary excluded)
Tickets cross-referenced: #753, #754, #755, #756, #757, #758, #759, #760, #761, #763, #764, #765, #767, #768, #769, #770, #771, #772

Verdict: REQUEST_CHANGES

Two issues require correction before merge. One is a new error introduced by this PR (incorrect math in a calibration note). One is an incomplete fix from ticket #770 (catalog.md not updated to match the wiki header correction).

Issues

FAIL — catalog.md GJ 875 still shows G-type (ticket #770 incomplete)

File: wiki/star-systems/catalog.md line 334
Severity: Medium

Ticket #770 fixed the GJ-875 wiki header from G-type to K-type. The catalog entry was not updated:

| [GJ 875](GJ-875/index.md) | — | G-type | 14 | unsettled | through_route | 2 |

The wiki header now says K-type. The catalog still says G-type. These are inconsistent. The fix is one character — change G-type to K-type in catalog.md line 334.

FAIL — GJ-1111 calibration note math does not match proposal (new error introduced by this PR)

File: wiki/star-systems/GJ-1111/index.md calibration note (added by this PR for ticket #765)
Severity: Medium

The calibration note introduced by this PR states:

The ~1.46M total population is intentionally structured

The proposal populations are:

  • GJ1111b (Qina, planet): 380,000
  • GJ1111-oort-S1 (Zenzele Horizon, station): 1,200,000
  • GJ1111b-S1 (Isivikelo, industrial station): 86,000
  • Total: 1,666,000 (~1.67M)

The stated "~1.46M" does not match the proposal. Additionally, the wiki body table displays the horizon station as 1M rather than 1.2M — this was a pre-existing display error in the table, but the calibration note added by this PR hardcodes the wrong total rather than matching the actual proposal figures.

Fix options:

  1. Update the calibration note to say ~1.67M total (matching the proposal), and update the station table display from 1M to 1.2M
  2. Or: if the intent is 1.46M total, update the proposal to 980K for the horizon station and fix the note accordingly

The ~1.46M figure appears to derive from 380K + 1,080K — neither value matches any field in the current proposal.

Passing checks

All other ticket fixes verified clean:

Ticket Description Result
#753 Mabuhay GJ 1073 — GJ 482A continuity, Dagat references PASS
#754 Stale calibration notes GJ1128, GJ136, GJ625 PASS
#755 GJ432A Punjabi-Canadian → Punjabi heritage PASS
#756 GJ541 header G-type → K-type PASS
#757 Pereira's Rest population 800 → 42K (both instances) PASS
#758 Langemark GJ42 schema normalization (breathable/rivers-lakes/west_reach fixed) PASS
#760 GJ601A F2III stellar evolution context in notes PASS
#761 GJ4056 spectral_class g → M4V, star_type → M PASS
#763 GJ1111 + GJ54.1 prose rebalanced to new populations PASS (prose correct; math error noted above)
#764 GJ1111 star_type regression (unusual → M) PASS
#765 Calibration notes for divergent populations (GJ905, GJ54.1) PASS for GJ905 and GJ54.1; GJ1111 note has math error
#767 GJ707 star_type/spectral_class fields swapped (binary/K4V+K8V) PASS
#768 GJ189 wave_2/hop_8 reconciliation — calibration note added PASS
#769 GJ147 etymology passagem → entremeio PASS
#770 GJ875 header G-type → K-type PARTIAL — wiki fixed, catalog.md not updated
#771 GJ7547 K → K4V, GJ6711 K → K3V PASS
#772 Brandpunt (GJ3943) authoring — Afrikaans research station PASS

GJ-3943 / Brandpunt (major change — full check)

  • Proposal proper_name: Brandpunt — matches wiki h1 and header
  • star_type: binary, spectral_class: K5V+M3V — matches wiki profile table
  • inhabited_count: 1 — consistent (Skuiling on GJ3943b)
  • planet population 1,800 — matches wiki body table (1.8K) and prose
  • station population 120 — matches wiki station table
  • station name: Brandpunt Horizon — matches wiki
  • Adjacent systems: GJ 421B (Pedra Seca), GJ 546 (Eerste Wacht) — consistent across wiki topology, station notes, and Pedra Seca/Eerste Wacht wiki updates
  • gttr.md: updated title, Adams rating, all content consistent with index.md
  • catalog.md entry updated: Brandpunt, binary, wave_5 — correct
  • gttr-deep.md updated — correct

All Brandpunt-adjacent wiki updates (GJ-421B, GJ-546) are internally consistent with the new settlement.

Pre-existing observation (not blocking)

GJ-707 wiki header says binary-type while GJ-3943 says binary. These are the only two binary systems in the current scope. The catalog shows binary for both. GJ-707 was not touched by this PR, so this is pre-existing — recommend a follow-up ticket to normalize GJ-707's header.

QA review — Sprint 30 wiki quality fixes (#107) **Reviewed by:** Hoshe (QA) **Files reviewed:** 30 changed files (29 text + 1 binary excluded) **Tickets cross-referenced:** #753, #754, #755, #756, #757, #758, #759, #760, #761, #763, #764, #765, #767, #768, #769, #770, #771, #772 --- ## Verdict: REQUEST_CHANGES Two issues require correction before merge. One is a new error introduced by this PR (incorrect math in a calibration note). One is an incomplete fix from ticket #770 (catalog.md not updated to match the wiki header correction). --- ## Issues ### FAIL — catalog.md GJ 875 still shows G-type (ticket #770 incomplete) **File:** `wiki/star-systems/catalog.md` line 334 **Severity:** Medium Ticket #770 fixed the GJ-875 wiki header from G-type to K-type. The catalog entry was not updated: ``` | [GJ 875](GJ-875/index.md) | — | G-type | 14 | unsettled | through_route | 2 | ``` The wiki header now says `K-type`. The catalog still says `G-type`. These are inconsistent. The fix is one character — change `G-type` to `K-type` in catalog.md line 334. --- ### FAIL — GJ-1111 calibration note math does not match proposal (new error introduced by this PR) **File:** `wiki/star-systems/GJ-1111/index.md` calibration note (added by this PR for ticket #765) **Severity:** Medium The calibration note introduced by this PR states: > The ~1.46M total population is intentionally structured The proposal populations are: - `GJ1111b` (Qina, planet): 380,000 - `GJ1111-oort-S1` (Zenzele Horizon, station): 1,200,000 - `GJ1111b-S1` (Isivikelo, industrial station): 86,000 - **Total: 1,666,000 (~1.67M)** The stated "~1.46M" does not match the proposal. Additionally, the wiki body table displays the horizon station as `1M` rather than `1.2M` — this was a pre-existing display error in the table, but the calibration note added by this PR hardcodes the wrong total rather than matching the actual proposal figures. Fix options: 1. Update the calibration note to say `~1.67M total` (matching the proposal), and update the station table display from `1M` to `1.2M` 2. Or: if the intent is 1.46M total, update the proposal to 980K for the horizon station and fix the note accordingly The `~1.46M` figure appears to derive from 380K + 1,080K — neither value matches any field in the current proposal. --- ## Passing checks All other ticket fixes verified clean: | Ticket | Description | Result | |--------|-------------|--------| | #753 | Mabuhay GJ 1073 — GJ 482A continuity, Dagat references | PASS | | #754 | Stale calibration notes GJ1128, GJ136, GJ625 | PASS | | #755 | GJ432A Punjabi-Canadian → Punjabi heritage | PASS | | #756 | GJ541 header G-type → K-type | PASS | | #757 | Pereira's Rest population 800 → 42K (both instances) | PASS | | #758 | Langemark GJ42 schema normalization (breathable/rivers-lakes/west_reach fixed) | PASS | | #760 | GJ601A F2III stellar evolution context in notes | PASS | | #761 | GJ4056 spectral_class `g` → M4V, star_type → M | PASS | | #763 | GJ1111 + GJ54.1 prose rebalanced to new populations | PASS (prose correct; math error noted above) | | #764 | GJ1111 star_type regression (unusual → M) | PASS | | #765 | Calibration notes for divergent populations (GJ905, GJ54.1) | PASS for GJ905 and GJ54.1; GJ1111 note has math error | | #767 | GJ707 star_type/spectral_class fields swapped (binary/K4V+K8V) | PASS | | #768 | GJ189 wave_2/hop_8 reconciliation — calibration note added | PASS | | #769 | GJ147 etymology passagem → entremeio | PASS | | #770 | GJ875 header G-type → K-type | PARTIAL — wiki fixed, catalog.md not updated | | #771 | GJ7547 K → K4V, GJ6711 K → K3V | PASS | | #772 | Brandpunt (GJ3943) authoring — Afrikaans research station | PASS | ### GJ-3943 / Brandpunt (major change — full check) - Proposal proper_name: Brandpunt — matches wiki h1 and header - star_type: binary, spectral_class: K5V+M3V — matches wiki profile table - inhabited_count: 1 — consistent (Skuiling on GJ3943b) - planet population 1,800 — matches wiki body table (1.8K) and prose - station population 120 — matches wiki station table - station name: Brandpunt Horizon — matches wiki - Adjacent systems: GJ 421B (Pedra Seca), GJ 546 (Eerste Wacht) — consistent across wiki topology, station notes, and Pedra Seca/Eerste Wacht wiki updates - gttr.md: updated title, Adams rating, all content consistent with index.md - catalog.md entry updated: Brandpunt, binary, wave_5 — correct - gttr-deep.md updated — correct All Brandpunt-adjacent wiki updates (GJ-421B, GJ-546) are internally consistent with the new settlement. ### Pre-existing observation (not blocking) GJ-707 wiki header says `binary-type` while GJ-3943 says `binary`. These are the only two binary systems in the current scope. The catalog shows `binary` for both. GJ-707 was not touched by this PR, so this is pre-existing — recommend a follow-up ticket to normalize GJ-707's header.
jpmschweitzer commented 2026-04-04 10:03:45 +02:00
Author
Owner
Copy Link
Copy Source

Review: copy -> main (type: copy) — Sprint 30

Reviewers: Hoshe (QA), Paula (narrative depth), Miri (world consistency)

Execution Issues (changes requested)

# File Severity Issue
1 wiki/star-systems/catalog.md:334 warning GJ 875 still shows G-type — wiki header corrected to K-type but catalog not updated
2 wiki/star-systems/catalog.md:171 warning GJ 1111 still shows unusual — should be M-type per proposal
3 wiki/star-systems/catalog.md:147 warning GJ 541 still shows G-type — proposal has star_type: "K"
4 wiki/star-systems/catalog.md:269 warning GJ 601A still shows K-type — proposal has star_type: "F"
5 wiki/star-systems/catalog.md:231 warning GJ 19 (Solheim) shows K-type — proposal has star_type: "G"
6 wiki/star-systems/catalog.md:277 warning GJ 42 (Langemark) shows M-type — proposal has star_type: "K"
7 wiki/star-systems/catalog.md:310 warning GJ 707 shows — for name — should be "Dois Sóis"
8 wiki/star-systems/GJ-1111/index.md warning Calibration note says "~1.46M total" but proposal sums to ~1.67M (380K + 1.2M + 86K)
9 docs/atlas/proposals/GJ42.json warning Moon GJ42e-2 biome_summary: "ice" — not a valid schema value, should be "frozen"

Suggestions (non-blocking)

# File Severity Issue
1 docs/atlas/proposals/GJ3943.json suggestion Station notes still contain "k-m transitional binary" freetext — structured field fixed but notes not cleaned
2 wiki/star-systems/GJ-3943/index.md suggestion "Eight specialists from five communities" but only four named before Eerste Wacht's later addition

Narrative highlights (Paula)

Brandpunt (GJ-3943) is a strong entry — the binary star science serves narrative purpose, the Compact's non-disclosure clause creates information-asymmetry dynamics, and the Afrikaans cultural subversion is structural not surface-level. GJ-147 etymology fix and population prose updates integrate cleanly.

Verdict: CHANGES REQUESTED

Common theme: catalog.md wasn't updated when wiki/proposal star types were corrected. Fix the 9 warnings above, then re-request review.

## Review: copy -> main (type: copy) — Sprint 30 Reviewers: Hoshe (QA), Paula (narrative depth), Miri (world consistency) --- ### Execution Issues (changes requested) | # | File | Severity | Issue | |---|------|----------|-------| | 1 | `wiki/star-systems/catalog.md:334` | warning | GJ 875 still shows `G-type` — wiki header corrected to `K-type` but catalog not updated | | 2 | `wiki/star-systems/catalog.md:171` | warning | GJ 1111 still shows `unusual` — should be `M-type` per proposal | | 3 | `wiki/star-systems/catalog.md:147` | warning | GJ 541 still shows `G-type` — proposal has `star_type: "K"` | | 4 | `wiki/star-systems/catalog.md:269` | warning | GJ 601A still shows `K-type` — proposal has `star_type: "F"` | | 5 | `wiki/star-systems/catalog.md:231` | warning | GJ 19 (Solheim) shows `K-type` — proposal has `star_type: "G"` | | 6 | `wiki/star-systems/catalog.md:277` | warning | GJ 42 (Langemark) shows `M-type` — proposal has `star_type: "K"` | | 7 | `wiki/star-systems/catalog.md:310` | warning | GJ 707 shows `—` for name — should be "Dois Sóis" | | 8 | `wiki/star-systems/GJ-1111/index.md` | warning | Calibration note says "~1.46M total" but proposal sums to ~1.67M (380K + 1.2M + 86K) | | 9 | `docs/atlas/proposals/GJ42.json` | warning | Moon GJ42e-2 `biome_summary: "ice"` — not a valid schema value, should be `"frozen"` | ### Suggestions (non-blocking) | # | File | Severity | Issue | |---|------|----------|-------| | 1 | `docs/atlas/proposals/GJ3943.json` | suggestion | Station notes still contain `"k-m transitional binary"` freetext — structured field fixed but notes not cleaned | | 2 | `wiki/star-systems/GJ-3943/index.md` | suggestion | "Eight specialists from five communities" but only four named before Eerste Wacht's later addition | ### Narrative highlights (Paula) Brandpunt (GJ-3943) is a strong entry — the binary star science serves narrative purpose, the Compact's non-disclosure clause creates information-asymmetry dynamics, and the Afrikaans cultural subversion is structural not surface-level. GJ-147 etymology fix and population prose updates integrate cleanly. ### Verdict: CHANGES REQUESTED Common theme: catalog.md wasn't updated when wiki/proposal star types were corrected. Fix the 9 warnings above, then re-request review.
jpmschweitzer added 1 commit 2026-04-04 13:13:37 +02:00
fix(wiki): address PR #107 review — catalog.md sync, math fix, schema fix d6b98925ed 
- catalog.md: sync star types for GJ 875 (K), GJ 1111 (M), GJ 541 (K),
  GJ 601A (F), GJ 19 (G), GJ 42 (K); add Dois Sóis name for GJ 707
- GJ-1111: fix calibration note total ~1.46M → ~1.67M, station display
  1M → 1.2M to match proposal
- GJ42 proposal: moon GJ42e-2 biome_summary ice → frozen (schema fix)
- GJ3943 proposal: station notes k-m → K5V+M3V
- GJ-3943 wiki: "five corridor communities" → "four" (Eerste Wacht
  joined later)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
jpmschweitzer closed this pull request 2026-04-04 16:04:37 +02:00
jpmschweitzer commented 2026-04-04 16:04:50 +02:00
Author
Owner
Copy Link
Copy Source

Review Round 3: APPROVED

All 9 execution issues from round 2 resolved:

  • catalog.md: 7 star type / name corrections propagated (GJ 541, 1111, 19, 601A, 42, 875, 707)
  • GJ-1111: population total corrected to ~1.67M
  • GJ42.json: biome_summary "ice" → "frozen"

Merged to main via fast-forward.

## Review Round 3: APPROVED All 9 execution issues from round 2 resolved: - catalog.md: 7 star type / name corrections propagated (GJ 541, 1111, 19, 601A, 42, 875, 707) - GJ-1111: population total corrected to ~1.67M - GJ42.json: biome_summary "ice" → "frozen" Merged to main via fast-forward.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
jpmschweitzer (Jeroen Schweitzer)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: jpmschweitzer/settled-reach#107