jpmschweitzer and Claude Opus 4.6
64897a40b3
fix(client): address PR #11 review — type safety, perf, tests
...
Add Dictionary validation in game_state visible_tiles loop to prevent
crash on malformed data (Hoshe critical). Skip redundant modulate.a
writes (Hoshe suggestion). Add 3 tests: malformed visible_tiles,
facing rotation accuracy, v1 backward compatibility. Clarify D-033
Phase 1/Phase 2 comments.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-02-12 01:07:02 +01:00
jpmschweitzer and Claude Opus 4.6
f3793bf16e
feat(client): D-033 entity colors, peripheral dimming, facing indicator ( #130 )
...
Replace hardcoded entity colors with D-033 relationship palette:
Player=#e0e8ff, Npc=unknown teal #4a9ebb, Object=grey #8b8ba0.
Phase 1 defaults by entity kind; Phase 2 (#361 ) will derive color
from RelationshipState via knowledge graph.
Entities in peripheral vision dimmed to 50% alpha (D-015).
Player entity gets a Polygon2D triangle indicator showing facing
direction, rotated from GameState.player_facing.
82 tests total, 0 failures.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-02-12 00:53:28 +01:00
jpmschweitzer and Claude Opus 4.6
aa3a3fea7d
fix(client): address PR review — invalidation, constants, tests
...
Review feedback from Hoshe + Tyre on PR #8 :
- Extract shared TILE_SIZE to Constants class_name (Tyre #5 , Hoshe #7 )
- Fix tile invalidation: detect tile/visibility count changes instead
of one-shot dirty flag, supports chunk loading (Tyre #3 , #4 )
- Fog dirty tracking: only re-render when visible_positions changes
- Add bounds warning for unknown tile types (Hoshe #1 )
- Add player-not-found warning in GameState (Hoshe #5 )
- Use Image.fill_rect() instead of pixel loops (Tyre #10 )
- Document _player_pos as reserved for fog decay #113 (Tyre #6 )
- Add TODO(#130 ) for D-033 relationship colors (Hoshe #3 , Tyre #8 )
- Add class_name to EntityRenderer, FogRenderer, TileRenderer
- 20 new rendering tests (D-030 Layer 1): entity lifecycle, fog
registration, tile type mapping, snapshot completeness, constants
- 65 total tests passing, 0 failures
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com >
2026-02-12 00:15:42 +01:00
jpmschweitzerandClaude Opus 4.6