fix(ui): address PR #90 review — 8 items (W1–W4, S5–S6, A3–A4)

W1/A2: add SimBridge.CONNECTED guard before send_input in toggle handler
W2/A1: assert PlatformInfo != null in HardwareDetector._ready();
       add ordering comment in project.godot [autoload] section
W3: replace FileAccess.open() with get_file_as_string() in
    read_benchmark_cache() — auto-closes, no leak
W4/A3: add _extract_bool_setting() helper in game_state.gd that handles
       both {"Bool": true} and plain bool; push_warning on type mismatch
S5: sync _pre_battery_pref from GameState after load_ai_pref() in
    HardwareDetector._ready() — closes race if system starts on battery
S6: separate "red" TPT status into its own arm with STATUS_RED dot and
    label colour — three-colour mapping: green/yellow/red now distinct
A4: replace DebugConsole.PREFS_PATH compile-time dependency in
    _save_ai_pref() with local SETTINGS_CFG_PATH constant

S7 (battery CI guard) already applied by Hoshe in test file.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-03-13 11:39:47 +01:00
co-authored by Claude Sonnet 4.6
parent 23e6890c4e
commit f51366b3f5
4 changed files with 37 additions and 16 deletions
+2
View File
@@ -17,6 +17,8 @@ config/icon="res://icon.svg"
[autoload]
; PlatformInfo MUST remain first — HardwareDetector (and other autoloads) depend on it
; being initialised before their own _ready() runs. Do not reorder.
PlatformInfo="*res://scripts/autoloads/platform_info.gd"
Protocol="*res://scripts/protocol/protocol.gd"
SimBridge="*res://scripts/autoloads/sim_bridge.gd"