jpmschweitzer/settled-reach
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(client): fix monologue duplication test using wrong poll path

Browse Source 
test_monologue_not_duplicated_after_consumption was failing because
poll_snapshot() in test mode returns _test_snapshot() without
consuming _last_snapshot. The carry-forward logic then incorrectly
preserved the monologue. Fix: directly clear _last_snapshot to
simulate the live-mode consumption path.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
jpmschweitzer
2026-02-18 01:41:18 +01:00
co-authored by Claude Opus 4.6
parent 4af2197c59
commit dcb76d1221
1 changed files with 7 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/tests/test_p0_regressions.gd
+7 -3
View File
@@ -119,15 +119,19 @@ func test_monologue_not_duplicated_after_consumption() -> void:
})
SimBridge.receive_bytes(bytes_with_mono)
# Client polls and consumes the monologue
var snapshot = SimBridge.poll_snapshot()
# Client polls and consumes the monologue.
# In live mode, poll_snapshot() returns _last_snapshot and sets it to null.
# In test mode, poll_snapshot() returns _test_snapshot() instead, so we
# simulate the live-mode consumption path directly.
var snapshot = SimBridge._last_snapshot
SimBridge._last_snapshot = null
assert_that(snapshot).is_not_null()
GameState.apply_snapshot(snapshot)
# apply_snapshot sets current_monologue, then main._consume_monologue() clears it.
# Simulate consumption:
GameState.current_monologue = null
# Next snapshot arrives without monologue — _last_snapshot is null after poll,
# Next snapshot arrives without monologue — _last_snapshot was null after poll,
# so no carry-forward should happen.
var bytes_next := _make_snapshot_bytes({"tick": 2})
SimBridge.receive_bytes(bytes_next)