jpmschweitzer/settled-reach
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(client): create TabContainer children programmatically

Browse Source 
Godot 4.6 TabContainer silently destroys children defined in .tscn
during scene instantiation ("Parent path has vanished"). Moving tab
shell creation to _ready() fixes the right-side settings panel.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
jpmschweitzer
2026-03-22 18:41:24 +01:00
co-authored by Claude Opus 4.6
parent 18ee89d066
commit a2ef1c34cb
2 changed files with 8 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
client/scenes/character_creation.tscn
+1 -15
View File
@@ -157,21 +157,7 @@ size_flags_vertical = 3
theme_override_font_sizes/font_size = 12
theme_override_colors/font_color = Color(0.784, 0.816, 0.878, 1.0)
; Five empty tab shells — content built programmatically in character_creation.gd
[node name="Body" type="Control" parent="Layout/TabPanel/TabContainer"]
layout_mode = 2
[node name="Head" type="Control" parent="Layout/TabPanel/TabContainer"]
layout_mode = 2
[node name="Hair" type="Control" parent="Layout/TabPanel/TabContainer"]
layout_mode = 2
[node name="Clothing" type="Control" parent="Layout/TabPanel/TabContainer"]
layout_mode = 2
[node name="Accessories" type="Control" parent="Layout/TabPanel/TabContainer"]
layout_mode = 2
; Tab shells created programmatically in character_creation.gd _ready()
; ===========================================================================
; Footer — full width, 48px tall, anchored to bottom
client/ui/character_creation.gd
+7
View File
@@ -221,6 +221,13 @@ func _ready() -> void:
_rotate_left_btn.text = UIStrings.get_text("character_creation.btn_rotate_left")
_rotate_right_btn.text = UIStrings.get_text("character_creation.btn_rotate_right")
# Create tab shells programmatically (Godot 4.6 TabContainer requires runtime children)
var tab_names: Array[String] = ["Body", "Head", "Hair", "Clothing", "Accessories"]
for tab_name in tab_names:
var tab := Control.new()
tab.name = tab_name
_tab_container.add_child(tab)
_build_body_tab(_tab_container.get_child(0))
_build_head_tab(_tab_container.get_child(1))
_build_hair_tab(_tab_container.get_child(2))