fix(simulation): address PR #2 review findings

- Fix Cargo.toml edition 2024 → 2021 (Hoshe #1)
- Switch test runner to cargo-nextest in Makefile (Hoshe #2, D-030)
- Add debug_assert tick ordering enforcement in InputQueue::push (Hoshe #4)
- Add DayPhase Serialize/Deserialize derives (Tyre #6)
- Add day phase boundary comments clarifying half-open ranges (Hoshe #3)
- Add phase duration adjustability comment (Tyre #5)
- Document ObserverSnapshot planned fields as TODO (Tyre #1)
- Document entity_id as wire-format ID, not ECS Entity (Tyre #2)
- Change Relationship.target_name to target_id: u64 (Tyre #3)
- Clarify single app.update() is intentional boilerplate (Hoshe #8, Tyre #7)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

This commit is contained in:

jpmschweitzer

2026-02-11 17:53:01 +01:00

co-authored by

Claude Opus 4.6

parent 9de1eb4aa3

commit 6bda4a7620

7 changed files with 59 additions and 7 deletions

									
										Makefile
									
		+1
		-1
	
												View File
												
				@@ -69,7 +69,7 @@ client:

				test: test-server test-client

				test-server:

					cd server && cargo test

					cd server && cargo nextest run

				test-client:

					@echo "Client tests run via gdUnit4 inside Godot."