fix(simulation): address PR #55 review — stale comment, range, duplication, docs

- Fix protocol version comment (12 → 13) in ObserverSnapshot doc
- Widen Want intensity range from 3..=9 to 1..=10 to match spec and test
- Replace duplicated pool selection in trigger_recognition_monologue with
  call to select_pool_line helper (~50 lines removed)
- Document NaiveSpatialIndex migration cost for grid/quadtree swap
- Remove misleading Default derive from TellCategory (Nervous is not a
  sensible default for neutral NPCs)
- Add caller invariant doc on generate_npc (no TilePosition spawned)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-02-21 14:55:21 +01:00
co-authored by Claude Opus 4.6
parent c0fb316a0a
commit 67cadddaf2
5 changed files with 21 additions and 51 deletions
+3 -47
View File
@@ -352,53 +352,9 @@ pub fn trigger_recognition_monologue(
};
// Try content pools for observe_anomaly trigger lines
let line = if let Some(ref content) = content {
let character = state.character.as_str();
let mut candidates: Vec<(&str, &str)> = Vec::new();
for district in content.0.districts.values() {
for pool in &district.monologue_pools {
if pool.character != character {
continue;
}
for line in &pool.lines {
if line.trigger != "observe_anomaly" {
continue;
}
if state.shown_ids.contains(&line.id) {
continue;
}
candidates.push((&line.id, &line.text));
}
}
}
if candidates.is_empty() {
// Fallback: allow repeats from content pools
for district in content.0.districts.values() {
for pool in &district.monologue_pools {
if pool.character != character {
continue;
}
for line in &pool.lines {
if line.trigger != "observe_anomaly" {
continue;
}
candidates.push((&line.id, &line.text));
}
}
}
}
if !candidates.is_empty() {
let i = rng.rng.random_range(0..candidates.len());
Some((candidates[i].0.to_string(), candidates[i].1.to_string()))
} else {
None
}
} else {
None
};
let line = content
.as_deref()
.and_then(|c| select_pool_line("observe_anomaly", &state, c, &mut rng.rng));
// Use content pool line or hardcoded fallback
let (id, text) = if let Some((id, text)) = line {