fix(client): address PR #40 review — 13 suggestions

- Rename _insert to insert_state in main.gd (Hoshe #1)
- Add after_each() to test_bug_report_ring_buffer.gd for GameState
  cleanup on assertion failure (Hoshe #2)
- Add after_each() to test_insert_off_behavior.gd for stance/interaction
  restore on assertion failure (Hoshe #3)
- Fix assertion message: "unknown" → "unavailable" (Hoshe #4)
- Document memory ceiling of 60 JSON snapshots in ring buffer (Hoshe #5)
- Add precision warning for u64 rng_seed via JSON float (Hoshe #6)
- Promote _action_enum_to_wire to public action_enum_to_wire (Tyre #1)
- Add @warning_ignore for unused _tick parameter (Tyre #5)
- Document insert_active assumption for future no-insert characters (Tyre #4)
- Restructure OQ-07 decision amendments as bullet points (Tyre #7)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

client/scripts/autoloads/game_state.gd

@@ -42,7 +42,9 @@ var gauntlet_mode: bool = false  # true when snapshot includes gauntlet_mode fla
 
 # OQ-07 (#522): Insert active state — false suppresses verb labels (z-layer 6).
 # Cursor shape changes still fire when false (D-056 option a).
-# v0.1: always true (both detective and smuggler have inserts). Server may send false in future.
+# v0.1 assumption: always true — both playable characters (detective and smuggler)
+# have neural inserts. Future characters without inserts would receive false from
+# the server's "insert_active" snapshot field, disabling all z-layer-6 UI.
 var insert_active: bool = true
 
 # #507: RNG seed for replay determinism — populated from snapshot "rng_seed" field.

client/scripts/autoloads/sim_bridge.gd

@@ -179,7 +179,7 @@ func send_input(player_input: Dictionary) -> Error:
 		return ERR_CONNECTION_ERROR
 	if test_mode:
 		var action: int = player_input.get("action", -1)
-		var wire_name: String = _action_enum_to_wire(action)
+		var wire_name: String = action_enum_to_wire(action)
 		if not wire_name.is_empty():
 			if wire_name == "SetFacing":
 				# D-054: Use action_data.facing from the input dict, not InputMapper global
@@ -192,9 +192,9 @@ func send_input(player_input: Dictionary) -> Error:
 			else:
 				_test_input_queue.append(wire_name)
 		return OK
-	var action_name := _action_enum_to_wire(player_input.get("action", -1))
+	var action_name := action_enum_to_wire(player_input.get("action", -1))
 	if action_name.is_empty():
-		# _action_enum_to_wire already emits push_warning for invalid actions
+		# action_enum_to_wire already emits push_warning for invalid actions
 		return ERR_INVALID_PARAMETER
 	# Use the server's current tick so drain_for_tick processes this input immediately.
 	# The client-side timestamp_msec is only useful for ordering within a frame.
@@ -251,7 +251,7 @@ func drain_outbound() -> Array[Dictionary]:
 
 # Map InputMapper.Action enum values to wire-format action names (matching Rust PlayerAction).
 # OPEN_MENU is client-only — no Rust equivalent, not sent over the wire.
-static func _action_enum_to_wire(action: int) -> String:
+static func action_enum_to_wire(action: int) -> String:
 	match action:
 		InputMapper.Action.MOVE_NORTH: return "MoveNorth"
 		InputMapper.Action.MOVE_NORTHEAST: return "MoveNortheast"

client/scripts/main.gd

@@ -84,13 +84,13 @@ func _process(_delta: float) -> void:
 
 		# OQ-07 (#522): propagate insert state to all z-layer-6 display nodes.
 		# Cursor shape still fires (D-056 option a) — only verb labels suppressed.
-		var _insert := GameState.insert_active
+		var insert_state := GameState.insert_active
 		if cursor_renderer and cursor_renderer.has_method("set_insert_active"):
-			cursor_renderer.set_insert_active(_insert)
+			cursor_renderer.set_insert_active(insert_state)
 		if interaction_list and interaction_list.has_method("set_insert_active"):
-			interaction_list.set_insert_active(_insert)
+			interaction_list.set_insert_active(insert_state)
 		if interaction_prompt and interaction_prompt.has_method("set_insert_active"):
-			interaction_prompt.set_insert_active(_insert)
+			interaction_prompt.set_insert_active(insert_state)
 
 		# D-057: Update interaction list from game state
 		# Suppress during dialogue — player is in conversation, verb list is noise