fix(assets): address PR #117 review comments
- Remove tracked kallast_terrain.npy (HIGH — binary in git) - Amend D-086: stance + interaction icons delivered, not deferred - Create ticket #818 for icon_tint.gdshader (client team) - Fix gas giant profile table: suppress gravity/land%/hydrosphere - Fix atmosphere_color: null when atmosphere is none - Fix gas_giant_ringed display as gas_giant in profile table - Re-scaffold + regenerate Ran system with fixes .import sidecars: not applicable — gitignored by design (client/**/*.import). Godot auto-generates on first run. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
@@ -464,7 +464,8 @@ How the player observes and interacts with the world: camera, fog, line-of-sight
|
|||||||
- **Icon vocabulary (v0.1):**
|
- **Icon vocabulary (v0.1):**
|
||||||
- Inventory item silhouettes: 3–4 items at 40×40px (manifest, access token, comm log)
|
- Inventory item silhouettes: 3–4 items at 40×40px (manifest, access token, comm log)
|
||||||
- Perception mode indicators: 2–3 icons at 20×20px (deferred until #315 specs the modes)
|
- Perception mode indicators: 2–3 icons at 20×20px (deferred until #315 specs the modes)
|
||||||
- Stance indicators: text labels (`WALK`, `CAREFUL`, `SPRINT`, `CROUCH`) at Michroma 11px — icons deferred to v0.2
|
- Stance indicators: 4 icons at 20×20px (WALK, CAREFUL, SPRINT, CROUCH) — delivered Sprint 32 alongside text labels. Icons supplement labels; text remains primary affordance.
|
||||||
|
- Interaction prompt icons: 4 icons at 16×16px (talk, observe, follow, examine) — delivered Sprint 32. Supplement interaction verb text per insert HUD wireframe §9.
|
||||||
- Border arrows and geometric markers (diamonds, dots, squares): drawn as primitives, not icons
|
- Border arrows and geometric markers (diamonds, dots, squares): drawn as primitives, not icons
|
||||||
- **Authoring constraints:** 1px stroke weight base (scaled to 2px for `lattice_augmented` via parameter), `#c8d0e0` as design reference color (runtime-replaceable), minimal anchor points, no decorative curves.
|
- **Authoring constraints:** 1px stroke weight base (scaled to 2px for `lattice_augmented` via parameter), `#c8d0e0` as design reference color (runtime-replaceable), minimal anchor points, no decorative curves.
|
||||||
- **Calibration reference:** Phosphor Light (MIT) — not for use, but for evaluating small-size readability of custom shapes during authoring. If a custom icon doesn't read as cleanly as a Phosphor Light equivalent at 16px, simplify it.
|
- **Calibration reference:** Phosphor Light (MIT) — not for use, but for evaluating small-size readability of custom shapes during authoring. If a custom icon doesn't read as cleanly as a Phosphor Light equivalent at 16px, simplify it.
|
||||||
|
|||||||
@@ -126,7 +126,7 @@ icon_material.set_shader_parameter("tint_color", Color("#c8d0e0"))
|
|||||||
icon_node.material = icon_material
|
icon_node.material = icon_material
|
||||||
```
|
```
|
||||||
|
|
||||||
The `icon_tint.gdshader` (to be authored by client team) multiplies the SVG's existing stroke color by the `tint_color` parameter. Since all SVGs use `#c8d0e0` as their stroke, the default parameter leaves them unchanged; swapping the parameter recolors them at runtime.
|
The `icon_tint.gdshader` (to be authored by client team, ticket #818) multiplies the SVG's existing color by the `tint_color` parameter. Must handle both stroke-based icons (most) and fill-based icons (health cross). Since all SVGs use `#c8d0e0` as their base color, the default parameter leaves them unchanged; swapping the parameter recolors them at runtime.
|
||||||
|
|
||||||
### 3.3 Sizing at non-native resolutions
|
### 3.3 Sizing at non-native resolutions
|
||||||
|
|
||||||
|
|||||||
Binary file not shown.
@@ -456,6 +456,8 @@ def _build_body_def(
|
|||||||
"barren": None,
|
"barren": None,
|
||||||
}
|
}
|
||||||
atmo_color = atmo_colors.get(planet_class)
|
atmo_color = atmo_colors.get(planet_class)
|
||||||
|
if atmo_density == "none":
|
||||||
|
atmo_color = None # no atmosphere = no rim glow
|
||||||
atmo_color = ov.get("atmosphere_color", atmo_color)
|
atmo_color = ov.get("atmosphere_color", atmo_color)
|
||||||
|
|
||||||
# ── Land fraction ─────────────────────────────────────────────────────
|
# ── Land fraction ─────────────────────────────────────────────────────
|
||||||
|
|||||||
@@ -99,7 +99,7 @@ def _body_prose(bd: dict, system_dir: Path) -> str:
|
|||||||
# Profile table
|
# Profile table
|
||||||
lines.append("## Profile")
|
lines.append("## Profile")
|
||||||
lines.append("")
|
lines.append("")
|
||||||
is_gas = pclass in ("gas_giant",)
|
is_gas = pclass in ("gas_giant", "gas_giant_ringed")
|
||||||
|
|
||||||
lines.append("| | |")
|
lines.append("| | |")
|
||||||
lines.append("|---|---|")
|
lines.append("|---|---|")
|
||||||
|
|||||||
@@ -17,10 +17,7 @@ physical:
|
|||||||
gravity_g: 0.08
|
gravity_g: 0.08
|
||||||
oblateness: 0.0029
|
oblateness: 0.0029
|
||||||
atmosphere: none
|
atmosphere: none
|
||||||
atmosphere_color:
|
atmosphere_color: null
|
||||||
- 0.75
|
|
||||||
- 0.88
|
|
||||||
- 1.0
|
|
||||||
terrain:
|
terrain:
|
||||||
land_fraction: 0.837
|
land_fraction: 0.837
|
||||||
polar_ice_lat: 0.177
|
polar_ice_lat: 0.177
|
||||||
|
|||||||
Reference in New Issue
Block a user