mirror of
https://github.com/pewdiepie-archdaemon/odysseus.git
synced 2026-10-15 19:32:21 +02:00
Alexandre TeixeiraandLéo
f1a47f3812
* refactor(notes): decompose Notes into feature-owned modules * fix(notes): avoid HTML interpolation in reminder picker * docs(notes): drop checkpoint archives, session logs and publication drafts The N0-N6 tarballs and raw pytest/node logs are not read by any script or test, and the logs carry absolute home-directory paths. Once squashed into dev they would stay in history for good. notes-pr.md and notes-issue.md were the drafts used to open #6712 and #6713, not documentation. notes-validation.md keeps the counts, the checkpoint hashes and implementation.sha256 as the record; local interpreter paths and the local Docker image name are replaced with portable placeholders. * fix(notes): keep the state store raw and stop masonry re-observing after close - state: writes built from views (filter, spread, splice) stored nested read-only views in the store, so structuredClone on a stored note threw DataCloneError. Store writes now unwrap nested views. - layout: a save that resolves after closePanel re-renders the leaving pane and re-created the masonry ResizeObserver that teardown had disposed. Skip creating it once Notes is closed. - index.js: drop 30 imported or declared names that were never used and group the imports at the top. Import order is unchanged. - Revert unrelated punctuation edits in .gitattributes and keep the header comment and docstring first in compare/vote.js and test_notes_dom_xss_helpers.py. Both fixes have a node test that fails on the previous head. * test(notes): make script rejection assertion case-insensitive Address CodeQL js/bad-tag-filter alert #1150 in test-only assertion and refresh Notes evidence manifest checksum. --------- Co-authored-by: Léo <leograndcontact@gmail.com>
70 lines
3.1 KiB
JavaScript
70 lines
3.1 KiB
JavaScript
/** Editor submission ordering, optimistic state, reminder rearming and save recovery. */
|
|
export function createNotesSubmission({
|
|
app,
|
|
api,
|
|
persistence,
|
|
clock,
|
|
uid,
|
|
effects,
|
|
fetchNotes
|
|
}) {
|
|
const state = app.state;
|
|
const { _loadFiredReminders, _saveFiredReminders, _loadGlowedReminders, _saveGlowedReminders, _loadDraft, _clearDraft } = persistence;
|
|
function submitNote(payload, note, isEdit) {
|
|
// Reset fired reminder if due_date changed (so re-arm works), and also
|
|
// clear the entry-glow seen flag so the new firing glows again on the
|
|
// next time the user opens the panel.
|
|
if (isEdit && note.due_date !== payload.due_date) {
|
|
const fired = _loadFiredReminders();
|
|
fired.delete(note.id);
|
|
_saveFiredReminders(fired);
|
|
const glowed = _loadGlowedReminders();
|
|
glowed.delete(note.id);
|
|
_saveGlowedReminders(glowed);
|
|
effects.clearGlow(note.id);
|
|
}
|
|
// Edited notes move to the top of their section (under pinned). Compute
|
|
// sort_order = (min unpinned sort_order) - 1 so the saved note sorts above
|
|
// siblings; the pin block keeps its own ordering above this.
|
|
if (!payload.pinned) {
|
|
// Both edits AND newly-created notes anchor above the rest of the
|
|
// unpinned section. Without this, freshly created notes sit at the
|
|
// bottom because manually-reordered siblings already carry negative
|
|
// sort_order values.
|
|
const minUnpinned = state.notes
|
|
.filter(n => !n.pinned && (!isEdit || n.id !== note.id))
|
|
.reduce((m, n) => Math.min(m, n.sort_order || 0), 0);
|
|
payload.sort_order = minUnpinned - 1;
|
|
}
|
|
// Optimistic update : update local state first, render, then save in background
|
|
app.setEditingId(null);
|
|
const draftId = isEdit ? note.id : '__new__';
|
|
const submittedDraft = JSON.stringify(_loadDraft(draftId));
|
|
if (isEdit) {
|
|
const idx = state.notes.findIndex(n => n.id === note.id);
|
|
if (idx >= 0) app.replaceNoteAt(idx, { ...state.notes[idx], ...payload });
|
|
} else {
|
|
app.prependNote({ ...payload, id: 'tmp_' + uid(), created_at: new Date(clock.now()).toISOString(), updated_at: new Date(clock.now()).toISOString() });
|
|
}
|
|
effects.render();
|
|
// Background save
|
|
api.saveNote(payload).then(saved => {
|
|
if (JSON.stringify(_loadDraft(draftId)) === submittedDraft) _clearDraft(draftId);
|
|
if (!isEdit && saved && saved.id) {
|
|
// Replace temp ID with real one from server. AND re-render : the
|
|
// existing card's `data-note-id="tmp_xxx"` is stale after Object.assign
|
|
// bumps the in-memory id, so all subsequent clicks (edit, done, copy,
|
|
// archive, delete) silently fail to find the note in `_notes`.
|
|
const tmp = state.notes.find(n => n.id.startsWith('tmp_'));
|
|
if (tmp) app.mergeNote(tmp, saved);
|
|
effects.render();
|
|
}
|
|
}).catch(err => {
|
|
effects.showError('Save failed: ' + err.message);
|
|
fetchNotes().then(() => effects.render());
|
|
});
|
|
|
|
}
|
|
return { submitNote };
|
|
}
|