Files
odysseus/tests/test_tool_header_icons_static.py
T
Léo 1323fab0bd refactor(tests): read the whole cascade instead of style.css alone
static/style.css no longer holds every rule. 79 rules for the document,
gallery and editor panels now live in static/css/, yet 27 browser tests still
built their synthetic page with a single <link> to style.css, and 51 more read
that one file as though it were the whole cascade. Those tests kept passing
while covering less: a rule that moved became invisible to the assertion that
was meant to pin it.

Python readers now call tests.helpers.stylesheets.app_css(), and synthetic
pages are built from stylesheet_link_tags() so they load exactly what
index.html loads, in the same order. The helper already existed; this moves
the remaining callers onto it.

test_portal_dropdown_z_js parametrised over a file list including style.css to
assert an absence. Checking a negative against one file of a split stylesheet
is how a moved rule escapes, so the CSS case now checks the concatenation.

Two guards keep it from coming back: one fails on any test reading
static/style.css directly, the other on any synthetic page linking it alone.
Both name the helper to use.

No production code changes. Suite is unchanged at 6 pre-existing failures.
2026-09-29 17:05:29 +02:00

47 lines
2.0 KiB
Python

from pathlib import Path
from tests.helpers.stylesheets import app_css
ROOT = Path(__file__).resolve().parents[1]
def test_tool_header_has_semantic_icons_for_live_and_saved_calls():
chat = (ROOT / "static/js/chat.js").read_text(encoding="utf-8")
renderer = (ROOT / "static/js/chatRenderer.js").read_text(encoding="utf-8")
css = app_css()
assert "manage_calendar" in renderer
assert "manage_memory" in renderer
assert "manage_skills" in renderer
assert "manage_notes" in renderer
assert "getToolIcon" in renderer or "TOOL_ICONS" in renderer
assert "renderToolIcon" in chat
assert "agent-thread-tool-icon" in renderer
assert ".agent-thread-tool-icon" in css
assert ".agent-thread-tool-icon svg" in css
def test_tool_icons_are_navigation_targets_and_calendar_has_one_icon_path():
chat = (ROOT / "static/js/chat.js").read_text(encoding="utf-8")
renderer = (ROOT / "static/js/chatRenderer.js").read_text(encoding="utf-8")
agent_loop = (ROOT / "src/agent_loop.py").read_text(encoding="utf-8")
assert "export function getToolActionTarget" in renderer
assert "export function renderToolIcon" in renderer
assert "href === '#plan'" in renderer
assert "fallback: 'memory'" in renderer
assert "renderToolIcon(json.tool, cmd, json)" in chat
assert "headerActionHtml: ''" in chat
assert '"memory_id", "note_id", "note_title", "task_id"' in agent_loop
def test_tool_icon_stays_before_label_when_stream_finishes_and_after_reload():
chat = (ROOT / "static/js/chat.js").read_text(encoding="utf-8")
renderer = (ROOT / "static/js/chatRenderer.js").read_text(encoding="utf-8")
live_done = chat[chat.index('currentToolBubble.innerHTML = `<div class="agent-thread-dot"'):][:700]
saved_done = renderer[renderer.index('node.innerHTML = `<div class="agent-thread-dot"', renderer.index("const evToolIcon")):][:700]
assert live_done.index("${toolIcon2}") < live_done.index('class="agent-thread-tool"')
assert saved_done.index("${evToolIcon}") < saved_done.index('class="agent-thread-tool"')