mirror of
https://github.com/pewdiepie-archdaemon/odysseus.git
synced 2026-11-01 10:42:23 +01:00
39303f19cd
* fix(editor): stabilize image workflows and editing controls
* docs(editor): add desktop and mobile visual validation evidence
* fix(editor): synchronize quick edit model events and register imagePreferences in test coordinator
* fix(settings): enforce authoritative global image-gen policy and non-admin preference persistence
- Enforce authoritative administrator global image_gen_enabled disable in get_user_setting, do_generate_image, and image_editing_provider_available, preventing non-admin user preference overrides while preserving user-disabled opt-outs and can_generate_images privilege checks across direct, gallery, and editor paths.
- Filter non-admin preference persistence in saveImagePreferences to user preference keys only (image_model, image_edit_model, image_quality), preventing global policy toggles from leaking into user preferences.
- Return accurate 200 OK Response from saveImagePreferences after fallback persistence succeeds so settings UI displays 'Saved' instead of false 403 error, while retaining visibility of real errors.
- Load per-user preferences via readImagePreferences in initImageSettings so non-admin selections persist and display correctly after page reload.
- Clear per-user model preferences on successful admin save (POST /api/auth/settings) via PUT /api/prefs/{key} with value: null to prevent stale per-user preferences from shadowing updated global settings.
- Support clearing keys in PUT /api/prefs/{key} when value is null.
- Add comprehensive Python regression tests for global-disabled/user-enabled, global-enabled/user-disabled, and authorized generation, plus Node and browser regression tests for non-admin persistence, toggle isolation, reload, and admin clearing.
* fix(settings): invalidate shared appConfig cache near auth settings write
* fix(test): isolate test_tool_policy unit suite from external model endpoint state
* fix(test): isolate web_fetch failure regression from contextual follow-up heuristics
* fix(test): isolate test_tool_policy from cross-test approval gate state
Ensure _patch_loop_basics disables TOOL_APPROVAL_GATE_ENABLED so routing tests in test_tool_policy run in the intended opt-out posture even when prior tests populate DATA_DIR with skills or untrusted context. Remove unnecessary forced_tools and contextual web mock workarounds.
* fix(settings): isolate non-admin image toggle and surface preference cleanup errors
- Restrict image generation availability toggle to admin users in imageModels.js, disabling the switch for non-admins and reverting unauthorized changes with an explicit message.
- Separate non-admin image model preference saves from global toggle updates.
- Track preference cleanup results on admin save in imagePreferences.js, propagating cleanup failures instead of ignoring them.
- Require valid preference keys on 403 fallback so toggle-only attempts reject cleanly.
- Add /api/prefs route mock to test_image_model_settings_sync_both_directions_and_survive_reopening.
- Add regression coverage for admin cleanup failures and non-admin toggle rejection.
* fix(settings): reconcile admin toggle on partial cleanup failure and report errors
- In imagePreferences.js, distinguish pre-persistence failures from post-save cleanup failures using err.globalSaved and err.phase.
- In imagePreferences.js, notify listeners of global policy updates on partial success before propagating cleanup failure.
- In imageModels.js, retain the persisted target state on admin toggle when global persistence succeeds but cleanup fails.
- In imageModels.js, reconcile admin toggle with authoritative server state via readImagePreferences() after ambiguous or partial failures.
- In imageModels.js, report partial success accurately without suppressing preference cleanup error messages.
- Add regression coverage in test_settings_save_response_ok_js.py for cleanup HTTP 500, cleanup network rejection, successful cleanup, and failed global POST.
---------
Co-authored-by: pewdiepie-archdaemon <pewdiepie-archdaemon@users.noreply.github.com>
Co-authored-by: Alexandre Teixeira <general@alexandreteixeira.dev>
63 lines
3.1 KiB
Python
63 lines
3.1 KiB
Python
from pathlib import Path
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[1]
|
|
|
|
|
|
def test_delete_shortcut_delegates_to_guarded_layer_deletion_after_selection_paths():
|
|
keyboard = (ROOT / "static/js/editor/keyboard-shortcuts.js").read_text(encoding="utf-8")
|
|
panel = (ROOT / "static/js/editor/layer-panel.js").read_text(encoding="utf-8")
|
|
|
|
assert "deleteSelectedLayers" in keyboard
|
|
assert "duplicateActiveLayer" in keyboard
|
|
assert "state.wandMask" in keyboard
|
|
assert "state.lassoPoints.length >= 3" in keyboard
|
|
assert "state.transformActive || state.cropping || state.cropMoving" in keyboard
|
|
assert "activeGroupMask" in keyboard
|
|
assert "deleteSelectedLayers: () => deleteLayers(selectedLayers(state))" in panel
|
|
assert "duplicateActiveLayer: () =>" in panel
|
|
|
|
|
|
def test_deleting_the_last_layer_is_allowed():
|
|
panel = (ROOT / "static/js/editor/layer-panel.js").read_text(encoding="utf-8")
|
|
# Every layer (including the final one) can be deleted; the document is then
|
|
# an empty canvas rather than a blocked action.
|
|
assert "Keep at least one layer" not in panel
|
|
assert "if (fallback) selectOnlyLayer(state, fallback.id);" in panel
|
|
assert "else { state.activeLayerId = null; state.selectedLayerIds = []; state.activeGroupId = null; }" in panel
|
|
|
|
|
|
def test_enter_confirms_the_transform_even_from_a_transform_field():
|
|
keyboard = (ROOT / "static/js/editor/keyboard-shortcuts.js").read_text(encoding="utf-8")
|
|
# A form field would normally swallow Enter; an active transform must still
|
|
# accept when Enter is pressed from one of its number inputs.
|
|
assert "!(state.transformActive && e.key === 'Enter')) return;" in keyboard
|
|
assert "if (e.key === 'Enter' && state.transformActive) {" in keyboard
|
|
assert "confirmTransform();" in keyboard
|
|
|
|
|
|
def test_ctrl_zoom_shortcuts_drive_the_toolbar_and_override_the_browser():
|
|
keyboard = (ROOT / "static/js/editor/keyboard-shortcuts.js").read_text(encoding="utf-8")
|
|
# Ctrl/Cmd +/-/0 zoom the canvas (they call the toolbar zoom buttons and
|
|
# preventDefault so they win over the browser's page zoom).
|
|
assert "document.getElementById('ge-zoom-in')?.click();" in keyboard
|
|
assert "document.getElementById('ge-zoom-out')?.click();" in keyboard
|
|
assert "document.getElementById('ge-zoom-100')?.click();" in keyboard
|
|
assert "e.code === 'NumpadAdd'" in keyboard
|
|
assert "e.code === 'NumpadSubtract'" in keyboard
|
|
|
|
|
|
def test_ctrl_alt_l_opens_the_levels_adjustment():
|
|
keyboard = (ROOT / "static/js/editor/keyboard-shortcuts.js").read_text(encoding="utf-8")
|
|
# Open layer-local controls without creating/committing a new adjustment layer.
|
|
assert "e.altKey && e.code === 'KeyL'" in keyboard
|
|
assert "openLayerAdjustment?.('levels');" in keyboard
|
|
|
|
|
|
def test_ctrl_alt_shift_e_stamps_the_visible_layers():
|
|
keyboard = (ROOT / "static/js/editor/keyboard-shortcuts.js").read_text(encoding="utf-8")
|
|
# Photoshop's Stamp Visible reuses the layer footer's "Flatten Copy", which
|
|
# merges every visible layer into a new layer on top and keeps the originals.
|
|
assert "e.altKey && e.shiftKey && e.code === 'KeyE'" in keyboard
|
|
assert "document.getElementById('ge-flatten')" in keyboard
|