mirror of
https://github.com/pewdiepie-archdaemon/odysseus.git
synced 2026-11-01 10:42:23 +01:00
39303f19cd
* fix(editor): stabilize image workflows and editing controls
* docs(editor): add desktop and mobile visual validation evidence
* fix(editor): synchronize quick edit model events and register imagePreferences in test coordinator
* fix(settings): enforce authoritative global image-gen policy and non-admin preference persistence
- Enforce authoritative administrator global image_gen_enabled disable in get_user_setting, do_generate_image, and image_editing_provider_available, preventing non-admin user preference overrides while preserving user-disabled opt-outs and can_generate_images privilege checks across direct, gallery, and editor paths.
- Filter non-admin preference persistence in saveImagePreferences to user preference keys only (image_model, image_edit_model, image_quality), preventing global policy toggles from leaking into user preferences.
- Return accurate 200 OK Response from saveImagePreferences after fallback persistence succeeds so settings UI displays 'Saved' instead of false 403 error, while retaining visibility of real errors.
- Load per-user preferences via readImagePreferences in initImageSettings so non-admin selections persist and display correctly after page reload.
- Clear per-user model preferences on successful admin save (POST /api/auth/settings) via PUT /api/prefs/{key} with value: null to prevent stale per-user preferences from shadowing updated global settings.
- Support clearing keys in PUT /api/prefs/{key} when value is null.
- Add comprehensive Python regression tests for global-disabled/user-enabled, global-enabled/user-disabled, and authorized generation, plus Node and browser regression tests for non-admin persistence, toggle isolation, reload, and admin clearing.
* fix(settings): invalidate shared appConfig cache near auth settings write
* fix(test): isolate test_tool_policy unit suite from external model endpoint state
* fix(test): isolate web_fetch failure regression from contextual follow-up heuristics
* fix(test): isolate test_tool_policy from cross-test approval gate state
Ensure _patch_loop_basics disables TOOL_APPROVAL_GATE_ENABLED so routing tests in test_tool_policy run in the intended opt-out posture even when prior tests populate DATA_DIR with skills or untrusted context. Remove unnecessary forced_tools and contextual web mock workarounds.
* fix(settings): isolate non-admin image toggle and surface preference cleanup errors
- Restrict image generation availability toggle to admin users in imageModels.js, disabling the switch for non-admins and reverting unauthorized changes with an explicit message.
- Separate non-admin image model preference saves from global toggle updates.
- Track preference cleanup results on admin save in imagePreferences.js, propagating cleanup failures instead of ignoring them.
- Require valid preference keys on 403 fallback so toggle-only attempts reject cleanly.
- Add /api/prefs route mock to test_image_model_settings_sync_both_directions_and_survive_reopening.
- Add regression coverage for admin cleanup failures and non-admin toggle rejection.
* fix(settings): reconcile admin toggle on partial cleanup failure and report errors
- In imagePreferences.js, distinguish pre-persistence failures from post-save cleanup failures using err.globalSaved and err.phase.
- In imagePreferences.js, notify listeners of global policy updates on partial success before propagating cleanup failure.
- In imageModels.js, retain the persisted target state on admin toggle when global persistence succeeds but cleanup fails.
- In imageModels.js, reconcile admin toggle with authoritative server state via readImagePreferences() after ambiguous or partial failures.
- In imageModels.js, report partial success accurately without suppressing preference cleanup error messages.
- Add regression coverage in test_settings_save_response_ok_js.py for cleanup HTTP 500, cleanup network rejection, successful cleanup, and failed global POST.
---------
Co-authored-by: pewdiepie-archdaemon <pewdiepie-archdaemon@users.noreply.github.com>
Co-authored-by: Alexandre Teixeira <general@alexandreteixeira.dev>
58 lines
2.3 KiB
JavaScript
58 lines
2.3 KiB
JavaScript
/**
|
|
* Photoshop-style nested flyout menus for the editor topbar.
|
|
*
|
|
* A `.ge-menu-parent` row reveals its sibling `.ge-submenu` panel. Hover is
|
|
* handled in CSS; this wires the click toggle (and aligns the flyout with the
|
|
* clicked row). The children stay in the same menu subtree, so the existing
|
|
* delegated `[data-*-action]` handlers keep firing.
|
|
*
|
|
* Shared by the Image / Filter / Selection menus (wire-topbar-menus.js) and
|
|
* the Window > Workspace submenu (wire-extra-menus.js).
|
|
*/
|
|
export function wireSubmenuToggles(menu) {
|
|
menu.addEventListener('mouseover', (e) => {
|
|
if (e.target.closest('.ge-menu-parent, .ge-submenu')) {
|
|
menu.classList.add('ge-flyout-open');
|
|
}
|
|
});
|
|
menu.addEventListener('mouseleave', () => {
|
|
if (!menu.querySelector('.ge-menu-parent.open')) {
|
|
menu.classList.remove('ge-flyout-open');
|
|
}
|
|
});
|
|
function positionPanel(parent) {
|
|
const panel = parent.nextElementSibling;
|
|
if (!panel?.classList.contains('ge-submenu')) return;
|
|
const row = parent.getBoundingClientRect();
|
|
const origin = (panel.offsetParent || menu).getBoundingClientRect();
|
|
const top = Math.max(8, Math.min(row.top, window.innerHeight - panel.offsetHeight - 8));
|
|
const left = row.right + panel.offsetWidth > window.innerWidth - 8
|
|
? Math.max(8, row.left - panel.offsetWidth) : row.right - 2;
|
|
panel.style.top = `${top - origin.top + (panel.offsetParent?.scrollTop || 0)}px`;
|
|
panel.style.left = `${left - origin.left + (panel.offsetParent?.scrollLeft || 0)}px`;
|
|
}
|
|
for (const eventName of ['pointerover', 'focusin']) {
|
|
menu.addEventListener(eventName, (event) => {
|
|
const parent = event.target.closest('.ge-menu-parent');
|
|
if (parent) positionPanel(parent);
|
|
});
|
|
}
|
|
menu.addEventListener('click', (e) => {
|
|
const parent = e.target.closest('.ge-menu-parent');
|
|
if (!parent) return;
|
|
e.stopPropagation();
|
|
const willOpen = !parent.classList.contains('open');
|
|
menu.querySelectorAll('.ge-menu-parent.open').forEach((other) => {
|
|
if (other === parent) return;
|
|
other.classList.remove('open');
|
|
other.setAttribute('aria-expanded', 'false');
|
|
});
|
|
parent.classList.toggle('open', willOpen);
|
|
parent.setAttribute('aria-expanded', String(willOpen));
|
|
if (willOpen) {
|
|
// Align the flyout with the clicked row rather than the menu top.
|
|
positionPanel(parent);
|
|
}
|
|
});
|
|
}
|