mirror of
https://github.com/pewdiepie-archdaemon/odysseus.git
synced 2026-10-06 06:52:20 +02:00
Léo
1323fab0bd
static/style.css no longer holds every rule. 79 rules for the document, gallery and editor panels now live in static/css/, yet 27 browser tests still built their synthetic page with a single <link> to style.css, and 51 more read that one file as though it were the whole cascade. Those tests kept passing while covering less: a rule that moved became invisible to the assertion that was meant to pin it. Python readers now call tests.helpers.stylesheets.app_css(), and synthetic pages are built from stylesheet_link_tags() so they load exactly what index.html loads, in the same order. The helper already existed; this moves the remaining callers onto it. test_portal_dropdown_z_js parametrised over a file list including style.css to assert an absence. Checking a negative against one file of a split stylesheet is how a moved rule escapes, so the CSS case now checks the concatenation. Two guards keep it from coming back: one fails on any test reading static/style.css directly, the other on any synthetic page linking it alone. Both name the helper to use. No production code changes. Suite is unchanged at 6 pre-existing failures.
51 lines
2.3 KiB
Python
51 lines
2.3 KiB
Python
"""Regression guards for the Documents editor scrolling UI.
|
|
|
|
Issues #1501 and #1496 both come from the same surface: the document editor
|
|
hid its real textarea scrollbar, and the line-number gutter tried to scroll an
|
|
overflow-hidden element. Long wrapped lines add another wrinkle: the textarea
|
|
can have more visual rows than logical newline rows, so the gutter rows must
|
|
match the textarea's measured row heights. Keep these as static checks because
|
|
document.js is browser-coupled and not importable in pytest.
|
|
"""
|
|
|
|
from pathlib import Path
|
|
from tests.helpers.stylesheets import app_css
|
|
|
|
|
|
ROOT = Path(__file__).resolve().parents[1]
|
|
DOC_JS = (ROOT / "static/js/document.js").read_text(encoding="utf-8")
|
|
STYLE_CSS = app_css()
|
|
|
|
|
|
def test_document_textarea_scrollbar_is_visible():
|
|
textarea_rule_start = STYLE_CSS.index(".doc-editor-textarea {\n position: absolute;")
|
|
textarea_rule_end = STYLE_CSS.index(".doc-editor-textarea::placeholder", textarea_rule_start)
|
|
textarea_css = STYLE_CSS[textarea_rule_start:textarea_rule_end]
|
|
|
|
assert "overflow-y: scroll;" in textarea_css
|
|
assert "scrollbar-width: thin;" in textarea_css
|
|
assert ".doc-editor-textarea::-webkit-scrollbar { width: 8px; }" in STYLE_CSS
|
|
assert ".doc-editor-textarea::-webkit-scrollbar { display: none; }" not in STYLE_CSS
|
|
|
|
|
|
def test_line_number_gutter_translates_inner_content():
|
|
assert "function _lineNumberContentEl(gutter)" in DOC_JS
|
|
assert "inner.className = 'doc-line-number-content';" in DOC_JS
|
|
assert ".style.transform = `translateY(${-textarea.scrollTop}px)`;" in DOC_JS
|
|
assert "gutter.scrollTop = textarea.scrollTop;" not in DOC_JS
|
|
assert ".doc-line-number-content" in STYLE_CSS
|
|
|
|
|
|
def test_line_number_gutter_accounts_for_wrapped_rows():
|
|
assert "function _measureLineNumberHeights(textarea, lines, textWidth, style)" in DOC_JS
|
|
assert "probe = document.createElement('textarea');" in DOC_JS
|
|
assert "probe.wrap = 'soft';" in DOC_JS
|
|
assert "probe.value = line || ' ';" in DOC_JS
|
|
assert "Math.round(probe.scrollHeight / lineHeight)" in DOC_JS
|
|
assert "row.style.height = `${heights[i]}px`;" in DOC_JS
|
|
assert "label.className = 'doc-line-number-label';" in DOC_JS
|
|
assert "inner.textContent = lines;" not in DOC_JS
|
|
assert ".doc-line-number-row" in STYLE_CSS
|
|
assert ".doc-line-number-label" in STYLE_CSS
|
|
assert ".doc-line-number-measure" in STYLE_CSS
|