Afonso Coutinho
24ed412b64
fix: check-in calendar digest leaks every user's events (missing owner scope) ( #1925 )
...
* fix: check-in calendar digest leaks every user's events (no owner scope)
* Seed dtend on calendar events in digest test so the NOT NULL column is satisfied
2026-06-16 02:42:41 +01:00
Afonso Coutinho
1a686ab5d8
test(research): cover complete status CLI alias
...
Adds focused regression coverage for the research CLI complete-to-done status alias.
2026-06-11 15:49:12 +03:00
Afonso Coutinho
b416e5beea
fix: backup import dropping a user's skill on cross-tenant title/id collision ( #2057 )
...
* Fix backup import dropping a user's skill on cross-tenant title/id collision
The skills block of import_data deduped incoming skills against
skills_manager.load_all(), which returns EVERY tenant's skills. So when
a user imports their own backup, any skill whose id or title collides
with another user's skill was silently skipped — the importing user
lost their own data. This is the same cross-tenant bug already fixed
for the memories block just above (#1743 ); the skills block was left
with the old pattern. Filter the dedup sets to the importing user's own
skills (owner == user); the full store is still saved back, preserving
other users' skills.
* Restore sys.modules after stubbing so backup test does not break collection of later src.* test modules
* Patch backup_routes auth helpers via monkeypatch instead of sys.modules stubs so the test is import-order robust
* Give FakeSkillsManager an add_skill method matching the disk-backed skills API
2026-06-09 08:04:22 +02:00
afonsopc
302b789b51
Stub llm_core via monkeypatch.setitem so the cross-tenant test does not leak its fake into later test modules
2026-06-05 00:04:15 +01:00
afonsopc
80a70eb7eb
Update degraded-vector dedup test for owner-scoped vector match
2026-06-04 23:45:13 +01:00
afonsopc
8409d7cf2a
Fix auto-memory vector dedup dropping a user's fact on cross-tenant match
...
extract_and_store dedups each extracted fact against the vector store
before the (owner-scoped) text fallback. The vector store is a single
shared ChromaDB collection storing only {"source": "memory"} — no
owner — and find_similar queries it with no owner filter, so it can
return a memory_id belonging to a different tenant. The old code
continue'd (skipped storing) on any vector hit without checking
ownership, so when ChromaDB is healthy (the common path) a user's
freshly-extracted fact was silently dropped because it was merely
semantically similar to another user's memory — the text fallback that
IS owner-scoped never ran. Gate the skip on the matched memory being
this user's own (or legacy unowned), mirroring the text dedup predicate;
cross-tenant or stale matches fall through. Same bug class as #1743 .
2026-06-04 23:45:13 +01:00
Afonso Coutinho
db6136baa3
Fix truncate_messages persisting an inflated message_count ( #2052 )
...
truncate_messages deletes db_messages[keep_count:] (a no-op when
keep_count >= the real message total) then unconditionally wrote
db_session.message_count = keep_count. When keep_count exceeds the
number of messages that actually exist — e.g. the manage_session AI
tool defaults keep_count to 10, and the HTTP truncate endpoint passes
any client value — the persisted count is set too high (10 on a
3-message session), diverging from the real row count. That column
gates lazy DB-hydration in get_session (message_count > 0) and is
surfaced to the history UI, so it is correctness-relevant. Clamp to
min(keep_count, len(db_messages)); the in-memory slice already caps
naturally.
2026-06-04 21:19:16 +02:00
Afonso Coutinho
c10a2b93b4
fix: renaming a user leaves their API tokens resolving to the old owner ( #1932 )
...
* fix: renaming a user leaves their API tokens resolving to the old owner
* Drive rename token-cache test through the real auth resolver instead of patching a closure
2026-06-04 20:37:59 +02:00
Afonso Coutinho
607fc91155
fix: merge-last-assistant deletes tool/system rows from the DB (history desync) ( #1929 )
2026-06-04 19:47:08 +02:00
Afonso Coutinho
695a639fec
fix(auth): revoke API tokens when deleting users
...
* fix: revoke API bearer tokens when their owner is deleted
* Re-run CI
* Invalidate bearer-token cache on user delete so warmed cached tokens stop working
2026-06-04 04:44:34 +01:00
Afonso Coutinho
5e940b2996
fix(calendar): scope CalDAV event lookup by calendar
...
* fix: CalDAV sync hijacks another user's event sharing a VEVENT uid
* Seed schema-valid dtstart/dtend in caldav uid-scope test fixture
2026-06-04 04:01:21 +01:00
Afonso Coutinho
724c1e27be
fix: image model ranking crashes on a non-string search filter ( #1898 )
2026-06-04 03:26:35 +01:00
Afonso Coutinho
3d00e63927
fix: image model ranking crashes when system is not a dict ( #1900 )
2026-06-04 03:23:59 +01:00
Afonso Coutinho
8ee75ceb76
fix: model cost/info matches first substring key (gpt-4o-mini billed as gpt-4o) ( #1439 )
...
* fix: match model name to the longest known key, not the first substring
* test: model key matching prefers the longest specific key
2026-06-04 03:05:37 +01:00
Afonso Coutinho
58e679e15a
fix(memory): owner-scope memory route session access
2026-06-03 23:13:56 +01:00
Afonso Coutinho
1d8f0447d0
fix: skill retrieval boosts on tag substrings (e.g. 'ai' tag for any 'email' query) ( #1406 )
...
* fix: match skill tags as whole tokens, not substrings, in retrieval
* test: skill tag matching uses whole tokens, not substrings
* test: give skill fixtures status=published so they reach the scoring path
2026-06-03 14:24:11 +09:00
Afonso Coutinho
34dddb34df
fix: SMTP envelope recipients split on commas inside display names ( #1464 )
2026-06-03 14:23:58 +09:00
Afonso Coutinho
2cedb02428
fix: sports-hint ranking penalty fires on 'transport'/'passport' substrings ( #1473 )
...
* fix: sports-hint ranking penalty fires on 'transport'/'passport' substrings
* Apply word-boundary sports-hint fix to src/search/ranking.py as well
2026-06-03 14:23:52 +09:00
Afonso Coutinho
817205d60e
fix: PDF attach uses lstrip(chars) that eats body text, not the marker helper ( #1541 )
2026-06-03 14:23:37 +09:00
Afonso Coutinho
67244cc055
fix: POST /api/contacts/add crashes on JSON null name/email (None.strip()) ( #1544 )
2026-06-03 14:23:34 +09:00
Afonso Coutinho
a50c9e0c73
fix: params_b crashes the whole ranking on a malformed parameter_count ( #1550 )
2026-06-03 14:23:30 +09:00
Afonso Coutinho
98a5559ccb
fix: Mixtral and Ministral models render with no provider logo ( #1640 )
2026-06-03 14:23:21 +09:00
Afonso Coutinho
3e14e20d08
fix: _strip_reasoning_prose discards the answer when reasoning trails it ( #1643 )
2026-06-03 14:23:15 +09:00
Afonso Coutinho
59b27f2afb
Anchor shell-verb intent patterns to imperative or can-you position ( #1664 )
2026-06-03 14:23:10 +09:00
Afonso Coutinho
0223064e99
fix: deep research runs the prompt's example queries when the model echoes them ( #1666 )
2026-06-03 14:23:07 +09:00
Afonso Coutinho
084e73aaf3
fix: gallery records raw instead of display dimensions for EXIF-rotated photos ( #1667 )
2026-06-03 14:23:04 +09:00
Afonso Coutinho
e3245d0c29
fix: monthly tasks scheduled for day 29-31 skip every short month ( #1668 )
2026-06-03 14:23:01 +09:00
Afonso Coutinho
98b2065798
fix: services research lists junk no-content pages as cited sources ( #1669 )
2026-06-03 14:22:58 +09:00
Afonso Coutinho
2c73078290
fix: web search content blocks numbered by fetch completion order break citations ( #1672 )
2026-06-03 14:22:55 +09:00
Afonso Coutinho
c8133be9db
fix: re-importing an ICS file duplicates every tz-aware timed event ( #1683 )
2026-06-03 14:22:49 +09:00
Afonso Coutinho
117154d6fe
fix: visual report drops photos whose URL slug contains icon or logo ( #1685 )
2026-06-03 14:22:45 +09:00
Afonso Coutinho
2b327769df
fix: hwfit native quant labels miss the cost maps and over-estimate VRAM ( #1690 )
2026-06-03 14:22:42 +09:00
Afonso Coutinho
5a82f60d2d
fix: _parse_dt does not understand 'tonight' so event start/end breaks ( #1488 )
2026-06-03 14:14:41 +09:00
Afonso Coutinho
083d311da4
fix: context_compactor token helpers crash on non-string message text ( #1634 )
...
* fix: context_compactor token helpers crash on non-string message text
* fix: _truncate_text_to_token_budget returns an empty string for non-string text, not the raw value
2026-06-03 14:12:14 +09:00
Afonso Coutinho
e33c9ba609
fix: is_public_blocked_tool crashes on a truthy non-string tool name ( #1620 )
...
* fix: is_public_blocked_tool crashes on a truthy non-string tool name
* fix: is_public_blocked_tool fails closed (blocks) on a malformed non-string tool name
2026-06-03 14:11:14 +09:00
Afonso Coutinho
290a3ba714
fix: _lookup_bandwidth crashes on a truthy non-string gpu_name ( #1641 )
2026-06-03 14:11:10 +09:00
Afonso Coutinho
e9826b7989
fix: agent_tools._truncate crashes on non-string input ( #1624 )
...
* fix: agent_tools._truncate crashes on non-string input
* fix: agent_tools._truncate returns a string for non-string input, not the raw value
2026-06-03 14:06:39 +09:00
Afonso Coutinho
19cce9499c
fix: visual_report markdown helpers crash on a non-string input ( #1633 )
2026-06-03 14:06:35 +09:00
Afonso Coutinho
17532340a0
Parse standard Gmail quote attribution dates
...
Allow Gmail quote attribution parsing to handle standard US weekday/month/day/year comma patterns while preserving existing formats, with JS regression coverage.
2026-06-03 13:45:56 +09:00
Afonso Coutinho
cfdeec47a1
Decode email headers without injected spaces
...
Use email.header.make_header for MIME header decoding so adjacent encoded/plain header parts preserve RFC spacing, with regression coverage.
2026-06-03 13:45:33 +09:00
Afonso Coutinho
5a89b52698
Merge search analytics defaults in services copy
...
Make services.search.analytics tolerate missing counters in older or partial analytics files by merging loaded data over defaults, with regression coverage.
2026-06-03 13:45:07 +09:00
Afonso Coutinho
11e3967083
Normalize scheduled email offsets before storage
...
Normalize scheduled email send_at values with timezone offsets or Z suffixes to naive UTC before storing, matching the poller's lexicographic comparison format and preventing early/late sends.
2026-06-03 13:44:18 +09:00
Afonso Coutinho
acaba896dd
Treat non-string research summaries as low quality
...
Filter malformed non-string research summaries instead of letting the broad exception path classify them as usable, with regression coverage.
2026-06-03 13:42:24 +09:00
Afonso Coutinho
296ca6df6b
Skip malformed personal keyword index rows
...
Make personal keyword retrieval tolerate corrupted non-dict index entries and missing chunk lists, with regression coverage.
2026-06-03 13:42:05 +09:00
Afonso Coutinho
4646d672f4
fix: extract_youtube_id crashes on a non-string url instead of returning None ( #1689 )
2026-06-03 13:38:11 +09:00
Afonso Coutinho
1c822c2141
fix: memory entry validation crashes on a non-dict row from memory.json ( #1691 )
2026-06-03 13:38:02 +09:00
Afonso Coutinho
730dbb9fe5
fix: require_privilege 500s on a non-dict privileges blob from auth.json ( #1693 )
2026-06-03 13:37:54 +09:00
Afonso Coutinho
5bedfaa1d8
fix: updating a calendar event ignores user timezone and shifts the time ( #1695 )
2026-06-03 13:37:39 +09:00
Afonso Coutinho
c1b674c709
fix: reply-all Cc builder crashes on a non-string To or Cc field ( #1700 )
2026-06-03 13:37:22 +09:00
Afonso Coutinho
afbc0fa13c
fix: streaming drops providers that emit SSE data lines with no space ( #1701 )
2026-06-03 13:37:14 +09:00
Afonso Coutinho
99904eb7f5
fix: token usage dropped when it rides on a non-empty finish delta ( #1703 )
2026-06-03 13:36:57 +09:00
Afonso Coutinho
8dddc96944
fix: memory recall crashes on a non-dict row from the vector store ( #1705 )
2026-06-03 13:35:09 +09:00
Afonso Coutinho
42cb0d5429
fix: docs RAG query crashes on a non-dict row from the index ( #1706 )
2026-06-03 13:35:01 +09:00
Afonso Coutinho
7b7ae6f488
fix: archive browser model filter is suffix-only and drops matching models ( #1709 )
2026-06-03 13:34:54 +09:00
Afonso Coutinho
b08e8c66c8
fix: compacting a chat with image attachments destroys the attachment ( #1710 )
2026-06-03 13:34:47 +09:00
Afonso Coutinho
77e05cfd58
fix: research source extraction crashes on a non-dict finding ( #1714 )
2026-06-03 13:34:40 +09:00
Afonso Coutinho
94c943049b
fix: _resolve_user_upload_path crashes on a non-dict resolve_upload result ( #1715 )
2026-06-03 13:34:33 +09:00
Afonso Coutinho
dd4bb81fa0
fix: computeSnap throws when ctx.otherLayers is not an array ( #1716 )
2026-06-03 13:34:25 +09:00
Afonso Coutinho
7c0588492b
fix: evaluate_turn_regex crashes on a non-string agent_reply ( #1723 )
2026-06-03 13:31:26 +09:00
Afonso Coutinho
c9c1dbc7ab
fix: rewriting a message is lost on reload due to a non-existent DB column ( #1729 )
2026-06-03 13:31:19 +09:00
Afonso Coutinho
55b3537ce1
fix: odysseus-mail read crashes on an empty IMAP fetch payload ( #1730 )
2026-06-03 13:31:10 +09:00
Afonso Coutinho
122b1077b8
fix: _extract_entities crashes on a non-string query ( #1724 )
2026-06-03 13:30:28 +09:00
Afonso Coutinho
f4c1dad3c2
fix: search service crashes on a non-dict result row ( #1725 )
2026-06-03 13:30:19 +09:00
Afonso Coutinho
749480b2f9
fix: a non-dict finding silently drops all raw research findings ( #1739 )
2026-06-03 13:29:29 +09:00
Afonso Coutinho
babfb6cfa7
fix: langIcon throws on an explicit null opts argument ( #1740 )
2026-06-03 13:29:21 +09:00
Afonso Coutinho
b9b44f1cd5
fix: backup import drops a user's memory when its text matches another user's ( #1743 )
2026-06-03 13:29:14 +09:00
Afonso Coutinho
b9daae2578
fix: youtube transcript formatter crashes on a non-dict segment ( #1745 )
2026-06-03 13:29:08 +09:00
Afonso Coutinho
df8ce5a63b
fix: youtube (services) comment formatter crashes on a non-dict comment ( #1746 )
2026-06-03 13:29:01 +09:00
Afonso Coutinho
ad0cd0898c
fix: uploads with _ or - in the extension become permanently unreadable ( #1756 )
2026-06-03 13:28:45 +09:00
Afonso Coutinho
4b7e31a2c8
fix: document library language facet undercounts text documents ( #1758 )
2026-06-03 13:28:38 +09:00
Afonso Coutinho
099498c028
fix: chat memory extraction crashes on a non-dict message ( #1749 )
2026-06-03 13:25:48 +09:00
Afonso Coutinho
ed0f1869a1
fix: _derive_title crashes on non-string content instead of returning Untitled ( #1751 )
2026-06-03 13:25:41 +09:00
Afonso Coutinho
0d5250b861
fix: is_youtube_url crashes on a non-string url ( #1752 )
2026-06-03 13:24:33 +09:00
Afonso Coutinho
71f35f2595
fix: is_youtube_url (services) crashes on a non-string url ( #1753 )
2026-06-03 13:24:24 +09:00
Afonso Coutinho
913dc67384
fix: ui_control rejects the advertised rag toggle ( #1763 )
2026-06-03 13:24:00 +09:00
Afonso Coutinho
f332b8ea99
fix: disabling auth wipes all users' preferences on next pref save ( #1764 )
2026-06-03 13:23:50 +09:00
Afonso Coutinho
c375f83c44
fix: gallery tag filters and tag-cleanup are empty in single-user mode ( #1771 )
2026-06-03 13:23:08 +09:00
Afonso Coutinho
039095d748
fix: document tidy crashes on a duplicate with NULL timestamps ( #1772 )
2026-06-03 13:23:01 +09:00
Afonso Coutinho
d23fdb32ea
fix: signature learning never skips support@/info@/admin@ senders ( #1773 )
2026-06-03 13:22:52 +09:00
Afonso Coutinho
7c1a6bf02a
fix: signature delimiter fold misses self-closing <br/> breaks ( #1774 )
2026-06-03 13:22:46 +09:00
Afonso Coutinho
8bcb3c61f5
fix: is_markitdown_format crashes on a non-string path ( #1618 )
2026-06-03 09:00:10 +09:00
Afonso Coutinho
fcb1884154
fix: inside_base_dir raises TypeError on a non-string path instead of failing closed ( #1619 )
2026-06-03 09:00:04 +09:00
Afonso Coutinho
987fe6c0ee
fix: document_actions title/content helpers crash on non-string input ( #1621 )
2026-06-03 08:59:55 +09:00
Afonso Coutinho
b50a1bf0c7
fix: check_outbound_url crashes on a truthy non-string URL ( #1623 )
2026-06-03 08:59:49 +09:00
Afonso Coutinho
4b65376944
fix: tool-block parsing crashes on a non-string input ( #1628 )
2026-06-03 08:59:42 +09:00
Afonso Coutinho
88fd0f7e68
fix: _extract_skill_json crashes on a truthy non-string teacher response ( #1630 )
2026-06-03 08:59:36 +09:00
Afonso Coutinho
f588be4e73
fix: logs CLI _resolve crashes on a non-string name ( #1631 )
2026-06-03 08:59:30 +09:00
Afonso Coutinho
aa5462a4b6
fix: skill test-task / precision helpers crash on a non-dict skill ( #1638 )
2026-06-03 08:59:24 +09:00
Afonso Coutinho
9cd4778b65
fix: builtin_actions heuristics crash on a truthy non-string input ( #1639 )
2026-06-03 08:59:16 +09:00
Afonso Coutinho
51a53426e4
fix: split_chunks emits a duplicate trailing chunk for text over size-overlap ( #1573 )
2026-06-03 08:57:54 +09:00
Afonso Coutinho
fcb82dd7f6
fix: monthly schedule label shows 21th/22th/31th (ordinal suffix for days >20) ( #1577 )
2026-06-03 08:57:47 +09:00
Afonso Coutinho
dfdb8958b5
fix: skills CLI summary crashes on a non-string description ( #1595 )
2026-06-03 08:37:05 +09:00
Afonso Coutinho
4e4a9b0c22
fix: research CLI summary crashes on a non-string query ( #1596 )
2026-06-03 08:36:57 +09:00
Afonso Coutinho
cb7f381884
fix: gallery CLI image serialization crashes on a non-string prompt ( #1598 )
2026-06-03 08:36:51 +09:00
Afonso Coutinho
a8853cb8b1
fix: rag_server add/remove_directory crashes on a non-string directory arg ( #1614 )
2026-06-03 08:36:45 +09:00
Afonso Coutinho
b7d17d9beb
fix: search query helpers crash on a non-string query ( #1604 )
2026-06-03 08:36:01 +09:00
Afonso Coutinho
1a3179c0a2
fix: shared MCP truncate() crashes on None/non-string tool output ( #1605 )
2026-06-03 08:35:54 +09:00
Afonso Coutinho
158ebb6984
fix: _sanitize_export_filename crashes on a non-string session name ( #1607 )
2026-06-03 08:35:47 +09:00
Afonso Coutinho
7ad44a7731
fix: validate_caldav_url crashes with TypeError on a non-string URL ( #1608 )
2026-06-03 08:35:16 +09:00
Afonso Coutinho
6d2cb99f6f
fix: mcp CLI _serialize crashes when stored env JSON is a list ( #1609 )
2026-06-03 08:35:09 +09:00