jpmschweitzerandClaude
1fb4786f18
test / unit + widget + golden + a11y (push) Failing after 35s
test / integration_test (xvfb) (push) Has been skipped
test / bundle smoke (xvfb 5s) (push) Has been skipped
test / daemon subprocess + web WASM smoke (push) Has been skipped
test / dart doc (lib API) (push) Failing after 1m0s
Clears the 19 misc lint hits left after the test_app print sweep
+ libc.dart suppression. By rule:
- `withOpacity(α)` → `withValues(alpha: α)` (deprecated_member_use)
in `painter.dart:187` and `terminal_view.dart:318`.
- `Pointer.elementAt(n)` → `Pointer + n` (deprecated_member_use)
in `native_pty.dart:306` and `session.dart:187`.
- Brace single-statement for/if bodies in `native_pty.dart`
(×3) and `decisions_view.dart` (curly_braces_in_flow_control_
structures).
- `IsolateClient` and `InProcessClient` constructors switched to
`super.log` / `super.events` parameters (use_super_parameters);
associated unused imports of `kernel/src/log.dart` and
`kernel/src/events/bus.dart` removed in the same files.
- `InProcessClient._dispatcher` field + getter/setter pair folded
into a single mutable public `dispatcher` field
(unnecessary_getters_setters).
- `_buildDispatcher` local in `lib/main.dart` renamed to
`buildDispatcher` (no_leading_underscores_for_local_identifiers).
- `_onTapDown(_)` in `terminal_view.dart` typed as
`TapDownDetails _` (strict_top_level_inference).
- `operator []=(...)` in `circular_buffer.dart` given an explicit
`void` return type (strict_top_level_inference).
- `CustomKeyboardListener` and `TerminalGestureDetector` callsites
reordered so `child:` lands last (sort_child_properties_last).
- `CustomTextEdit` constructor declared `const`
(prefer_const_constructors_in_immutables).
- `LinkedHashMap<K, V>()` in `paragraph_cache.dart` collapsed to a
`<K, V>{}` literal (prefer_collection_literals); the now-unused
`dart:collection` import dropped.
Project analyze: 19 → 0 issues. `make test` stays green; coverage
unchanged at 52.72%.
Co-Authored-By: Claude <noreply@anthropic.com>
72 lines
2.1 KiB
Dart
72 lines
2.1 KiB
Dart
/// IPC client that sends requests to a backend isolate via SendPort.
|
|
///
|
|
/// Replaces [InProcessClient] for production use. The backend isolate
|
|
/// owns the [DaemonDispatcher] and all subprocess/file-I/O services.
|
|
/// Requests and responses travel as serialized Maps over SendPort,
|
|
/// reusing the existing IPC protocol (IpcRequest/IpcResponse/IpcEvent).
|
|
library;
|
|
|
|
import 'dart:async';
|
|
import 'dart:isolate';
|
|
|
|
import 'package:clide/clide.dart';
|
|
import 'package:clide/kernel/src/events/bus.dart';
|
|
import 'package:clide/kernel/src/events/types.dart';
|
|
import 'package:clide/kernel/src/ipc/client.dart';
|
|
|
|
class IsolateClient extends DaemonClient {
|
|
IsolateClient({
|
|
required super.log,
|
|
required super.events,
|
|
required SendPort backendPort,
|
|
}) : _backendPort = backendPort,
|
|
_events = events,
|
|
super(socketPath: '');
|
|
|
|
final SendPort _backendPort;
|
|
final DaemonBus _events;
|
|
|
|
/// The event bus that receives events from the backend.
|
|
DaemonBus get events => _events;
|
|
final Map<String, Completer<IpcResponse>> _pending = {};
|
|
int _nextId = 0;
|
|
|
|
/// Called by [Backend] to feed incoming messages from the backend isolate.
|
|
void handleMessage(Map<String, Object?> msg) {
|
|
final type = msg['type'] as String?;
|
|
switch (type) {
|
|
case 'response':
|
|
final resp = IpcResponse.fromJson(msg);
|
|
final c = _pending.remove(resp.id);
|
|
if (c != null && !c.isCompleted) c.complete(resp);
|
|
case 'event':
|
|
final evt = IpcEvent.fromJson(msg);
|
|
_events.emit(DaemonEvent(
|
|
subsystem: evt.subsystem,
|
|
kind: evt.kind,
|
|
data: evt.data,
|
|
ts: evt.timestamp,
|
|
));
|
|
}
|
|
}
|
|
|
|
@override
|
|
bool get isConnected => true;
|
|
|
|
@override
|
|
Future<void> start() async {}
|
|
|
|
@override
|
|
Future<void> stop() async {}
|
|
|
|
@override
|
|
Future<IpcResponse> request(String cmd, {Map<String, Object?> args = const {}}) {
|
|
final id = '${_nextId++}';
|
|
final req = IpcRequest(id: id, cmd: cmd, args: args);
|
|
final c = Completer<IpcResponse>();
|
|
_pending[id] = c;
|
|
_backendPort.send(req.toJson());
|
|
return c.future;
|
|
}
|
|
}
|