3 Commits

Include renames

Author	SHA1	Message	Date
jpmschweitzerandClaude	1fb4786f18	sweep remaining analyze infos to zero ... Clears the 19 misc lint hits left after the test_app print sweep + libc.dart suppression. By rule: - `withOpacity(α)` → `withValues(alpha: α)` (deprecated_member_use) in `painter.dart:187` and `terminal_view.dart:318`. - `Pointer.elementAt(n)` → `Pointer + n` (deprecated_member_use) in `native_pty.dart:306` and `session.dart:187`. - Brace single-statement for/if bodies in `native_pty.dart` (×3) and `decisions_view.dart` (curly_braces_in_flow_control_ structures). - `IsolateClient` and `InProcessClient` constructors switched to `super.log` / `super.events` parameters (use_super_parameters); associated unused imports of `kernel/src/log.dart` and `kernel/src/events/bus.dart` removed in the same files. - `InProcessClient._dispatcher` field + getter/setter pair folded into a single mutable public `dispatcher` field (unnecessary_getters_setters). - `_buildDispatcher` local in `lib/main.dart` renamed to `buildDispatcher` (no_leading_underscores_for_local_identifiers). - `_onTapDown(_)` in `terminal_view.dart` typed as `TapDownDetails _` (strict_top_level_inference). - `operator []=(...)` in `circular_buffer.dart` given an explicit `void` return type (strict_top_level_inference). - `CustomKeyboardListener` and `TerminalGestureDetector` callsites reordered so `child:` lands last (sort_child_properties_last). - `CustomTextEdit` constructor declared `const` (prefer_const_constructors_in_immutables). - `LinkedHashMap<K, V>()` in `paragraph_cache.dart` collapsed to a `<K, V>{}` literal (prefer_collection_literals); the now-unused `dart:collection` import dropped. Project analyze: 19 → 0 issues. `make test` stays green; coverage unchanged at 52.72%. Co-Authored-By: Claude <noreply@anthropic.com>	2026-05-06 23:51:46 +02:00
Jeroen SchweitzerandClaude Opus 4.6	45e8132a41	async recvFd + backend terminal test (sandbox blocks ptyc exec) ... PtySession.spawn() now runs recvFd in a child isolate via Isolate.spawn so the blocking FFI call doesn't stall the backend isolate's event loop. Terminal testmode test spawns a real backend isolate, opens a project, and sends pane.spawn via IPC — the exact same path the full app uses. Currently fails: ptyc successfully starts but its fork+execvp is blocked by the macOS sandbox ("Operation not permitted"). The SBPL allows /bin/zsh exec from the app process, but ptyc's child process may not inherit the exec permission, or the PTYC_SOCK_FD is not inherited by the ptyc child (Dart Process.start fd inheritance on macOS). IsolateClient.events getter exposed for test access. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	2026-04-26 15:55:29 +02:00
Jeroen SchweitzerandClaude Opus 4.6	a89910dc36	move daemon services to backend isolate ... The merged UI/platform thread on macOS (Flutter 3.41) freezes on any synchronous work — file I/O, Process.run, even isolate spawning during early frames. No timing workaround (Timer, addPostFrameCallback, Future.delayed) was reliable. Fix: spawn a backend isolate that owns the DaemonDispatcher, GitClient, PqlClient, FilesService, EditorRegistry, and Toolchain resolution. The main isolate stays free for rendering. Communication uses SendPort with the existing IPC message protocol (IpcRequest/IpcResponse/IpcEvent) — zero new serialization. New files: backend.dart — spawns isolate, manages SendPort/ReceivePort backend_entry.dart — isolate entry point, boots all services isolate_client.dart — replaces InProcessClient for production Toolchain now exposes resolveToolchainPaths() as a top-level function with self-contained PATH expansion (no module-level state that would prevent isolate message passing). ClideTestApp gains boot-sequence tests: compute(), Isolate.run(), sequential Process.run, and the full resolve+exec chain. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>	2026-04-26 13:53:33 +02:00