jpmschweitzer/clide
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor(i18n): route remaining extension labels through the catalog (T-468)

Browse Source 
Migrate the user-facing strings in menubar, output, search, deeplink, editor,
files, terminal, markdown, and vim to ClideSettings.i18n.string/.interpolated;
extend the existing catalogs and create the missing ones (deeplink, output,
search, markdown, menubar, vim). vim mode labels now resolve through
builtin.vim (default still `-- NORMAL --`, now localizable). A dock-status test
seeds builtin.output so the widget's own i18n lookups resolve instead of
warning into the logRing it counts. No en_US behaviour change (D-21).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
jpmschweitzer
2026-06-18 22:16:20 +02:00
co-authored by Claude Opus 4.8
parent 17d22b9571
commit c5500dc235
25 changed files with 495 additions and 97 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/builtin/terminal/src/terminal_pane.dart
+32 -4
View File
@@ -140,14 +140,38 @@ class _TerminalPaneState extends State<TerminalPane> {
@override
Widget build(BuildContext context) {
final subtitle = _error != null ? _error! : (_paneId == null ? 'spawning shell…' : 'pid $_pid · ${_paneId!}');
final spawning = ClideSettings.i18n.string(context, 'subtitle.spawning', namespace: 'builtin.terminal', placeholder: 'spawning shell…');
final errorText = _error == null ? null : _localizeError(context, _error!);
final subtitle = errorText ?? (_paneId == null ? spawning : 'pid $_pid · ${_paneId!}');
return ClidePaneChrome(
title: 'terminal',
title: ClideSettings.i18n.string(context, 'chrome.title', namespace: 'builtin.terminal', placeholder: 'terminal'),
subtitle: subtitle,
child: _error != null ? _ErrorBody(message: _error!) : ClidePtyView(terminal: _terminal, label: 'terminal — $subtitle'),
child: errorText != null
? _ErrorBody(message: errorText)
: ClidePtyView(
terminal: _terminal,
label: ClideSettings.i18n.interpolated(
context,
'a11y.label',
namespace: 'builtin.terminal',
placeholder: 'terminal — {subtitle}',
replacers: [I18nReplacer(from: '{subtitle}', replace: subtitle)],
),
),
);
}
/// Localize the two known error literals stored in [_error] (set in async
/// handlers where `context` can't be used); any other value — e.g. a daemon
/// `response.error?.message` — is dynamic data and passes through as-is.
String _localizeError(BuildContext context, String raw) {
return switch (raw) {
'Backend not connected.' => ClideSettings.i18n.string(context, 'error.daemon', namespace: 'builtin.terminal', placeholder: 'Backend not connected.'),
'Shell exited.' => ClideSettings.i18n.string(context, 'subtitle.exited', namespace: 'builtin.terminal', placeholder: 'Shell exited.'),
_ => raw,
};
}
}
class _ErrorBody extends StatelessWidget {
@@ -161,7 +185,11 @@ class _ErrorBody extends StatelessWidget {
alignment: Alignment.topLeft,
child: Column(
crossAxisAlignment: CrossAxisAlignment.start,
children: [const ClideText('Terminal unavailable'), const SizedBox(height: 4), ClideText(message, muted: true)],
children: [
ClideText(ClideSettings.i18n.string(context, 'error.unavailable', namespace: 'builtin.terminal', placeholder: 'Terminal unavailable')),
const SizedBox(height: 4),
ClideText(message, muted: true),
],
),
),
);