jpmschweitzer/clide
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

drop dead mouse imports from terminal_view

Browse Source 
`mouse/button.dart` and `mouse/button_state.dart` were imported but
nothing in terminal_view referenced their symbols — analyzer
warnings, not infos. Removed.

Probable origin: a half-landed mouse-forwarding refactor (the actual
work is now scoped under T-74); the imports can come back when the
real wiring lands. Removing them in the meantime keeps the analyze
gate clean.

Co-Authored-By: Claude <noreply@anthropic.com>
This commit is contained in:
jpmschweitzer
2026-05-06 22:28:58 +02:00
co-authored by Claude
parent f0bb2ffcce
commit bfa128f131
2 changed files with 5 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.pql/pql-plan.json
+1 -1
View File
@@ -1,5 +1,5 @@
{ {
"exported_at": "2026-05-06T20:28:51Z", "exported_at": "2026-05-06T20:28:58Z",
"decisions": [ "decisions": [
{ {
"id": "D-1", "id": "D-1",
lib/src/terminal/src/terminal_view.dart
+4 -10
View File
@@ -8,8 +8,6 @@ import 'package:flutter/services.dart';
import 'package:clide/src/terminal/src/core/buffer/cell_offset.dart'; import 'package:clide/src/terminal/src/core/buffer/cell_offset.dart';
import 'package:clide/src/terminal/src/core/input/keys.dart'; import 'package:clide/src/terminal/src/core/input/keys.dart';
import 'package:clide/src/terminal/src/core/mouse/button.dart';
import 'package:clide/src/terminal/src/core/mouse/button_state.dart';
import 'package:clide/src/terminal/src/terminal.dart'; import 'package:clide/src/terminal/src/terminal.dart';
import 'package:clide/src/terminal/src/ui/controller.dart'; import 'package:clide/src/terminal/src/ui/controller.dart';
import 'package:clide/src/terminal/src/ui/cursor_type.dart'; import 'package:clide/src/terminal/src/ui/cursor_type.dart';
@@ -167,8 +165,7 @@ class TerminalViewState extends State<TerminalView> {
late ScrollController _scrollController; late ScrollController _scrollController;
RenderTerminal get renderTerminal => RenderTerminal get renderTerminal => _viewportKey.currentContext!.findRenderObject() as RenderTerminal;
_viewportKey.currentContext!.findRenderObject() as RenderTerminal;
void _onPointerSignal(PointerSignalEvent event) { void _onPointerSignal(PointerSignalEvent event) {
if (event is! PointerScrollEvent) return; if (event is! PointerScrollEvent) return;
@@ -306,10 +303,8 @@ class TerminalViewState extends State<TerminalView> {
terminalController: _controller, terminalController: _controller,
onTapUp: _onTapUp, onTapUp: _onTapUp,
onTapDown: _onTapDown, onTapDown: _onTapDown,
onSecondaryTapDown: onSecondaryTapDown: widget.onSecondaryTapDown != null ? _onSecondaryTapDown : null,
widget.onSecondaryTapDown != null ? _onSecondaryTapDown : null, onSecondaryTapUp: widget.onSecondaryTapUp != null ? _onSecondaryTapUp : null,
onSecondaryTapUp:
widget.onSecondaryTapUp != null ? _onSecondaryTapUp : null,
readOnly: widget.readOnly, readOnly: widget.readOnly,
child: child, child: child,
); );
@@ -344,8 +339,7 @@ class TerminalViewState extends State<TerminalView> {
} }
Rect get globalCursorRect { Rect get globalCursorRect {
return renderTerminal.localToGlobal(renderTerminal.cursorOffset) & return renderTerminal.localToGlobal(renderTerminal.cursorOffset) & renderTerminal.cellSize;
renderTerminal.cellSize;
} }
void _onTapUp(TapUpDetails details) { void _onTapUp(TapUpDetails details) {