From bfa128f1319fdbf8332ce6a9373690a9f05a4e00 Mon Sep 17 00:00:00 2001 From: Jeroen Schweitzer Date: Wed, 6 May 2026 22:28:58 +0200 Subject: [PATCH] drop dead mouse imports from terminal_view MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit `mouse/button.dart` and `mouse/button_state.dart` were imported but nothing in terminal_view referenced their symbols — analyzer warnings, not infos. Removed. Probable origin: a half-landed mouse-forwarding refactor (the actual work is now scoped under T-74); the imports can come back when the real wiring lands. Removing them in the meantime keeps the analyze gate clean. Co-Authored-By: Claude --- .pql/pql-plan.json | 2 +- lib/src/terminal/src/terminal_view.dart | 14 ++++---------- 2 files changed, 5 insertions(+), 11 deletions(-) diff --git a/.pql/pql-plan.json b/.pql/pql-plan.json index e8552aef..f2cff59a 100644 --- a/.pql/pql-plan.json +++ b/.pql/pql-plan.json @@ -1,5 +1,5 @@ { - "exported_at": "2026-05-06T20:28:51Z", + "exported_at": "2026-05-06T20:28:58Z", "decisions": [ { "id": "D-1", diff --git a/lib/src/terminal/src/terminal_view.dart b/lib/src/terminal/src/terminal_view.dart index 9e544e73..c776039a 100644 --- a/lib/src/terminal/src/terminal_view.dart +++ b/lib/src/terminal/src/terminal_view.dart @@ -8,8 +8,6 @@ import 'package:flutter/services.dart'; import 'package:clide/src/terminal/src/core/buffer/cell_offset.dart'; import 'package:clide/src/terminal/src/core/input/keys.dart'; -import 'package:clide/src/terminal/src/core/mouse/button.dart'; -import 'package:clide/src/terminal/src/core/mouse/button_state.dart'; import 'package:clide/src/terminal/src/terminal.dart'; import 'package:clide/src/terminal/src/ui/controller.dart'; import 'package:clide/src/terminal/src/ui/cursor_type.dart'; @@ -167,8 +165,7 @@ class TerminalViewState extends State { late ScrollController _scrollController; - RenderTerminal get renderTerminal => - _viewportKey.currentContext!.findRenderObject() as RenderTerminal; + RenderTerminal get renderTerminal => _viewportKey.currentContext!.findRenderObject() as RenderTerminal; void _onPointerSignal(PointerSignalEvent event) { if (event is! PointerScrollEvent) return; @@ -306,10 +303,8 @@ class TerminalViewState extends State { terminalController: _controller, onTapUp: _onTapUp, onTapDown: _onTapDown, - onSecondaryTapDown: - widget.onSecondaryTapDown != null ? _onSecondaryTapDown : null, - onSecondaryTapUp: - widget.onSecondaryTapUp != null ? _onSecondaryTapUp : null, + onSecondaryTapDown: widget.onSecondaryTapDown != null ? _onSecondaryTapDown : null, + onSecondaryTapUp: widget.onSecondaryTapUp != null ? _onSecondaryTapUp : null, readOnly: widget.readOnly, child: child, ); @@ -344,8 +339,7 @@ class TerminalViewState extends State { } Rect get globalCursorRect { - return renderTerminal.localToGlobal(renderTerminal.cursorOffset) & - renderTerminal.cellSize; + return renderTerminal.localToGlobal(renderTerminal.cursorOffset) & renderTerminal.cellSize; } void _onTapUp(TapUpDetails details) {